diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml index babdfb1095..2b86eeb838 100644 --- a/.github/ISSUE_TEMPLATE/config.yml +++ b/.github/ISSUE_TEMPLATE/config.yml @@ -1,15 +1,15 @@ blank_issues_enabled: false contact_links: -- name: Get help in GitHub Discussions - url: https://github.com/Homebrew/discussions/discussions - about: Have a question? Not sure if your issue affects everyone reproducibly? The quickest way to get help is on Homebrew's GitHub Discussions! -- name: New issue on Homebrew/homebrew-core - url: https://github.com/Homebrew/homebrew-core/issues/new/choose - about: On macOS/Mac OS X? Having a `brew` problem with a `brew install` or `brew upgrade` of a single formula/package? Report it to Homebrew/homebrew-core (the macOS core tap/repository). -- name: New issue on Homebrew/homebrew-cask - url: https://github.com/Homebrew/homebrew-cask/issues/new/choose - about: Having a `brew cask` problem? Report it to Homebrew/homebrew-cask (the cask tap/repository). -- name: New issue on Homebrew/linuxbrew-core - url: https://github.com/Homebrew/linuxbrew-core/issues/new/choose - about: On Linux? Having a `brew` problem with a `brew install` or `brew upgrade` of a single formula/package? Report it to Homebrew/linuxbrew-core (the Linux core tap/repository). + - name: Get help in GitHub Discussions + url: https://github.com/Homebrew/discussions/discussions + about: Have a question? Not sure if your issue affects everyone reproducibly? The quickest way to get help is on Homebrew's GitHub Discussions! + - name: New issue on Homebrew/homebrew-core + url: https://github.com/Homebrew/homebrew-core/issues/new/choose + about: On macOS/Mac OS X? Having a `brew` problem with a `brew install` or `brew upgrade` of a single formula/package? Report it to Homebrew/homebrew-core (the macOS core tap/repository). + - name: New issue on Homebrew/homebrew-cask + url: https://github.com/Homebrew/homebrew-cask/issues/new/choose + about: Having a `brew cask` problem? Report it to Homebrew/homebrew-cask (the cask tap/repository). + - name: New issue on Homebrew/linuxbrew-core + url: https://github.com/Homebrew/linuxbrew-core/issues/new/choose + about: On Linux? Having a `brew` problem with a `brew install` or `brew upgrade` of a single formula/package? Report it to Homebrew/linuxbrew-core (the Linux core tap/repository). diff --git a/.github/dependabot.yml b/.github/dependabot.yml index 6096421f30..b3ed8e6483 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -1,7 +1,6 @@ version: 2 updates: - - package-ecosystem: github-actions directory: / schedule: diff --git a/.github/workflows/doctor.yml b/.github/workflows/doctor.yml index c7baad301f..9a1c57de85 100644 --- a/.github/workflows/doctor.yml +++ b/.github/workflows/doctor.yml @@ -21,7 +21,7 @@ jobs: fail-fast: false runs-on: ${{ matrix.version }} env: - PATH: '/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin' + PATH: "/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin" steps: - name: Set up Homebrew id: set-up-homebrew diff --git a/.github/workflows/spdx.yml b/.github/workflows/spdx.yml index efe3f1ac61..224d13158d 100644 --- a/.github/workflows/spdx.yml +++ b/.github/workflows/spdx.yml @@ -6,7 +6,7 @@ on: branches-ignore: - master schedule: - - cron: '0 0 * * *' + - cron: "0 0 * * *" jobs: spdx: if: github.repository == 'Homebrew/brew' diff --git a/.github/workflows/triage-issues.yml b/.github/workflows/triage-issues.yml index 0f6cd9554d..f7a3c9ceda 100644 --- a/.github/workflows/triage-issues.yml +++ b/.github/workflows/triage-issues.yml @@ -4,7 +4,7 @@ name: Triage issues on: push: paths: - - .github/workflows/triage-issues.yml + - .github/workflows/triage-issues.yml schedule: # Once every day at midnight UTC - cron: "0 0 * * *" @@ -33,8 +33,8 @@ jobs: stale-pr-message: > This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. - exempt-issue-labels: 'gsoc-outreachy,help wanted,in progress' - exempt-pr-labels: 'gsoc-outreachy,help wanted,in progress' + exempt-issue-labels: "gsoc-outreachy,help wanted,in progress" + exempt-pr-labels: "gsoc-outreachy,help wanted,in progress" lock-threads: if: startsWith(github.repository, 'Homebrew/') && github.event_name != 'issue_comment' diff --git a/.github/workflows/triage.yml b/.github/workflows/triage.yml index 0beb8afcd4..9d551c86f4 100644 --- a/.github/workflows/triage.yml +++ b/.github/workflows/triage.yml @@ -10,7 +10,7 @@ on: - labeled - unlabeled schedule: - - cron: '0 */3 * * *' # every 3 hours + - cron: "0 */3 * * *" # every 3 hours jobs: review: diff --git a/Library/Homebrew/.rubocop.yml b/Library/Homebrew/.rubocop.yml index 25f2d15a46..6a49053b64 100644 --- a/Library/Homebrew/.rubocop.yml +++ b/Library/Homebrew/.rubocop.yml @@ -5,7 +5,7 @@ inherit_from: # make rspec formatting more flexible Layout/MultilineMethodCallIndentation: Exclude: - - '**/*_spec.rb' + - "**/*_spec.rb" # TODO: add parentheses for these and remove Lint/AssignmentInCondition: @@ -14,7 +14,7 @@ Lint/AssignmentInCondition: # `formula do` uses nested method definitions Lint/NestedMethodDefinition: Exclude: - - 'test/**/*' + - "test/**/*" # TODO: Try to bring down all metrics maximums. Metrics/AbcSize: @@ -22,14 +22,14 @@ Metrics/AbcSize: Metrics/BlockLength: Max: 100 Exclude: - - 'test/**/*' + - "test/**/*" Metrics/BlockNesting: Max: 5 Metrics/ClassLength: Max: 800 Exclude: - - 'formula.rb' - - 'formula_installer.rb' + - "formula.rb" + - "formula_installer.rb" Metrics/CyclomaticComplexity: Max: 80 Metrics/PerceivedComplexity: @@ -39,7 +39,7 @@ Metrics/MethodLength: Metrics/ModuleLength: Max: 600 Exclude: - - 'test/**/*' + - "test/**/*" Naming/PredicateName: # Can't rename these. @@ -50,8 +50,8 @@ Naming/PredicateName: Style/HashAsLastArrayItem: Exclude: - - 'test/utils/spdx_spec.rb' + - "test/utils/spdx_spec.rb" Style/BlockDelimiters: BracesRequiredMethods: - - 'sig' + - "sig" diff --git a/Library/Homebrew/.rubocop_todo.yml b/Library/Homebrew/.rubocop_todo.yml index d81dd0b498..dc0b0f6ba9 100644 --- a/Library/Homebrew/.rubocop_todo.yml +++ b/Library/Homebrew/.rubocop_todo.yml @@ -1,38 +1,38 @@ Style/Documentation: Exclude: - - 'compat/**/*.rb' - - 'extend/**/*.rb' - - 'cmd/**/*.rb' - - 'dev-cmd/**/*.rb' - - 'test/**/*.rb' - - 'cask/macos.rb' - - 'cli/args.rb' - - 'cli/parser.rb' - - 'global.rb' - - 'keg_relocate.rb' - - 'os/linux/global.rb' - - 'os/mac/architecture_list.rb' - - 'os/mac/global.rb' - - 'os/mac/keg.rb' - - 'reinstall.rb' - - 'software_spec.rb' - - 'upgrade.rb' - - 'utils.rb' - - 'utils/fork.rb' - - 'utils/gems.rb' - - 'utils/git_repository.rb' - - 'utils/popen.rb' - - 'utils/shell.rb' - - 'version.rb' + - "compat/**/*.rb" + - "extend/**/*.rb" + - "cmd/**/*.rb" + - "dev-cmd/**/*.rb" + - "test/**/*.rb" + - "cask/macos.rb" + - "cli/args.rb" + - "cli/parser.rb" + - "global.rb" + - "keg_relocate.rb" + - "os/linux/global.rb" + - "os/mac/architecture_list.rb" + - "os/mac/global.rb" + - "os/mac/keg.rb" + - "reinstall.rb" + - "software_spec.rb" + - "upgrade.rb" + - "utils.rb" + - "utils/fork.rb" + - "utils/gems.rb" + - "utils/git_repository.rb" + - "utils/popen.rb" + - "utils/shell.rb" + - "version.rb" Lint/EmptyBlock: Exclude: - - 'dependency.rb' - - 'dev-cmd/extract.rb' - - 'test/cache_store_spec.rb' - - 'test/checksum_verification_spec.rb' - - 'test/compiler_failure_spec.rb' - - 'test/formula_spec.rb' - - 'test/formula_validation_spec.rb' - - 'test/pathname_spec.rb' - - 'test/support/fixtures/cask/Casks/*flight*.rb' + - "dependency.rb" + - "dev-cmd/extract.rb" + - "test/cache_store_spec.rb" + - "test/checksum_verification_spec.rb" + - "test/compiler_failure_spec.rb" + - "test/formula_spec.rb" + - "test/formula_validation_spec.rb" + - "test/pathname_spec.rb" + - "test/support/fixtures/cask/Casks/*flight*.rb" diff --git a/Library/Homebrew/test/.rubocop.yml b/Library/Homebrew/test/.rubocop.yml index 4ed955456b..86832e9d27 100644 --- a/Library/Homebrew/test/.rubocop.yml +++ b/Library/Homebrew/test/.rubocop.yml @@ -4,4 +4,4 @@ inherit_from: RSpec: Include: - - ./* + - ./* diff --git a/Library/Homebrew/test/.rubocop_todo.yml b/Library/Homebrew/test/.rubocop_todo.yml index 8fdbaa949d..1bc0242833 100644 --- a/Library/Homebrew/test/.rubocop_todo.yml +++ b/Library/Homebrew/test/.rubocop_todo.yml @@ -10,168 +10,168 @@ # Configuration parameters: Max. RSpec/ExampleLength: Exclude: - - 'rubocops/patches_spec.rb' + - "rubocops/patches_spec.rb" # Offense count: 7 # Configuration parameters: AssignmentOnly. RSpec/InstanceVariable: Exclude: - - 'download_strategies_spec.rb' - - 'support/helper/spec/shared_context/integration_test.rb' - - 'utils/git_spec.rb' + - "download_strategies_spec.rb" + - "support/helper/spec/shared_context/integration_test.rb" + - "utils/git_spec.rb" # Offense count: 73 RSpec/MultipleDescribes: Exclude: - - 'ENV_spec.rb' - - 'cleanup_spec.rb' - - 'cmd/--cache_spec.rb' - - 'cmd/--cellar_spec.rb' - - 'cmd/--env_spec.rb' - - 'cmd/--prefix_spec.rb' - - 'cmd/--repository_spec.rb' - - 'cmd/--version_spec.rb' - - 'cmd/analytics_spec.rb' - - 'cmd/cleanup_spec.rb' - - 'cmd/commands_spec.rb' - - 'cmd/config_spec.rb' - - 'cmd/deps_spec.rb' - - 'cmd/desc_spec.rb' - - 'cmd/doctor_spec.rb' - - 'cmd/fetch_spec.rb' - - 'cmd/home_spec.rb' - - 'cmd/info_spec.rb' - - 'cmd/install_spec.rb' - - 'cmd/leaves_spec.rb' - - 'cmd/link_spec.rb' - - 'cmd/list_spec.rb' - - 'cmd/log_spec.rb' - - 'cmd/migrate_spec.rb' - - 'cmd/missing_spec.rb' - - 'cmd/options_spec.rb' - - 'cmd/outdated_spec.rb' - - 'cmd/pin_spec.rb' - - 'cmd/readall_spec.rb' - - 'cmd/reinstall_spec.rb' - - 'cmd/search_spec.rb' - - 'cmd/tap-info_spec.rb' - - 'cmd/tap_spec.rb' - - 'cmd/uninstall_spec.rb' - - 'cmd/unlink_spec.rb' - - 'cmd/unpin_spec.rb' - - 'cmd/untap_spec.rb' - - 'cmd/update-report_spec.rb' - - 'cmd/upgrade_spec.rb' - - 'cmd/uses_spec.rb' - - 'dependency_spec.rb' - - 'dev-cmd/bottle_spec.rb' - - 'dev-cmd/cat_spec.rb' - - 'dev-cmd/command_spec.rb' - - 'dev-cmd/create_spec.rb' - - 'dev-cmd/edit_spec.rb' - - 'dev-cmd/extract_spec.rb' - - 'dev-cmd/formula_spec.rb' - - 'dev-cmd/irb_spec.rb' - - 'dev-cmd/linkage_spec.rb' - - 'dev-cmd/livecheck_spec.rb' - - 'dev-cmd/ruby_spec.rb' - - 'dev-cmd/sh_spec.rb' - - 'dev-cmd/tap-new_spec.rb' - - 'dev-cmd/test_spec.rb' - - 'dev-cmd/unpack_spec.rb' - - 'download_strategies_spec.rb' - - 'exceptions_spec.rb' - - 'formula_support_spec.rb' - - 'language/python_spec.rb' - - 'options_spec.rb' - - 'os/mac/mach_spec.rb' - - 'patch_spec.rb' - - 'rubocops/checksum_spec.rb' - - 'rubocops/class_spec.rb' - - 'rubocops/deprecate_disable_spec.rb' - - 'rubocops/lines_spec.rb' - - 'rubocops/livecheck_spec.rb' - - 'rubocops/text_spec.rb' - - 'rubocops/urls_spec.rb' - - 'software_spec_spec.rb' - - 'tap_spec.rb' - - 'version_spec.rb' + - "ENV_spec.rb" + - "cleanup_spec.rb" + - "cmd/--cache_spec.rb" + - "cmd/--cellar_spec.rb" + - "cmd/--env_spec.rb" + - "cmd/--prefix_spec.rb" + - "cmd/--repository_spec.rb" + - "cmd/--version_spec.rb" + - "cmd/analytics_spec.rb" + - "cmd/cleanup_spec.rb" + - "cmd/commands_spec.rb" + - "cmd/config_spec.rb" + - "cmd/deps_spec.rb" + - "cmd/desc_spec.rb" + - "cmd/doctor_spec.rb" + - "cmd/fetch_spec.rb" + - "cmd/home_spec.rb" + - "cmd/info_spec.rb" + - "cmd/install_spec.rb" + - "cmd/leaves_spec.rb" + - "cmd/link_spec.rb" + - "cmd/list_spec.rb" + - "cmd/log_spec.rb" + - "cmd/migrate_spec.rb" + - "cmd/missing_spec.rb" + - "cmd/options_spec.rb" + - "cmd/outdated_spec.rb" + - "cmd/pin_spec.rb" + - "cmd/readall_spec.rb" + - "cmd/reinstall_spec.rb" + - "cmd/search_spec.rb" + - "cmd/tap-info_spec.rb" + - "cmd/tap_spec.rb" + - "cmd/uninstall_spec.rb" + - "cmd/unlink_spec.rb" + - "cmd/unpin_spec.rb" + - "cmd/untap_spec.rb" + - "cmd/update-report_spec.rb" + - "cmd/upgrade_spec.rb" + - "cmd/uses_spec.rb" + - "dependency_spec.rb" + - "dev-cmd/bottle_spec.rb" + - "dev-cmd/cat_spec.rb" + - "dev-cmd/command_spec.rb" + - "dev-cmd/create_spec.rb" + - "dev-cmd/edit_spec.rb" + - "dev-cmd/extract_spec.rb" + - "dev-cmd/formula_spec.rb" + - "dev-cmd/irb_spec.rb" + - "dev-cmd/linkage_spec.rb" + - "dev-cmd/livecheck_spec.rb" + - "dev-cmd/ruby_spec.rb" + - "dev-cmd/sh_spec.rb" + - "dev-cmd/tap-new_spec.rb" + - "dev-cmd/test_spec.rb" + - "dev-cmd/unpack_spec.rb" + - "download_strategies_spec.rb" + - "exceptions_spec.rb" + - "formula_support_spec.rb" + - "language/python_spec.rb" + - "options_spec.rb" + - "os/mac/mach_spec.rb" + - "patch_spec.rb" + - "rubocops/checksum_spec.rb" + - "rubocops/class_spec.rb" + - "rubocops/deprecate_disable_spec.rb" + - "rubocops/lines_spec.rb" + - "rubocops/livecheck_spec.rb" + - "rubocops/text_spec.rb" + - "rubocops/urls_spec.rb" + - "software_spec_spec.rb" + - "tap_spec.rb" + - "version_spec.rb" # Offense count: 665 # Configuration parameters: IgnoreSharedExamples. RSpec/NamedSubject: Exclude: - - 'ENV_spec.rb' - - 'build_environment_spec.rb' - - 'build_options_spec.rb' - - 'cache_store_spec.rb' - - 'cask/audit_spec.rb' - - 'cask/cmd/style_spec.rb' - - 'cask/cmd_spec.rb' - - 'cask/dsl/appcast_spec.rb' - - 'caveats_spec.rb' - - 'cleaner_spec.rb' - - 'cleanup_spec.rb' - - 'cmd/info_spec.rb' - - 'compiler_selector_spec.rb' - - 'dependable_spec.rb' - - 'dependencies_spec.rb' - - 'dependency_collector_spec.rb' - - 'dependency_spec.rb' - - 'descriptions_spec.rb' - - 'diagnostic_checks_spec.rb' - - 'download_strategies_spec.rb' - - 'error_during_execution_spec.rb' - - 'exceptions_spec.rb' - - 'formatter_spec.rb' - - 'formula_pin_spec.rb' - - 'language/node_spec.rb' - - 'language/python_spec.rb' - - 'linkage_cache_store_spec.rb' - - 'locale_spec.rb' - - 'lock_file_spec.rb' - - 'migrator_spec.rb' - - 'options_spec.rb' - - 'os/linux/dependency_collector_spec.rb' - - 'os/linux/diagnostic_spec.rb' - - 'os/mac/dependency_collector_spec.rb' - - 'os/mac/diagnostic_spec.rb' - - 'os/mac/keg_spec.rb' - - 'os/mac_spec.rb' - - 'patch_spec.rb' - - 'requirement_spec.rb' - - 'requirements_spec.rb' - - 'resource_spec.rb' - - 'sandbox_spec.rb' - - 'searchable_spec.rb' - - 'software_spec_spec.rb' - - 'system_command_result_spec.rb' - - 'tab_spec.rb' - - 'tap_spec.rb' - - 'utils_spec.rb' - - 'version_spec.rb' + - "ENV_spec.rb" + - "build_environment_spec.rb" + - "build_options_spec.rb" + - "cache_store_spec.rb" + - "cask/audit_spec.rb" + - "cask/cmd/style_spec.rb" + - "cask/cmd_spec.rb" + - "cask/dsl/appcast_spec.rb" + - "caveats_spec.rb" + - "cleaner_spec.rb" + - "cleanup_spec.rb" + - "cmd/info_spec.rb" + - "compiler_selector_spec.rb" + - "dependable_spec.rb" + - "dependencies_spec.rb" + - "dependency_collector_spec.rb" + - "dependency_spec.rb" + - "descriptions_spec.rb" + - "diagnostic_checks_spec.rb" + - "download_strategies_spec.rb" + - "error_during_execution_spec.rb" + - "exceptions_spec.rb" + - "formatter_spec.rb" + - "formula_pin_spec.rb" + - "language/node_spec.rb" + - "language/python_spec.rb" + - "linkage_cache_store_spec.rb" + - "locale_spec.rb" + - "lock_file_spec.rb" + - "migrator_spec.rb" + - "options_spec.rb" + - "os/linux/dependency_collector_spec.rb" + - "os/linux/diagnostic_spec.rb" + - "os/mac/dependency_collector_spec.rb" + - "os/mac/diagnostic_spec.rb" + - "os/mac/keg_spec.rb" + - "os/mac_spec.rb" + - "patch_spec.rb" + - "requirement_spec.rb" + - "requirements_spec.rb" + - "resource_spec.rb" + - "sandbox_spec.rb" + - "searchable_spec.rb" + - "software_spec_spec.rb" + - "system_command_result_spec.rb" + - "tab_spec.rb" + - "tap_spec.rb" + - "utils_spec.rb" + - "version_spec.rb" # Offense count: 64 # Configuration parameters: IgnoreNameless, IgnoreSymbolicNames. RSpec/VerifiedDoubles: Exclude: - - 'cache_store_spec.rb' - - 'cask/artifact/pkg_spec.rb' - - 'cask/cmd_spec.rb' - - 'cask/installer_spec.rb' - - 'cask/pkg_spec.rb' - - 'cmd/update-report_spec.rb' - - 'compiler_failure_spec.rb' - - 'compiler_selector_spec.rb' - - 'dependable_spec.rb' - - 'dependency_expansion_spec.rb' - - 'description_cache_store_spec.rb' - - 'exceptions_spec.rb' - - 'formula_pin_spec.rb' - - 'formula_spec.rb' - - 'language/python_spec.rb' - - 'linkage_cache_store_spec.rb' - - 'resource_spec.rb' - - 'software_spec_spec.rb' - - 'utils/analytics_spec.rb' - - 'version_spec.rb' + - "cache_store_spec.rb" + - "cask/artifact/pkg_spec.rb" + - "cask/cmd_spec.rb" + - "cask/installer_spec.rb" + - "cask/pkg_spec.rb" + - "cmd/update-report_spec.rb" + - "compiler_failure_spec.rb" + - "compiler_selector_spec.rb" + - "dependable_spec.rb" + - "dependency_expansion_spec.rb" + - "description_cache_store_spec.rb" + - "exceptions_spec.rb" + - "formula_pin_spec.rb" + - "formula_spec.rb" + - "language/python_spec.rb" + - "linkage_cache_store_spec.rb" + - "resource_spec.rb" + - "software_spec_spec.rb" + - "utils/analytics_spec.rb" + - "version_spec.rb"