From 6c3b8e100f0f3dc23fe6c77cfd049ba126e58e8c Mon Sep 17 00:00:00 2001 From: commitay Date: Sun, 9 Sep 2018 10:51:32 +1000 Subject: [PATCH 1/3] components_order_cop: add all components --- Library/Homebrew/rubocops/components_order_cop.rb | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Library/Homebrew/rubocops/components_order_cop.rb b/Library/Homebrew/rubocops/components_order_cop.rb index 385d368375..56e1b2351b 100644 --- a/Library/Homebrew/rubocops/components_order_cop.rb +++ b/Library/Homebrew/rubocops/components_order_cop.rb @@ -27,9 +27,14 @@ module RuboCop [{ name: :bottle, type: :method_call }], [{ name: :keg_only, type: :method_call }], [{ name: :option, type: :method_call }], + [{ name: :deprecated_option, type: :method_call }], [{ name: :depends_on, type: :method_call }], [{ name: :conflicts_with, type: :method_call }], + [{ name: :skip_clean, type: :method_call }], + [{ name: :fails_with, type: :method_call }, { name: :fails_with, type: :block_call }], [{ name: :go_resource, type: :block_call }, { name: :resource, type: :block_call }], + [{ name: :patch, type: :method_call }, { name: :patch, type: :block_call }], + [{ name: :needs, type: :method_call }], [{ name: :install, type: :method_definition }], [{ name: :post_install, type: :method_definition }], [{ name: :caveats, type: :method_definition }], From a1264f5adad20be663ca28ab3ef11c5be54694aa Mon Sep 17 00:00:00 2001 From: commitay Date: Mon, 10 Sep 2018 08:01:12 +1000 Subject: [PATCH 2/3] components_order_cop: add more components --- Library/Homebrew/rubocops/components_order_cop.rb | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Library/Homebrew/rubocops/components_order_cop.rb b/Library/Homebrew/rubocops/components_order_cop.rb index 56e1b2351b..67571d5c1f 100644 --- a/Library/Homebrew/rubocops/components_order_cop.rb +++ b/Library/Homebrew/rubocops/components_order_cop.rb @@ -22,6 +22,7 @@ module RuboCop [{ name: :head, type: :method_call }], [{ name: :stable, type: :block_call }], [{ name: :bottle, type: :block_call }], + [{ name: :pour_bottle?, type: :block_call }], [{ name: :devel, type: :block_call }], [{ name: :head, type: :block_call }], [{ name: :bottle, type: :method_call }], @@ -31,6 +32,7 @@ module RuboCop [{ name: :depends_on, type: :method_call }], [{ name: :conflicts_with, type: :method_call }], [{ name: :skip_clean, type: :method_call }], + [{ name: :cxxstdlib_check, type: :method_call }], [{ name: :fails_with, type: :method_call }, { name: :fails_with, type: :block_call }], [{ name: :go_resource, type: :block_call }, { name: :resource, type: :block_call }], [{ name: :patch, type: :method_call }, { name: :patch, type: :block_call }], From b46852da4c87256a4114b7bb0e28e0a102e622f3 Mon Sep 17 00:00:00 2001 From: commitay Date: Tue, 11 Sep 2018 22:05:45 +1000 Subject: [PATCH 3/3] components_order_cop: add more components --- Library/Homebrew/rubocops/components_order_cop.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/Library/Homebrew/rubocops/components_order_cop.rb b/Library/Homebrew/rubocops/components_order_cop.rb index 67571d5c1f..3b6fdd27b6 100644 --- a/Library/Homebrew/rubocops/components_order_cop.rb +++ b/Library/Homebrew/rubocops/components_order_cop.rb @@ -33,6 +33,7 @@ module RuboCop [{ name: :conflicts_with, type: :method_call }], [{ name: :skip_clean, type: :method_call }], [{ name: :cxxstdlib_check, type: :method_call }], + [{ name: :link_overwrite, type: :method_call }], [{ name: :fails_with, type: :method_call }, { name: :fails_with, type: :block_call }], [{ name: :go_resource, type: :block_call }, { name: :resource, type: :block_call }], [{ name: :patch, type: :method_call }, { name: :patch, type: :block_call }],