diff --git a/Library/Homebrew/rubocops/text.rb b/Library/Homebrew/rubocops/text.rb index e1c1461da0..9ef5b63fec 100644 --- a/Library/Homebrew/rubocops/text.rb +++ b/Library/Homebrew/rubocops/text.rb @@ -48,6 +48,10 @@ module RuboCop problem "\"Formula.factory(name)\" is deprecated in favor of \"Formula[name]\"" end + find_method_with_args(body_node, :revision, 0) do + problem "\"revision 0\" is unnecessary" + end + find_method_with_args(body_node, :system, "xcodebuild") do problem %q(use "xcodebuild *args" instead of "system 'xcodebuild', *args") end diff --git a/Library/Homebrew/test/rubocops/text_spec.rb b/Library/Homebrew/test/rubocops/text_spec.rb index 29074d087a..de9fb25724 100644 --- a/Library/Homebrew/test/rubocops/text_spec.rb +++ b/Library/Homebrew/test/rubocops/text_spec.rb @@ -24,6 +24,17 @@ describe RuboCop::Cop::FormulaAudit::Text do RUBY end + it "reports an offense if 'revision 0' is present" do + expect_offense(<<~RUBY) + class Foo < Formula + url "https://brew.sh/foo-1.0.tgz" + homepage "https://brew.sh" + revision 0 + ^^^^^^^^^^ FormulaAudit/Text: "revision 0" is unnecessary + end + RUBY + end + it "reports an offense if both openssl and libressl are dependencies" do expect_offense(<<~RUBY) class Foo < Formula