admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Port Homebrew::Cmd::InstallCmd

Browse Source
This commit is contained in:
Douglas Eichelberger 2024-03-30 09:36:47 -07:00
parent d25956668d
commit 0fd082a1ff
4 changed files with 386 additions and 382 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Library/Homebrew/build.rb
View File

@ -217,7 +217,7 @@ class Build
end end
begin begin
args = Homebrew.install_args.parse args = Homebrew::Cmd::InstallCmd.new.args
Context.current = args.context Context.current = args.context
error_pipe = UNIXSocket.open(ENV.fetch("HOMEBREW_ERROR_PIPE"), &:recv_io) error_pipe = UNIXSocket.open(ENV.fetch("HOMEBREW_ERROR_PIPE"), &:recv_io)

759
Library/Homebrew/cmd/install.rb
View File

@ -1,6 +1,7 @@
# typed: true # typed: strict
# frozen_string_literal: true # frozen_string_literal: true
require "abstract_command"
require "cask/config" require "cask/config"
require "cask/installer" require "cask/installer"
require "cask_dependent" require "cask_dependent"
@ -9,400 +10,402 @@ require "formula_installer"
require "development_tools" require "development_tools"
require "install" require "install"
require "cleanup" require "cleanup"
require "cli/parser"
require "upgrade" require "upgrade"
module Homebrew module Homebrew
sig { returns(CLI::Parser) } module Cmd
def self.install_args class InstallCmd < AbstractCommand
Homebrew::CLI::Parser.new do cmd_args do
description <<~EOS description <<~EOS
Install a <formula> or <cask>. Additional options specific to a <formula> may be Install a <formula> or <cask>. Additional options specific to a <formula> may be
appended to the command. appended to the command.
Unless `HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK` is set, `brew upgrade` or `brew reinstall` will be run for Unless `HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK` is set, `brew upgrade` or `brew reinstall` will be run for
outdated dependents and dependents with broken linkage, respectively. outdated dependents and dependents with broken linkage, respectively.
Unless `HOMEBREW_NO_INSTALL_CLEANUP` is set, `brew cleanup` will then be run for Unless `HOMEBREW_NO_INSTALL_CLEANUP` is set, `brew cleanup` will then be run for
the installed formulae or, every 30 days, for all formulae. the installed formulae or, every 30 days, for all formulae.
Unless `HOMEBREW_NO_INSTALL_UPGRADE` is set, `brew install` <formula> will upgrade <formula> if it Unless `HOMEBREW_NO_INSTALL_UPGRADE` is set, `brew install` <formula> will upgrade <formula> if it
is already installed but outdated. is already installed but outdated.
EOS EOS
switch "-d", "--debug", switch "-d", "--debug",
description: "If brewing fails, open an interactive debugging session with access to IRB " \ description: "If brewing fails, open an interactive debugging session with access to IRB " \
"or a shell inside the temporary build directory." "or a shell inside the temporary build directory."
switch "-f", "--force", switch "-f", "--force",
description: "Install formulae without checking for previously installed keg-only or " \ description: "Install formulae without checking for previously installed keg-only or " \
"non-migrated versions. When installing casks, overwrite existing files " \ "non-migrated versions. When installing casks, overwrite existing files " \
"(binaries and symlinks are excluded, unless originally from the same cask)." "(binaries and symlinks are excluded, unless originally from the same cask)."
switch "-v", "--verbose", switch "-v", "--verbose",
description: "Print the verification and post-install steps." description: "Print the verification and post-install steps."
switch "-n", "--dry-run", switch "-n", "--dry-run",
description: "Show what would be installed, but do not actually install anything." description: "Show what would be installed, but do not actually install anything."
[ [
[:switch, "--formula", "--formulae", { [:switch, "--formula", "--formulae", {
description: "Treat all named arguments as formulae.", description: "Treat all named arguments as formulae.",
}], }],
[:flag, "--env=", { [:flag, "--env=", {
description: "Disabled other than for internal Homebrew use.", description: "Disabled other than for internal Homebrew use.",
hidden: true, hidden: true,
}], }],
[:switch, "--ignore-dependencies", { [:switch, "--ignore-dependencies", {
description: "An unsupported Homebrew development option to skip installing any dependencies of any " \ description: "An unsupported Homebrew development option to skip installing any dependencies of any " \
"kind. If the dependencies are not already present, the formula will have issues. If you're " \ "kind. If the dependencies are not already present, the formula will have issues. If " \
"not developing Homebrew, consider adjusting your PATH rather than using this option.", "you're not developing Homebrew, consider adjusting your PATH rather than using this " \
}], "option.",
[:switch, "--only-dependencies", { }],
description: "Install the dependencies with specified options but do not install the " \ [:switch, "--only-dependencies", {
"formula itself.", description: "Install the dependencies with specified options but do not install the " \
}], "formula itself.",
[:flag, "--cc=", { }],
description: "Attempt to compile using the specified <compiler>, which should be the name of the " \ [:flag, "--cc=", {
"compiler's executable, e.g. `gcc-7` for GCC 7. In order to use LLVM's clang, specify " \ description: "Attempt to compile using the specified <compiler>, which should be the name of the " \
"`llvm_clang`. To use the Apple-provided clang, specify `clang`. This option will only " \ "compiler's executable, e.g. `gcc-7` for GCC 7. In order to use LLVM's clang, specify " \
"accept compilers that are provided by Homebrew or bundled with macOS. Please do not " \ "`llvm_clang`. To use the Apple-provided clang, specify `clang`. This option will only " \
"file issues if you encounter errors while using this option.", "accept compilers that are provided by Homebrew or bundled with macOS. Please do not " \
}], "file issues if you encounter errors while using this option.",
[:switch, "-s", "--build-from-source", { }],
description: "Compile <formula> from source even if a bottle is provided. " \ [:switch, "-s", "--build-from-source", {
"Dependencies will still be installed from bottles if they are available.", description: "Compile <formula> from source even if a bottle is provided. " \
}], "Dependencies will still be installed from bottles if they are available.",
[:switch, "--force-bottle", { }],
description: "Install from a bottle if it exists for the current or newest version of " \ [:switch, "--force-bottle", {
"macOS, even if it would not normally be used for installation.", description: "Install from a bottle if it exists for the current or newest version of " \
}], "macOS, even if it would not normally be used for installation.",
[:switch, "--include-test", { }],
description: "Install testing dependencies required to run `brew test` <formula>.", [:switch, "--include-test", {
}], description: "Install testing dependencies required to run `brew test` <formula>.",
[:switch, "--HEAD", { }],
description: "If <formula> defines it, install the HEAD version, aka. main, trunk, unstable, master.", [:switch, "--HEAD", {
}], description: "If <formula> defines it, install the HEAD version, aka. main, trunk, unstable, master.",
[:switch, "--fetch-HEAD", { }],
description: "Fetch the upstream repository to detect if the HEAD installation of the " \ [:switch, "--fetch-HEAD", {
"formula is outdated. Otherwise, the repository's HEAD will only be checked for " \ description: "Fetch the upstream repository to detect if the HEAD installation of the " \
"updates when a new stable or development version has been released.", "formula is outdated. Otherwise, the repository's HEAD will only be checked for " \
}], "updates when a new stable or development version has been released.",
[:switch, "--keep-tmp", { }],
description: "Retain the temporary files created during installation.", [:switch, "--keep-tmp", {
}], description: "Retain the temporary files created during installation.",
[:switch, "--debug-symbols", { }],
depends_on: "--build-from-source", [:switch, "--debug-symbols", {
description: "Generate debug symbols on build. Source will be retained in a cache directory.", depends_on: "--build-from-source",
}], description: "Generate debug symbols on build. Source will be retained in a cache directory.",
[:switch, "--build-bottle", { }],
description: "Prepare the formula for eventual bottling during installation, skipping any " \ [:switch, "--build-bottle", {
"post-install steps.", description: "Prepare the formula for eventual bottling during installation, skipping any " \
}], "post-install steps.",
[:switch, "--skip-post-install", { }],
description: "Install but skip any post-install steps.", [:switch, "--skip-post-install", {
}], description: "Install but skip any post-install steps.",
[:flag, "--bottle-arch=", { }],
depends_on: "--build-bottle", [:flag, "--bottle-arch=", {
description: "Optimise bottles for the specified architecture rather than the oldest " \ depends_on: "--build-bottle",
"architecture supported by the version of macOS the bottles are built on.", description: "Optimise bottles for the specified architecture rather than the oldest " \
}], "architecture supported by the version of macOS the bottles are built on.",
[:switch, "--display-times", { }],
env: :display_install_times, [:switch, "--display-times", {
description: "Print install times for each package at the end of the run.", env: :display_install_times,
}], description: "Print install times for each package at the end of the run.",
[:switch, "-i", "--interactive", { }],
description: "Download and patch <formula>, then open a shell. This allows the user to " \ [:switch, "-i", "--interactive", {
"run `./configure --help` and otherwise determine how to turn the software " \ description: "Download and patch <formula>, then open a shell. This allows the user to " \
"package into a Homebrew package.", "run `./configure --help` and otherwise determine how to turn the software " \
}], "package into a Homebrew package.",
[:switch, "-g", "--git", { }],
description: "Create a Git repository, useful for creating patches to the software.", [:switch, "-g", "--git", {
}], description: "Create a Git repository, useful for creating patches to the software.",
[:switch, "--overwrite", { }],
description: "Delete files that already exist in the prefix while linking.", [:switch, "--overwrite", {
}], description: "Delete files that already exist in the prefix while linking.",
].each do |args| }],
options = args.pop ].each do |args|
send(*args, **options) options = args.pop
conflicts "--cask", args.last send(*args, **options)
end conflicts "--cask", args.last
formula_options
[
[:switch, "--cask", "--casks", { description: "Treat all named arguments as casks." }],
[:switch, "--[no-]binaries", {
description: "Disable/enable linking of helper executables (default: enabled).",
env: :cask_opts_binaries,
}],
[:switch, "--require-sha", {
description: "Require all casks to have a checksum.",
env: :cask_opts_require_sha,
}],
[:switch, "--[no-]quarantine", {
description: "Disable/enable quarantining of downloads (default: enabled).",
env: :cask_opts_quarantine,
}],
[:switch, "--adopt", {
description: "Adopt existing artifacts in the destination that are identical to those being installed. " \
"Cannot be combined with `--force`.",
}],
[:switch, "--skip-cask-deps", {
description: "Skip installing cask dependencies.",
}],
[:switch, "--zap", {
description: "For use with `brew reinstall --cask`. Remove all files associated with a cask. " \
"*May remove files which are shared between applications.*",
}],
].each do |args|
options = args.pop
send(*args, **options)
conflicts "--formula", args.last
end
cask_options
conflicts "--ignore-dependencies", "--only-dependencies"
conflicts "--build-from-source", "--build-bottle", "--force-bottle"
conflicts "--adopt", "--force"
named_args [:formula, :cask], min: 1
end
end
def self.install
args = install_args.parse
if args.env.present?
# Can't use `replacement: false` because `install_args` are used by
# `build.rb`. Instead, `hide_from_man_page` and don't do anything with
# this argument here.
# This odisabled should stick around indefinitely.
odisabled "brew install --env", "`env :std` in specific formula files"
end
args.named.each do |name|
if (tap_with_name = Tap.with_formula_name(name))
tap, = tap_with_name
elsif (tap_with_token = Tap.with_cask_token(name))
tap, = tap_with_token
end
tap&.ensure_installed!
end
if args.ignore_dependencies?
opoo <<~EOS
#{Tty.bold}`--ignore-dependencies` is an unsupported Homebrew developer option!#{Tty.reset}
Adjust your PATH to put any preferred versions of applications earlier in the
PATH rather than using this unsupported option!
EOS
end
begin
formulae, casks = args.named.to_formulae_and_casks(warn: false)
.partition { |formula_or_cask| formula_or_cask.is_a?(Formula) }
rescue FormulaOrCaskUnavailableError, Cask::CaskUnavailableError
cask_tap = CoreCaskTap.instance
if !cask_tap.installed? && (args.cask? || Tap.untapped_official_taps.exclude?(cask_tap.name))
cask_tap.ensure_installed!
retry if cask_tap.installed?
end
raise
end
if casks.any?
if args.dry_run?
if (casks_to_install = casks.reject(&:installed?).presence)
ohai "Would install #{::Utils.pluralize("cask", casks_to_install.count, include_count: true)}:"
puts casks_to_install.map(&:full_name).join(" ")
end end
casks.each do |cask| formula_options
dep_names = CaskDependent.new(cask) [
.runtime_dependencies [:switch, "--cask", "--casks", { description: "Treat all named arguments as casks." }],
.reject(&:installed?) [:switch, "--[no-]binaries", {
.map(&:to_formula) description: "Disable/enable linking of helper executables (default: enabled).",
.map(&:name) env: :cask_opts_binaries,
next if dep_names.blank? }],
[:switch, "--require-sha", {
description: "Require all casks to have a checksum.",
env: :cask_opts_require_sha,
}],
[:switch, "--[no-]quarantine", {
description: "Disable/enable quarantining of downloads (default: enabled).",
env: :cask_opts_quarantine,
}],
[:switch, "--adopt", {
description: "Adopt existing artifacts in the destination that are identical to those being installed. " \
"Cannot be combined with `--force`.",
}],
[:switch, "--skip-cask-deps", {
description: "Skip installing cask dependencies.",
}],
[:switch, "--zap", {
description: "For use with `brew reinstall --cask`. Remove all files associated with a cask. " \
"*May remove files which are shared between applications.*",
}],
].each do |args|
options = args.pop
send(*args, **options)
conflicts "--formula", args.last
end
cask_options
ohai "Would install #{::Utils.pluralize("dependenc", dep_names.count, plural: "ies", singular: "y", conflicts "--ignore-dependencies", "--only-dependencies"
conflicts "--build-from-source", "--build-bottle", "--force-bottle"
conflicts "--adopt", "--force"
named_args [:formula, :cask], min: 1
end
sig { override.void }
def run
if args.env.present?
# Can't use `replacement: false` because `install_args` are used by
# `build.rb`. Instead, `hide_from_man_page` and don't do anything with
# this argument here.
# This odisabled should stick around indefinitely.
odisabled "brew install --env", "`env :std` in specific formula files"
end
args.named.each do |name|
if (tap_with_name = Tap.with_formula_name(name))
tap, = tap_with_name
elsif (tap_with_token = Tap.with_cask_token(name))
tap, = tap_with_token
end
tap&.ensure_installed!
end
if args.ignore_dependencies?
opoo <<~EOS
#{Tty.bold}`--ignore-dependencies` is an unsupported Homebrew developer option!#{Tty.reset}
Adjust your PATH to put any preferred versions of applications earlier in the
PATH rather than using this unsupported option!
EOS
end
begin
formulae, casks = T.cast(
args.named.to_formulae_and_casks(warn: false).partition { _1.is_a?(Formula) },
[T::Array[Formula], T::Array[Cask::Cask]],
)
rescue FormulaOrCaskUnavailableError, Cask::CaskUnavailableError
cask_tap = CoreCaskTap.instance
if !cask_tap.installed? && (args.cask? || Tap.untapped_official_taps.exclude?(cask_tap.name))
cask_tap.ensure_installed!
retry if cask_tap.installed?
end
raise
end
if casks.any?
if args.dry_run?
if (casks_to_install = casks.reject(&:installed?).presence)
ohai "Would install #{::Utils.pluralize("cask", casks_to_install.count, include_count: true)}:"
puts casks_to_install.map(&:full_name).join(" ")
end
casks.each do |cask|
dep_names = CaskDependent.new(cask)
.runtime_dependencies
.reject(&:installed?)
.map(&:to_formula)
.map(&:name)
next if dep_names.blank?
ohai "Would install #{::Utils.pluralize("dependenc", dep_names.count, plural: "ies", singular: "y",
include_count: true)} for #{cask.full_name}:" include_count: true)} for #{cask.full_name}:"
puts dep_names.join(" ") puts dep_names.join(" ")
end
return
end
require "cask/installer"
installed_casks, new_casks = casks.partition(&:installed?)
new_casks.each do |cask|
Cask::Installer.new(
cask,
binaries: args.binaries?,
verbose: args.verbose?,
force: args.force?,
adopt: args.adopt?,
require_sha: args.require_sha?,
skip_cask_deps: args.skip_cask_deps?,
quarantine: args.quarantine?,
quiet: args.quiet?,
).install
end
if !Homebrew::EnvConfig.no_install_upgrade? && installed_casks.any?
require "cask/upgrade"
Cask::Upgrade.upgrade_casks(
*installed_casks,
force: args.force?,
dry_run: args.dry_run?,
binaries: args.binaries?,
quarantine: args.quarantine?,
require_sha: args.require_sha?,
skip_cask_deps: args.skip_cask_deps?,
verbose: args.verbose?,
args:,
)
end
end end
return
end
require "cask/installer" # if the user's flags will prevent bottle only-installations when no
# developer tools are available, we need to stop them early on
build_flags = []
unless DevelopmentTools.installed?
build_flags << "--HEAD" if args.HEAD?
build_flags << "--build-bottle" if args.build_bottle?
build_flags << "--build-from-source" if args.build_from_source?
installed_casks, new_casks = casks.partition(&:installed?) raise BuildFlagsError.new(build_flags, bottled: formulae.all?(&:bottled?)) if build_flags.present?
end
new_casks.each do |cask| if build_flags.present? && !Homebrew::EnvConfig.developer?
Cask::Installer.new( opoo "building from source is not supported!"
cask, puts "You're on your own. Failures are expected so don't create any issues, please!"
binaries: args.binaries?, end
verbose: args.verbose?,
force: args.force?,
adopt: args.adopt?,
require_sha: args.require_sha?,
skip_cask_deps: args.skip_cask_deps?,
quarantine: args.quarantine?,
quiet: args.quiet?,
).install
end
if !Homebrew::EnvConfig.no_install_upgrade? && installed_casks.any? installed_formulae = formulae.select do |f|
require "cask/upgrade" Install.install_formula?(
f,
head: args.HEAD?,
fetch_head: args.fetch_HEAD?,
only_dependencies: args.only_dependencies?,
force: args.force?,
quiet: args.quiet?,
)
end
Cask::Upgrade.upgrade_casks( return if installed_formulae.empty?
*installed_casks,
force: args.force?, Install.perform_preinstall_checks(cc: args.cc)
dry_run: args.dry_run?,
binaries: args.binaries?, Install.install_formulae(
quarantine: args.quarantine?, installed_formulae,
require_sha: args.require_sha?, build_bottle: args.build_bottle?,
skip_cask_deps: args.skip_cask_deps?, force_bottle: args.force_bottle?,
verbose: args.verbose?, bottle_arch: args.bottle_arch,
args:, ignore_deps: args.ignore_dependencies?,
only_deps: args.only_dependencies?,
include_test_formulae: args.include_test_formulae,
build_from_source_formulae: args.build_from_source_formulae,
cc: args.cc,
git: args.git?,
interactive: args.interactive?,
keep_tmp: args.keep_tmp?,
debug_symbols: args.debug_symbols?,
force: args.force?,
overwrite: args.overwrite?,
debug: args.debug?,
quiet: args.quiet?,
verbose: args.verbose?,
dry_run: args.dry_run?,
skip_post_install: args.skip_post_install?,
) )
Upgrade.check_installed_dependents(
installed_formulae,
flags: args.flags_only,
installed_on_request: args.named.present?,
force_bottle: args.force_bottle?,
build_from_source_formulae: args.build_from_source_formulae,
interactive: args.interactive?,
keep_tmp: args.keep_tmp?,
debug_symbols: args.debug_symbols?,
force: args.force?,
debug: args.debug?,
quiet: args.quiet?,
verbose: args.verbose?,
dry_run: args.dry_run?,
)
Cleanup.periodic_clean!(dry_run: args.dry_run?)
Homebrew.messages.display_messages(display_times: args.display_times?)
rescue FormulaUnreadableError, FormulaClassUnavailableError,
TapFormulaUnreadableError, TapFormulaClassUnavailableError => e
# Need to rescue before `FormulaUnavailableError` (superclass of this)
# is handled, as searching for a formula doesn't make sense here (the
# formula was found, but there's a problem with its implementation).
$stderr.puts Utils::Backtrace.clean(e) if Homebrew::EnvConfig.developer?
ofail e.message
rescue FormulaOrCaskUnavailableError, Cask::CaskUnavailableError => e
Homebrew.failed = true
# formula name or cask token
name = case e
when FormulaOrCaskUnavailableError then e.name
when Cask::CaskUnavailableError then e.token
else T.absurd(e)
end
if name == "updog"
ofail "What's updog?"
return
end
opoo e
reason = MissingFormula.reason(name, silent: true)
if !args.cask? && reason
$stderr.puts reason
return
end
# We don't seem to get good search results when the tap is specified
# so we might as well return early.
return if name.include?("/")
require "search"
package_types = []
package_types << "formulae" unless args.cask?
package_types << "casks" unless args.formula?
ohai "Searching for similarly named #{package_types.join(" and ")}..."
# Don't treat formula/cask name as a regex
string_or_regex = name
all_formulae, all_casks = Search.search_names(string_or_regex, args)
if all_formulae.any?
ohai "Formulae", Formatter.columns(all_formulae)
first_formula = all_formulae.first.to_s
puts <<~EOS
To install #{first_formula}, run:
brew install #{first_formula}
EOS
end
puts if all_formulae.any? && all_casks.any?
if all_casks.any?
ohai "Casks", Formatter.columns(all_casks)
first_cask = all_casks.first.to_s
puts <<~EOS
To install #{first_cask}, run:
brew install --cask #{first_cask}
EOS
end
return if all_formulae.any? || all_casks.any?
odie "No #{package_types.join(" or ")} found for #{name}."
end end
end end
# if the user's flags will prevent bottle only-installations when no
# developer tools are available, we need to stop them early on
build_flags = []
unless DevelopmentTools.installed?
build_flags << "--HEAD" if args.HEAD?
build_flags << "--build-bottle" if args.build_bottle?
build_flags << "--build-from-source" if args.build_from_source?
raise BuildFlagsError.new(build_flags, bottled: formulae.all?(&:bottled?)) if build_flags.present?
end
if build_flags.present? && !Homebrew::EnvConfig.developer?
opoo "building from source is not supported!"
puts "You're on your own. Failures are expected so don't create any issues, please!"
end
installed_formulae = formulae.select do |f|
Install.install_formula?(
f,
head: args.HEAD?,
fetch_head: args.fetch_HEAD?,
only_dependencies: args.only_dependencies?,
force: args.force?,
quiet: args.quiet?,
)
end
return if installed_formulae.empty?
Install.perform_preinstall_checks(cc: args.cc)
Install.install_formulae(
installed_formulae,
build_bottle: args.build_bottle?,
force_bottle: args.force_bottle?,
bottle_arch: args.bottle_arch,
ignore_deps: args.ignore_dependencies?,
only_deps: args.only_dependencies?,
include_test_formulae: args.include_test_formulae,
build_from_source_formulae: args.build_from_source_formulae,
cc: args.cc,
git: args.git?,
interactive: args.interactive?,
keep_tmp: args.keep_tmp?,
debug_symbols: args.debug_symbols?,
force: args.force?,
overwrite: args.overwrite?,
debug: args.debug?,
quiet: args.quiet?,
verbose: args.verbose?,
dry_run: args.dry_run?,
skip_post_install: args.skip_post_install?,
)
Upgrade.check_installed_dependents(
installed_formulae,
flags: args.flags_only,
installed_on_request: args.named.present?,
force_bottle: args.force_bottle?,
build_from_source_formulae: args.build_from_source_formulae,
interactive: args.interactive?,
keep_tmp: args.keep_tmp?,
debug_symbols: args.debug_symbols?,
force: args.force?,
debug: args.debug?,
quiet: args.quiet?,
verbose: args.verbose?,
dry_run: args.dry_run?,
)
Cleanup.periodic_clean!(dry_run: args.dry_run?)
Homebrew.messages.display_messages(display_times: args.display_times?)
rescue FormulaUnreadableError, FormulaClassUnavailableError,
TapFormulaUnreadableError, TapFormulaClassUnavailableError => e
# Need to rescue before `FormulaUnavailableError` (superclass of this)
# is handled, as searching for a formula doesn't make sense here (the
# formula was found, but there's a problem with its implementation).
$stderr.puts Utils::Backtrace.clean(e) if Homebrew::EnvConfig.developer?
ofail e.message
rescue FormulaOrCaskUnavailableError, Cask::CaskUnavailableError => e
Homebrew.failed = true
# formula name or cask token
name = case e
when FormulaOrCaskUnavailableError then e.name
when Cask::CaskUnavailableError then e.token
else T.absurd(e)
end
if name == "updog"
ofail "What's updog?"
return
end
opoo e
reason = MissingFormula.reason(name, silent: true)
if !args.cask? && reason
$stderr.puts reason
return
end
# We don't seem to get good search results when the tap is specified
# so we might as well return early.
return if name.include?("/")
require "search"
package_types = []
package_types << "formulae" unless args.cask?
package_types << "casks" unless args.formula?
ohai "Searching for similarly named #{package_types.join(" and ")}..."
# Don't treat formula/cask name as a regex
string_or_regex = name
all_formulae, all_casks = Search.search_names(string_or_regex, args)
if all_formulae.any?
ohai "Formulae", Formatter.columns(all_formulae)
first_formula = all_formulae.first.to_s
puts <<~EOS
To install #{first_formula}, run:
brew install #{first_formula}
EOS
end
puts if all_formulae.any? && all_casks.any?
if all_casks.any?
ohai "Casks", Formatter.columns(all_casks)
first_cask = all_casks.first.to_s
puts <<~EOS
To install #{first_cask}, run:
brew install --cask #{first_cask}
EOS
end
return if all_formulae.any? || all_casks.any?
odie "No #{package_types.join(" or ")} found for #{name}."
end end
end end

3
Library/Homebrew/test/cmd/install_spec.rb
View File

@ -1,8 +1,9 @@
# frozen_string_literal: true # frozen_string_literal: true
require "cmd/install"
require "cmd/shared_examples/args_parse" require "cmd/shared_examples/args_parse"
RSpec.describe "brew install" do RSpec.describe Homebrew::Cmd::InstallCmd do
it_behaves_like "parseable arguments" it_behaves_like "parseable arguments"
it "installs formulae", :integration_test do it "installs formulae", :integration_test do

4
Library/Homebrew/test/formula_installer_bottle_spec.rb
View File

@ -70,7 +70,7 @@ RSpec.describe FormulaInstaller do
# rubocop:disable RSpec/NoExpectationExample # rubocop:disable RSpec/NoExpectationExample
specify "basic bottle install" do specify "basic bottle install" do
allow(DevelopmentTools).to receive(:installed?).and_return(false) allow(DevelopmentTools).to receive(:installed?).and_return(false)
Homebrew.install_args.parse(["testball_bottle"]) Homebrew::Cmd::InstallCmd.new(["testball_bottle"])
temporarily_install_bottle(TestballBottle.new) do |f| temporarily_install_bottle(TestballBottle.new) do |f|
test_basic_formula_setup(f) test_basic_formula_setup(f)
end end
@ -79,7 +79,7 @@ RSpec.describe FormulaInstaller do
specify "basic bottle install with cellar information on sha256 line" do specify "basic bottle install with cellar information on sha256 line" do
allow(DevelopmentTools).to receive(:installed?).and_return(false) allow(DevelopmentTools).to receive(:installed?).and_return(false)
Homebrew.install_args.parse(["testball_bottle_cellar"]) Homebrew::Cmd::InstallCmd.new(["testball_bottle_cellar"])
temporarily_install_bottle(TestballBottleCellar.new) do |f| temporarily_install_bottle(TestballBottleCellar.new) do |f|
test_basic_formula_setup(f) test_basic_formula_setup(f)