admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

*_test: use assert_nil when appropriate.

Browse Source 
This is warned by the newer MiniTest.
This commit is contained in:
Mike McQuaid 2017-01-26 12:02:17 +00:00
parent 92b48ac42e
commit 0fc4a52c6c
2 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Library/Homebrew/test/shell_test.rb
View File

@ -14,9 +14,9 @@ class ShellSmokeTest < Homebrew::TestCase
end end
def test_path_to_shell_failure def test_path_to_shell_failure
assert_equal nil, Utils::Shell.path_to_shell("") assert_nil Utils::Shell.path_to_shell("")
assert_equal nil, Utils::Shell.path_to_shell("@@@@@@") assert_nil Utils::Shell.path_to_shell("@@@@@@")
assert_equal nil, Utils::Shell.path_to_shell("invalid_shell-4.2") assert_nil Utils::Shell.path_to_shell("invalid_shell-4.2")
end end
def test_sh_quote def test_sh_quote

9
Library/Homebrew/test/tab_test.rb
View File

@ -241,15 +241,18 @@ class TabTests < Homebrew::TestCase
assert_equal @tab.changed_files, tab.changed_files assert_equal @tab.changed_files, tab.changed_files
assert_equal @tab.tap, tab.tap assert_equal @tab.tap, tab.tap
assert_equal @tab.spec, tab.spec assert_equal @tab.spec, tab.spec
assert_equal @tab.time, tab.time assert_nil @tab.time
assert_nil tab.time
assert_equal @tab.HEAD, tab.HEAD assert_equal @tab.HEAD, tab.HEAD
assert_equal @tab.compiler, tab.compiler assert_equal @tab.compiler, tab.compiler
assert_equal @tab.stdlib, tab.stdlib assert_equal @tab.stdlib, tab.stdlib
assert_equal @tab.runtime_dependencies, tab.runtime_dependencies assert_nil @tab.runtime_dependencies
assert_nil tab.runtime_dependencies
assert_equal @tab.stable_version, tab.stable_version assert_equal @tab.stable_version, tab.stable_version
assert_equal @tab.devel_version, tab.devel_version assert_equal @tab.devel_version, tab.devel_version
assert_equal @tab.head_version, tab.head_version assert_equal @tab.head_version, tab.head_version
assert_equal @tab.source["path"], tab.source["path"] assert_nil @tab.source["path"]
assert_nil tab.source["path"]
end end
def test_remap_deprecated_options def test_remap_deprecated_options