admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Add an exception for imagemagick in build-time dep audit

Browse Source
This commit is contained in:
Jack Nagel 2013-06-27 21:11:16 -05:00
parent db38053840
commit 0f2c5f33a2
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
Library/Homebrew/cmd/audit.rb
View File

@ -145,10 +145,14 @@ class FormulaAuditor
case dep.name case dep.name
when *BUILD_TIME_DEPS when *BUILD_TIME_DEPS
# Build deps should be tagged # TODO: this should really be only dep.build? but maybe some formula
problem <<-EOS.undent unless dep.tags.any? || f.name =~ /automake/ && dep.name == 'autoconf' # depends on the current behavior to be audit-clean?
#{dep} dependency should be "depends_on '#{dep}' => :build" next if dep.tags.any?
EOS next if f.name =~ /automake/ && dep.name == 'autoconf'
# This is actually a libltdl dep that gets converted to a non-build time
# libtool dep, but I don't of a good way to encode this in the dep object
next if f.name == 'imagemagick' && dep.name == 'libtool'
problem %{#{dep} dependency should be "depends_on '#{dep}' => :build"}
when "git", "ruby", "emacs", "mercurial" when "git", "ruby", "emacs", "mercurial"
problem <<-EOS.undent problem <<-EOS.undent
Don't use #{dep} as a dependency. We allow non-Homebrew Don't use #{dep} as a dependency. We allow non-Homebrew