admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

formula_auditor: don't allow bottle :unneeded in core.

Browse Source 
Now we have `all:` bottles and Bintray is going away for `mirror`s:
let's bottle everything in Homebrew/homebrew-core.
This commit is contained in:
Mike McQuaid 2021-06-28 12:54:12 +01:00
parent 04532cb621
commit 0eb9b62c2d
No known key found for this signature in database
GPG Key ID: 3338A31AFDB1D829
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
Library/Homebrew/formula_auditor.rb
View File

@ -438,14 +438,17 @@ module Homebrew
def audit_bottle_disabled def audit_bottle_disabled
return unless formula.bottle_disabled? return unless formula.bottle_disabled?
return if formula.bottle_unneeded?
problem "Unrecognized bottle modifier" unless formula.bottle_disable_reason.valid?
return unless @core_tap
if !formula.bottle_disable_reason.valid?
problem "Unrecognized bottle modifier"
elsif @core_tap
if formula.bottle_unneeded?
problem "Formulae in homebrew/core should not use `bottle :unneeded`"
else
problem "Formulae in homebrew/core should not use `bottle :disabled`" problem "Formulae in homebrew/core should not use `bottle :disabled`"
end end
end
end
def audit_github_repository_archived def audit_github_repository_archived
return if formula.deprecated? || formula.disabled? return if formula.deprecated? || formula.disabled?