admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #5138 from MikeMcQuaid/download_strategy_deprecate_naming_update

Browse Source 
compat/download_strategy: improve messaging.
This commit is contained in:
Mike McQuaid 2018-10-20 13:01:20 +01:00 committed by GitHub
commit 0e574eb44e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
Library/Homebrew/compat/download_strategy.rb
View File

@ -10,7 +10,7 @@ require "download_strategy"
class S3DownloadStrategy < CurlDownloadStrategy class S3DownloadStrategy < CurlDownloadStrategy
def initialize(url, name, version, **meta) def initialize(url, name, version, **meta)
odeprecated("S3DownloadStrategy", odeprecated("S3DownloadStrategy",
"maintaining S3DownloadStrategy in your own formula or tap") "a vendored S3DownloadStrategy in your own formula or tap (using require_relative)")
super super
end end
@ -59,7 +59,7 @@ class GitHubPrivateRepositoryDownloadStrategy < CurlDownloadStrategy
def initialize(url, name, version, **meta) def initialize(url, name, version, **meta)
odeprecated("GitHubPrivateRepositoryDownloadStrategy", odeprecated("GitHubPrivateRepositoryDownloadStrategy",
"maintaining GitHubPrivateRepositoryDownloadStrategy in your own formula or tap") "a vendored GitHubPrivateRepositoryDownloadStrategy in your own formula or tap (using require_relative)")
super super
parse_url_pattern parse_url_pattern
set_github_token set_github_token
@ -113,7 +113,7 @@ end
class GitHubPrivateRepositoryReleaseDownloadStrategy < GitHubPrivateRepositoryDownloadStrategy class GitHubPrivateRepositoryReleaseDownloadStrategy < GitHubPrivateRepositoryDownloadStrategy
def initialize(url, name, version, **meta) def initialize(url, name, version, **meta)
odeprecated("GitHubPrivateRepositoryReleaseDownloadStrategy", odeprecated("GitHubPrivateRepositoryReleaseDownloadStrategy",
"maintaining GitHubPrivateRepositoryReleaseDownloadStrategy in your own formula or tap") "a vendored GitHubPrivateRepositoryReleaseDownloadStrategy in your own formula or tap (using require_relative)")
super super
end end
@ -169,7 +169,7 @@ end
class ScpDownloadStrategy < AbstractFileDownloadStrategy class ScpDownloadStrategy < AbstractFileDownloadStrategy
def initialize(url, name, version, **meta) def initialize(url, name, version, **meta)
odeprecated("ScpDownloadStrategy", odeprecated("ScpDownloadStrategy",
"maintaining ScpDownloadStrategy in your own formula or tap") "a vendored ScpDownloadStrategy in your own formula or tap (using require_relative)")
super super
parse_url_pattern parse_url_pattern
end end
@ -215,11 +215,11 @@ class DownloadStrategyDetector
case url case url
when %r{^s3://} when %r{^s3://}
odeprecated("s3://", odeprecated("s3://",
"maintaining S3DownloadStrategy in your own formula or tap") "a vendored S3DownloadStrategy in your own formula or tap (using require_relative)")
S3DownloadStrategy S3DownloadStrategy
when %r{^scp://} when %r{^scp://}
odeprecated("scp://", odeprecated("scp://",
"maintaining ScpDownloadStrategy in your own formula or tap") "a vendored ScpDownloadStrategy in your own formula or tap (using require_relative)")
ScpDownloadStrategy ScpDownloadStrategy
else else
super(url) super(url)
@ -230,19 +230,20 @@ class DownloadStrategyDetector
case symbol case symbol
when :github_private_repo when :github_private_repo
odeprecated(":github_private_repo", odeprecated(":github_private_repo",
"maintaining GitHubPrivateRepositoryDownloadStrategy in your own formula or tap") "a vendored GitHubPrivateRepositoryDownloadStrategy in your own formula or tap (using require_relative)")
GitHubPrivateRepositoryDownloadStrategy GitHubPrivateRepositoryDownloadStrategy
when :github_private_release when :github_private_release
odeprecated(":github_private_repo", odeprecated(":github_private_repo",
"maintaining GitHubPrivateRepositoryReleaseDownloadStrategy in your own formula or tap") "a vendored GitHubPrivateRepositoryReleaseDownloadStrategy in your own formula or tap "\
"(using require_relative)")
GitHubPrivateRepositoryReleaseDownloadStrategy GitHubPrivateRepositoryReleaseDownloadStrategy
when :s3 when :s3
odeprecated(":s3", odeprecated(":s3",
"maintaining S3DownloadStrategy in your own formula or tap") "a vendored S3DownloadStrategy in your own formula or tap (using require_relative)")
S3DownloadStrategy S3DownloadStrategy
when :scp when :scp
odeprecated(":scp", odeprecated(":scp",
"maintaining ScpDownloadStrategy in your own formula or tap") "a vendored ScpDownloadStrategy in your own formula or tap (using require_relative)")
ScpDownloadStrategy ScpDownloadStrategy
else else
super(symbol) super(symbol)