admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

test: fix tests with a shallow clone.

Browse Source 
In this case `HOMEBREW_VERSION` is `>1.1.0 (no git repository)` so these
tests failed. This was the cause of the Homebrew/homebrew-test-bot
Linux CI failures as it was testing a shallow clone.
This commit is contained in:
Mike McQuaid 2017-03-10 16:16:01 +00:00
parent 9105acab6b
commit 0e30d34d27
2 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Library/Homebrew/test/cmd/config_spec.rb
View File

@ -1,7 +1,7 @@
describe "brew config", :integration_test do describe "brew config", :integration_test do
it "prints information about the current Homebrew configuration" do it "prints information about the current Homebrew configuration" do
expect { brew "config" } expect { brew "config" }
.to output(/HOMEBREW_VERSION: #{HOMEBREW_VERSION}/).to_stdout .to output(/HOMEBREW_VERSION: #{Regexp.escape HOMEBREW_VERSION}/).to_stdout
.and not_to_output.to_stderr .and not_to_output.to_stderr
.and be_a_success .and be_a_success
end end

10
Library/Homebrew/test/tab_spec.rb
View File

@ -18,7 +18,7 @@ describe Tab do
subject { subject {
described_class.new( described_class.new(
"homebrew_version" => HOMEBREW_VERSION, "homebrew_version" => HOMEBREW_VERSION,
"used_options" => used_options.as_flags, "used_options" => used_options.as_flags,
"unused_options" => unused_options.as_flags, "unused_options" => unused_options.as_flags,
"built_as_bottle" => false, "built_as_bottle" => false,
@ -51,6 +51,9 @@ describe Tab do
let(:f_tab_content) { (TEST_FIXTURE_DIR/"receipt.json").read } let(:f_tab_content) { (TEST_FIXTURE_DIR/"receipt.json").read }
specify "defaults" do specify "defaults" do
# < 1.1.7 runtime_dependencies were wrong so are ignored
stub_const("HOMEBREW_VERSION", "1.1.7")
tab = described_class.empty tab = described_class.empty
expect(tab.homebrew_version).to eq(HOMEBREW_VERSION) expect(tab.homebrew_version).to eq(HOMEBREW_VERSION)
@ -199,6 +202,9 @@ describe Tab do
describe "::create" do describe "::create" do
it "creates a Tab" do it "creates a Tab" do
# < 1.1.7 runtime dependencies were wrong so are ignored
stub_const("HOMEBREW_VERSION", "1.1.7")
f = formula do f = formula do
url "foo-1.0" url "foo-1.0"
depends_on "bar" depends_on "bar"
@ -223,8 +229,8 @@ describe Tab do
{ "full_name" => "bar", "version" => "2.0" }, { "full_name" => "bar", "version" => "2.0" },
{ "full_name" => "user/repo/from_tap", "version" => "1.0" }, { "full_name" => "user/repo/from_tap", "version" => "1.0" },
] ]
expect(tab.runtime_dependencies).to eq(runtime_dependencies) expect(tab.runtime_dependencies).to eq(runtime_dependencies)
expect(tab.source["path"]).to eq(f.path.to_s) expect(tab.source["path"]).to eq(f.path.to_s)
end end