Merge pull request #20611 from Homebrew/private-taps

tap: actively check repo visibility
This commit is contained in:
Mike McQuaid 2025-09-01 10:43:01 +00:00 committed by GitHub
commit 0dfd80dd55
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -366,23 +366,16 @@ class Tap
return @private unless @private.nil? return @private unless @private.nil?
@private = T.let( @private = T.let(
if (value = config[:private]).nil? begin
config[:private] = begin if core_tap? || core_cask_tap? || OFFICIAL_CMD_TAPS.include?(name)
if custom_remote?
true
else
# Don't store config if we don't know for sure.
return false if (value = GitHub.private_repo?(full_name)).nil?
value
end
rescue GitHub::API::HTTPNotFoundError
true
rescue GitHub::API::Error
false false
elsif custom_remote? || (value = GitHub.private_repo?(full_name)).nil?
true
else
value
end end
else rescue GitHub::API::Error
value true
end, end,
T.nilable(T::Boolean), T.nilable(T::Boolean),
) )