From 2ad43cb1fddbc056d5f5d389e4c24cdb26dfd2d8 Mon Sep 17 00:00:00 2001
From: Dominyk Tiller <dominyktiller@gmail.com>
Date: Fri, 28 Apr 2017 17:37:46 +0100
Subject: [PATCH 1/2] audit: formally ban go get usage

There's been an informal ban for a while but let's
be punchier because this crops up still.
---
 Library/Homebrew/dev-cmd/audit.rb | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Library/Homebrew/dev-cmd/audit.rb b/Library/Homebrew/dev-cmd/audit.rb
index b69fbcfb78..7824052074 100644
--- a/Library/Homebrew/dev-cmd/audit.rb
+++ b/Library/Homebrew/dev-cmd/audit.rb
@@ -885,6 +885,10 @@ class FormulaAuditor
       problem "Formulae using virtualenvs do not need a `setuptools` resource."
     end
 
+    if text =~ /system\s+['"]go['"],\s+['"]get['"]/
+      problem "Formulae should not use `go get`. If non-vendored resources are required use `go_resource`s."
+    end
+
     return unless text.include?('require "language/go"') && !text.include?("go_resource")
     problem "require \"language/go\" is unnecessary unless using `go_resource`s"
   end

From ed1ae19aee53c3631a5d4a20e1f4e0a903511cca Mon Sep 17 00:00:00 2001
From: Dominyk Tiller <dominyktiller@gmail.com>
Date: Fri, 28 Apr 2017 18:13:38 +0100
Subject: [PATCH 2/2] audit_spec: test go get ban

---
 Library/Homebrew/test/dev-cmd/audit_spec.rb | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/Library/Homebrew/test/dev-cmd/audit_spec.rb b/Library/Homebrew/test/dev-cmd/audit_spec.rb
index 9afb7954ae..771e1ee799 100644
--- a/Library/Homebrew/test/dev-cmd/audit_spec.rb
+++ b/Library/Homebrew/test/dev-cmd/audit_spec.rb
@@ -430,6 +430,21 @@ describe FormulaAuditor do
       expect(fa.problems.first)
         .to match('xcodebuild should be passed an explicit "SYMROOT"')
     end
+
+    specify "disallow go get usage" do
+      fa = formula_auditor "foo", <<-EOS.undent
+        class Foo <Formula
+          url "http://example.com/foo-1.0.tgz"
+
+          def install
+            system "go", "get", "bar"
+          end
+        end
+      EOS
+      fa.audit_text
+      expect(fa.problems.first)
+        .to match("Formulae should not use `go get`. If non-vendored resources are required use `go_resource`s.")
+    end
   end
 
   describe "#audit_revision_and_version_scheme" do