rubocop: Drop "o" from Naming/MethodParameterName allowlist

- I couldn't figure out what this would stand for, so I asked on Slack
  if anyone had better ideas otherwise I'd go with "ostrich" or
  "octopus". Rylan suggested "option", which is very sensible.

Library/.rubocop.yml

@@ -189,7 +189,6 @@ Naming/MethodParameterName:
       - AllowedNames
   AllowedNames:
     [
-      "o",
       "pr",
     ]
 

Library/Homebrew/build_environment.rb

@@ -18,9 +18,9 @@ class BuildEnvironment
     self
   end
 
-  sig { params(o: Symbol).returns(T.self_type) }
+  sig { params(option: Symbol).returns(T.self_type) }
-  def <<(o)
+  def <<(option)
-    @settings << o
+    @settings << option
     self
   end
 

Library/Homebrew/options.rb

@@ -139,8 +139,8 @@ class Options
     map(&:flag)
   end
 
-  def include?(o)
+  def include?(option)
-    any? { |opt| opt == o || opt.name == o || opt.flag == o }
+    any? { |opt| opt == option || opt.name == option || opt.flag == option }
   end
 
   alias to_ary to_a