From 0c1186f47fd4ee1b9cde6a00125a1835e083478c Mon Sep 17 00:00:00 2001 From: Misty De Meo Date: Mon, 29 May 2017 15:27:44 -0700 Subject: [PATCH] cabextract: remove -t test The warnings this prints makes it not especially helpful, so just assume the magic number test and job failure are enough. Fixes #2689. --- Library/Homebrew/cask/lib/hbc/container/cab.rb | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/Library/Homebrew/cask/lib/hbc/container/cab.rb b/Library/Homebrew/cask/lib/hbc/container/cab.rb index b3cf01452a..010fccbc40 100644 --- a/Library/Homebrew/cask/lib/hbc/container/cab.rb +++ b/Library/Homebrew/cask/lib/hbc/container/cab.rb @@ -6,11 +6,7 @@ module Hbc class Container class Cab < Base def self.me?(criteria) - cabextract = which("cabextract") - - criteria.magic_number(/^(MSCF|MZ)/n) && - !cabextract.nil? && - criteria.command.run(cabextract, args: ["-t", "--", criteria.path.to_s]).stderr.empty? + criteria.magic_number(/^(MSCF|MZ)/n) end def extract