From 0bf35a05a9140cf5da59f236927a07cd689fd123 Mon Sep 17 00:00:00 2001 From: Jack Nagel Date: Wed, 22 May 2013 19:42:43 -0500 Subject: [PATCH] Favor equality check over nil check --- Library/Homebrew/keg_fix_install_names.rb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Library/Homebrew/keg_fix_install_names.rb b/Library/Homebrew/keg_fix_install_names.rb index 3e9f7cdaad..c5a2ab9ea7 100644 --- a/Library/Homebrew/keg_fix_install_names.rb +++ b/Library/Homebrew/keg_fix_install_names.rb @@ -8,7 +8,7 @@ class Keg bad_names.each do |bad_name| new_name = fixed_name(file, bad_name) - unless new_name.nil? + unless new_name == bad_name install_name_tool("-change", bad_name, new_name, file) end end @@ -61,7 +61,8 @@ class Keg elsif (abs_name = find_dylib(Pathname.new(bad_name).basename)) && abs_name.exist? abs_name.to_s else - opoo "Could not fix install names for #{file}" + opoo "Could not fix #{bad_name} in #{file}" + bad_name end end