admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

unpack_strategy/dmg: fix permissions when needed.

Browse Source 
`ditto` behaves weirdly when the EUID is different from the UID. This
fix ensures that the BOM file is written with the correct permissions
in this case.
This commit is contained in:
Mike McQuaid 2024-04-01 09:49:10 +01:00
parent 8a59266e92
commit 0bbfa434cf
No known key found for this signature in database
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Library/Homebrew/unpack_strategy/dmg.rb
View File

@ -147,8 +147,16 @@ module UnpackStrategy
verbose: verbose:
end end
bomfile_path = T.must(bomfile.path)
# Ditto will try to write as the UID, not the EUID and the Tempfile has 0700 permissions.
if Process.euid != Process.uid
FileUtils.chown(nil, Process.gid, bomfile_path)
FileUtils.chmod "g+rw", bomfile_path
end
system_command!("ditto", system_command!("ditto",
args: ["--bom", bomfile.path, "--", path, unpack_dir], args: ["--bom", bomfile_path, "--", path, unpack_dir],
verbose:) verbose:)
FileUtils.chmod "u+w", Pathname.glob(unpack_dir/"**/*", File::FNM_DOTMATCH).reject(&:symlink?) FileUtils.chmod "u+w", Pathname.glob(unpack_dir/"**/*", File::FNM_DOTMATCH).reject(&:symlink?)