admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #20226 from Homebrew/formula-loading-stdout

Browse Source 
formulary: prevent formulae from printing to stdout while being loaded
This commit is contained in:
Carlo Cabrera 2025-07-10 12:43:42 +00:00 committed by GitHub
commit 0b99d57621
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
Library/Homebrew/formulary.rb
View File

@ -97,6 +97,11 @@ module Formulary
require "formula" require "formula"
require "ignorable" require "ignorable"
require "stringio"
# Capture stdout to prevent formulae from printing to stdout unexpectedly.
old_stdout = $stdout
$stdout = StringIO.new
mod = Module.new mod = Module.new
remove_const(namespace) if const_defined?(namespace) remove_const(namespace) if const_defined?(namespace)
@ -133,6 +138,16 @@ module Formulary
remove_const(namespace) remove_const(namespace)
raise new_exception, "", e.backtrace raise new_exception, "", e.backtrace
end end
ensure
# TODO: Make printing to stdout an error so that we can print a tap name.
# See discussion at https://github.com/Homebrew/brew/pull/20226#discussion_r2195886888
if (printed_to_stdout = $stdout.string.strip.presence)
opoo <<~WARNING
Formula #{name} attempted to print the following while being loaded:
#{printed_to_stdout}
WARNING
end
$stdout = old_stdout
end end
sig { params(identifier: String).returns(String) } sig { params(identifier: String).returns(String) }