rubocops/cask: on_#{os_version} is after [version & sha256] group

- This still doesn't pass `brew readall` for Casks, but it gets us a
  little closer since if `url` has a `version` interpolated in it, the
  `version` stanza has to come first.
- See https://github.com/Homebrew/homebrew-cask/pull/143201 for the
  current failures.
This commit is contained in:
Issy Long 2023-03-17 22:56:50 +00:00
parent 48b1279b00
commit 0af5825dfb
No known key found for this signature in database
GPG Key ID: 8247C390DADC67D4
2 changed files with 4 additions and 4 deletions

View File

@ -14,8 +14,8 @@ module RuboCop
STANZA_GROUPS = [ STANZA_GROUPS = [
[:arch, :on_arch_conditional], [:arch, :on_arch_conditional],
ON_SYSTEM_METHODS_STANZA_ORDER,
[:version, :sha256], [:version, :sha256],
ON_SYSTEM_METHODS_STANZA_ORDER,
[:language], [:language],
[:url, :appcast, :name, :desc, :homepage], [:url, :appcast, :name, :desc, :homepage],
[:livecheck], [:livecheck],

View File

@ -2,9 +2,6 @@ cask "with-depends-on-macos-failure" do
version "1.2.3" version "1.2.3"
sha256 "67cdb8a02803ef37fdbf7e0be205863172e41a561ca446cd84f0d7ab35a99d94" sha256 "67cdb8a02803ef37fdbf7e0be205863172e41a561ca446cd84f0d7ab35a99d94"
url "file://#{TEST_FIXTURE_DIR}/cask/caffeine.zip"
homepage "https://brew.sh/with-depends-on-macos-failure"
# guarantee a mismatched release # guarantee a mismatched release
on_mojave :or_older do on_mojave :or_older do
depends_on macos: :catalina depends_on macos: :catalina
@ -16,5 +13,8 @@ cask "with-depends-on-macos-failure" do
depends_on macos: :catalina depends_on macos: :catalina
end end
url "file://#{TEST_FIXTURE_DIR}/cask/caffeine.zip"
homepage "https://brew.sh/with-depends-on-macos-failure"
app "Caffeine.app" app "Caffeine.app"
end end