admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

dev-cmd/bump: Ignore Repology if the livecheck uses GithubLatest

Browse Source 
- I got frustrated when I fixed the build and test failures for
  https://github.com/Homebrew/homebrew-core/pull /95430 only to have the
  audit step say it was a pre-release.
- Repology can list versions that are GitHub pre-releases. Pre-release
  versions of software are things we don't generally want to ship:
  there's an audit specifically for that.
- This fixes `brew bump` to not mark a Repology version as the newest if
  the formula's livecheck strategy is `GithubLatest`. If the livecheck
  doesn't exist, or its update strategy is something other than
  `GithubLatest`, Repology's reported package version is respected.
This commit is contained in:
Issy Long 2022-02-19 21:03:02 +00:00
parent 374adf7f15
commit 0a91c40ed5
No known key found for this signature in database
GPG Key ID: 8247C390DADC67D4
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
Library/Homebrew/dev-cmd/bump.rb
View File

@ -201,13 +201,14 @@ module Homebrew
version_info = Livecheck.latest_version( version_info = Livecheck.latest_version(
formula_or_cask, formula_or_cask,
referenced_formula_or_cask: referenced_formula_or_cask, referenced_formula_or_cask: referenced_formula_or_cask,
json: true, full_name: false, verbose: false, debug: false json: true, full_name: false, verbose: true, debug: false
) )
latest = version_info[:latest] if version_info.present? return "unable to get versions" if version_info.blank?
return "unable to get versions" if latest.blank? latest = version_info[:latest]
strategy = version_info[:meta][:strategy]
Version.new(latest) [Version.new(latest), strategy]
rescue => e rescue => e
"error: #{e}" "error: #{e}"
end end
@ -233,7 +234,7 @@ module Homebrew
version_name = "cask version " version_name = "cask version "
end end
livecheck_latest = livecheck_result(formula_or_cask) livecheck_latest, livecheck_strategy = livecheck_result(formula_or_cask)
repology_latest = if repositories.present? repology_latest = if repositories.present?
Repology.latest_version(repositories) Repology.latest_version(repositories)
@ -243,7 +244,7 @@ module Homebrew
new_version = if livecheck_latest.is_a?(Version) && livecheck_latest > current_version new_version = if livecheck_latest.is_a?(Version) && livecheck_latest > current_version
livecheck_latest livecheck_latest
elsif repology_latest.is_a?(Version) && repology_latest > current_version elsif repology_latest.is_a?(Version) && repology_latest > current_version && livecheck_strategy != "GithubLatest"
repology_latest repology_latest
end.presence end.presence