admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Let the API do more work for us

Browse Source
This commit is contained in:
Jack Nagel 2014-02-12 12:17:32 -05:00
parent 33f344bdd4
commit 0a3794776e
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Library/Homebrew/utils.rb
View File

@ -290,7 +290,7 @@ module GitHub extend self
def issues_matching(query) def issues_matching(query)
uri = ISSUES_URI.dup uri = ISSUES_URI.dup
uri.query = "q=#{uri_escape(query)}+repo:Homebrew/homebrew&per_page=100" uri.query = "q=#{uri_escape(query)}+repo:Homebrew/homebrew+in:title&per_page=100"
open(uri) { |json| json["items"] } open(uri) { |json| json["items"] }
end end
@ -305,9 +305,7 @@ module GitHub extend self
def issues_for_formula name def issues_for_formula name
# don't include issues that just refer to the tool in their body # don't include issues that just refer to the tool in their body
issues_matching(name).select { |issue| issues_matching(name).select { |issue| issue["state"] == "open" }
issue["state"] == "open" && issue["title"].include?(name)
}
end end
def find_pull_requests rx def find_pull_requests rx
@ -317,7 +315,7 @@ module GitHub extend self
query = rx.source.delete('.*').gsub('\\', '') query = rx.source.delete('.*').gsub('\\', '')
open_or_closed_prs = issues_matching(query).select do |issue| open_or_closed_prs = issues_matching(query).select do |issue|
rx === issue["title"] && issue["pull_request"]["html_url"] issue["pull_request"]["html_url"]
end end
open_prs = open_or_closed_prs.select {|i| i["state"] == "open" } open_prs = open_or_closed_prs.select {|i| i["state"] == "open" }