admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Strategy#from_url: remove unused param

Browse Source 
The `url_provided` parameter of the `Strategy#from_url` method was
originally introduced in #9529 but I removed it in a later commit in
that PR in favor of a different approach. Unfortunately, I forgot to
remove the `url_provided` parameter, as it was no longer needed after
that change. This removes the parameter and updates `#from_url` calls
accordingly.
This commit is contained in:
Sam Ford 2024-07-25 13:13:36 -04:00
parent 34fbf09841
commit 0a2e9661b6
No known key found for this signature in database
GPG Key ID: 7AF5CBEE1DD6F76D
2 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Library/Homebrew/livecheck/livecheck.rb
View File

@ -715,7 +715,6 @@ module Homebrew
strategies = Strategy.from_url(
url,
livecheck_strategy:,
url_provided: livecheck_url.present?,
regex_provided: livecheck_regex.present?,
block_provided: livecheck_strategy_block.present?,
)
@ -930,7 +929,6 @@ module Homebrew
strategies = Strategy.from_url(
url,
livecheck_strategy:,
url_provided: livecheck_url.present?,
regex_provided: livecheck_regex.present?,
block_provided: livecheck_strategy_block.present?,
)

5
Library/Homebrew/livecheck/strategy.rb
View File

@ -125,8 +125,6 @@ module Homebrew
# @param url [String] the URL to check for matching strategies
# @param livecheck_strategy [Symbol] a strategy symbol from the
# `livecheck` block
# @param url_provided [Boolean] whether a url is provided in the
# `livecheck` block
# @param regex_provided [Boolean] whether a regex is provided in the
# `livecheck` block
# @param block_provided [Boolean] whether a `strategy` block is provided
@ -136,12 +134,11 @@ module Homebrew
params(
url: String,
livecheck_strategy: T.nilable(Symbol),
url_provided: T::Boolean,
regex_provided: T::Boolean,
block_provided: T::Boolean,
).returns(T::Array[T.untyped])
}
def from_url(url, livecheck_strategy: nil, url_provided: false, regex_provided: false, block_provided: false)
def from_url(url, livecheck_strategy: nil, regex_provided: false, block_provided: false)
usable_strategies = strategies.select do |strategy_symbol, strategy|
if strategy == PageMatch
# Only treat the strategy as usable if the `livecheck` block