@MikeMcQuaid requested changes

This commit is contained in:
Bruce Steedman 2016-11-12 12:03:04 +00:00
parent bbea4ac871
commit 098974b2a1
2 changed files with 5 additions and 4 deletions

View File

@ -106,6 +106,7 @@ class BuildOptions
@args - @options @args - @options
end end
# @private
def invalid_option_names def invalid_option_names
invalid_options.map(&:flag).sort invalid_options.map(&:flag).sort
end end

View File

@ -32,7 +32,7 @@ class FormulaInstaller
end end
attr_reader :formula attr_reader :formula
attr_accessor :options, :build_bottle, :invalid_opt_names attr_accessor :options, :build_bottle, :invalid_option_names
mode_attr_accessor :show_summary_heading, :show_header mode_attr_accessor :show_summary_heading, :show_header
mode_attr_accessor :build_from_source, :force_bottle mode_attr_accessor :build_from_source, :force_bottle
mode_attr_accessor :ignore_deps, :only_deps, :interactive, :git mode_attr_accessor :ignore_deps, :only_deps, :interactive, :git
@ -52,7 +52,7 @@ class FormulaInstaller
@quieter = false @quieter = false
@debug = false @debug = false
@options = Options.new @options = Options.new
@invalid_opt_names = [] @invalid_option_names = []
@@attempted ||= Set.new @@attempted ||= Set.new
@ -215,8 +215,8 @@ class FormulaInstaller
opoo "#{formula.full_name}: #{old_flag} was deprecated; using #{new_flag} instead!" opoo "#{formula.full_name}: #{old_flag} was deprecated; using #{new_flag} instead!"
end end
invalid_opt_names.each do |option| invalid_option_names.each do |option|
opoo "#{formula.full_name}: #{option} is invalid for this formula and will be ignored!" opoo "#{formula.full_name}: this formula has no #{option} option so it will be ignored!"
end end
oh1 "Installing #{Formatter.identifier(formula.full_name)}" if show_header? oh1 "Installing #{Formatter.identifier(formula.full_name)}" if show_header?