From 20311aec15e017339fcb39b3121d0c7049dcbfb2 Mon Sep 17 00:00:00 2001 From: Dominyk Tiller Date: Sat, 11 Aug 2018 01:49:35 +0100 Subject: [PATCH] audit: flag redundant shell_output() exit codes --- Library/Homebrew/dev-cmd/audit.rb | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Library/Homebrew/dev-cmd/audit.rb b/Library/Homebrew/dev-cmd/audit.rb index a0104244a8..8818bf2474 100644 --- a/Library/Homebrew/dev-cmd/audit.rb +++ b/Library/Homebrew/dev-cmd/audit.rb @@ -803,6 +803,10 @@ module Homebrew problem "Use separate make calls" if line.include?("make && make") + if line =~ /shell_output\(['"].+['"], 0\)/ + problem "Passing 0 to shell_output() is redundant" + end + if line =~ /JAVA_HOME/i && !formula.requirements.map(&:class).include?(JavaRequirement) problem "Use `depends_on :java` to set JAVA_HOME" end