diff --git a/Library/Homebrew/rubocops/no_fileutils_rmrf.rb b/Library/Homebrew/rubocops/no_fileutils_rmrf.rb index 9828d12c30..b1e22cf30f 100644 --- a/Library/Homebrew/rubocops/no_fileutils_rmrf.rb +++ b/Library/Homebrew/rubocops/no_fileutils_rmrf.rb @@ -46,8 +46,8 @@ module RuboCop else node.arguments.first.source end - - corrector.replace(node.loc.expression, "#{class_name}#{new_method}(#{args})") + args = "(#{args})" unless args.start_with?("(") + corrector.replace(node.loc.expression, "#{class_name}#{new_method}#{args}") end end diff --git a/Library/Homebrew/test/rubocops/no_fileutils_rmrf_spec.rb b/Library/Homebrew/test/rubocops/no_fileutils_rmrf_spec.rb index 128d3bd3e5..bc8b4aa99f 100644 --- a/Library/Homebrew/test/rubocops/no_fileutils_rmrf_spec.rb +++ b/Library/Homebrew/test/rubocops/no_fileutils_rmrf_spec.rb @@ -64,6 +64,8 @@ RSpec.describe RuboCop::Cop::Homebrew::NoFileutilsRmrf do end buildpath.rmtree ^^^^^^^^^^^^^^^^ Homebrew/NoFileutilsRmrf: #{RuboCop::Cop::Homebrew::NoFileutilsRmrf::MSG} + (path/"here").rmtree + ^^^^^^^^^^^^^^^^^^^^ Homebrew/NoFileutilsRmrf: #{RuboCop::Cop::Homebrew::NoFileutilsRmrf::MSG} RUBY end @@ -76,6 +78,7 @@ RSpec.describe RuboCop::Cop::Homebrew::NoFileutilsRmrf do Pathname("path/to/yet/another/directory") end buildpath.rmtree + (path/"here").rmtree RUBY expect(corrected).to eq(<<~RUBY) @@ -86,6 +89,7 @@ RSpec.describe RuboCop::Cop::Homebrew::NoFileutilsRmrf do Pathname("path/to/yet/another/directory") end FileUtils.rm_r(buildpath) + FileUtils.rm_r(path/"here") RUBY end end