Merge pull request #15301 from Bo98/bundle-clean

utils/gems: run `bundle clean` when install not required
This commit is contained in:
Mike McQuaid 2023-04-24 17:20:54 +01:00 committed by GitHub
commit 0841d1a25e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -155,6 +155,12 @@ module Homebrew
invalid_groups = groups - valid_gem_groups
raise ArgumentError, "Invalid gem groups: #{invalid_groups.join(", ")}" unless invalid_groups.empty?
# tests should not modify the state of the repo
if ENV["HOMEBREW_TESTS"]
setup_gem_environment!
return
end
install_bundler!
require "settings"
@ -194,8 +200,18 @@ module Homebrew
end
false
end
else
elsif system bundle, "clean" # even if we have nothing to install, we may have removed gems
true
else
message = <<~EOS
failed to run `#{bundle} clean`!
EOS
if only_warn_on_failure
opoo_if_defined message
else
odie_if_defined message
end
false
end
if bundle_installed