From f6b260d7c4b04a353c6ca42bd07941251316740f Mon Sep 17 00:00:00 2001 From: hyuraku <32809703+hyuraku@users.noreply.github.com> Date: Sun, 22 Mar 2020 22:00:32 +0900 Subject: [PATCH 1/3] audit whether prerelease or not --- Library/Homebrew/dev-cmd/audit.rb | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Library/Homebrew/dev-cmd/audit.rb b/Library/Homebrew/dev-cmd/audit.rb index d83a5bea1d..67028a2a6a 100644 --- a/Library/Homebrew/dev-cmd/audit.rb +++ b/Library/Homebrew/dev-cmd/audit.rb @@ -795,6 +795,13 @@ module Homebrew return if stable_url_minor_version.even? problem "#{stable.version} is a development release" + when %r(^https://github.com/) + repo_url = URI.parse(stable.url) + path = repo_url.path.split('/') + owner = path[1] + repo = path[2] + return unless GitHub.open_api("#{GitHub::API_URL}/repos/#{owner}/#{repo}/releases/tags/#{stable.version}")["prerelease"] + problem "#{stable.version} is a pre release" end end From a6fcc94249441c1d26257d16c4d208907bfdd86a Mon Sep 17 00:00:00 2001 From: hyuraku <32809703+hyuraku@users.noreply.github.com> Date: Sun, 22 Mar 2020 22:18:00 +0900 Subject: [PATCH 2/3] repair style --- Library/Homebrew/dev-cmd/audit.rb | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/Library/Homebrew/dev-cmd/audit.rb b/Library/Homebrew/dev-cmd/audit.rb index 67028a2a6a..1805ff5fa4 100644 --- a/Library/Homebrew/dev-cmd/audit.rb +++ b/Library/Homebrew/dev-cmd/audit.rb @@ -795,13 +795,14 @@ module Homebrew return if stable_url_minor_version.even? problem "#{stable.version} is a development release" - when %r(^https://github.com/) + when %r{^https://github.com/} repo_url = URI.parse(stable.url) - path = repo_url.path.split('/') + path = repo_url.path.split("/") owner = path[1] repo = path[2] - return unless GitHub.open_api("#{GitHub::API_URL}/repos/#{owner}/#{repo}/releases/tags/#{stable.version}")["prerelease"] - problem "#{stable.version} is a pre release" + if GitHub.open_api("#{GitHub::API_URL}/repos/#{owner}/#{repo}/releases/tags/#{stable.version}")["prerelease"] + problem "#{stable.version} is a pre release" + end end end From fa80296ab4de396ff91d3803d26c313fb4a98622 Mon Sep 17 00:00:00 2001 From: hyuraku <32809703+hyuraku@users.noreply.github.com> Date: Sun, 22 Mar 2020 23:25:13 +0900 Subject: [PATCH 3/3] repair notation --- Library/Homebrew/dev-cmd/audit.rb | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/Library/Homebrew/dev-cmd/audit.rb b/Library/Homebrew/dev-cmd/audit.rb index 1805ff5fa4..dc8ea8d603 100644 --- a/Library/Homebrew/dev-cmd/audit.rb +++ b/Library/Homebrew/dev-cmd/audit.rb @@ -796,12 +796,9 @@ module Homebrew problem "#{stable.version} is a development release" when %r{^https://github.com/} - repo_url = URI.parse(stable.url) - path = repo_url.path.split("/") - owner = path[1] - repo = path[2] + _, owner, repo, = URI.parse(stable.url).path.split("/") if GitHub.open_api("#{GitHub::API_URL}/repos/#{owner}/#{repo}/releases/tags/#{stable.version}")["prerelease"] - problem "#{stable.version} is a pre release" + problem "#{stable.version} is a GitHub prerelease" end end end