From 077837950112090419a5f61c14f7ff7bb56f6f6c Mon Sep 17 00:00:00 2001 From: Aaron Ruan Date: Mon, 27 May 2024 00:34:08 +0800 Subject: [PATCH] change tests for auditing OSDN download urls --- Library/Homebrew/test/cask/audit_spec.rb | 16 ++++++++++------ .../{osdn-correct-url-format.rb => osdn-urls.rb} | 2 +- 2 files changed, 11 insertions(+), 7 deletions(-) rename Library/Homebrew/test/support/fixtures/cask/Casks/{osdn-correct-url-format.rb => osdn-urls.rb} (80%) diff --git a/Library/Homebrew/test/cask/audit_spec.rb b/Library/Homebrew/test/cask/audit_spec.rb index 72a330e61d..37a26bb61e 100644 --- a/Library/Homebrew/test/cask/audit_spec.rb +++ b/Library/Homebrew/test/cask/audit_spec.rb @@ -932,17 +932,21 @@ RSpec.describe Cask::Audit, :cask do it { is_expected.not_to error_with(message) } end + end - context "with incorrect OSDN URL format" do - let(:cask_token) { "osdn-incorrect-url-format" } + describe "disable OSDN download url" do + let(:only) { ["download_url_is_osdn"] } + let(:message) { /OSDN download urls are disabled./ } + let(:cask_token) { "osdn-urls" } - it { is_expected.to error_with(message) } + context "when --strict is not passed" do + it { is_expected.not_to error_with(message) } end - context "with correct OSDN URL format" do - let(:cask_token) { "osdn-correct-url-format" } + context "when --strict is passed" do + let(:strict) { true } - it { is_expected.not_to error_with(message) } + it { is_expected.to error_with(message)} end end diff --git a/Library/Homebrew/test/support/fixtures/cask/Casks/osdn-correct-url-format.rb b/Library/Homebrew/test/support/fixtures/cask/Casks/osdn-urls.rb similarity index 80% rename from Library/Homebrew/test/support/fixtures/cask/Casks/osdn-correct-url-format.rb rename to Library/Homebrew/test/support/fixtures/cask/Casks/osdn-urls.rb index c80bdacf6d..569859db53 100644 --- a/Library/Homebrew/test/support/fixtures/cask/Casks/osdn-correct-url-format.rb +++ b/Library/Homebrew/test/support/fixtures/cask/Casks/osdn-urls.rb @@ -1,4 +1,4 @@ -cask "osdn-correct-url-format" do +cask "osdn-urls" do version "1.2.3" url "https://user.dl.osdn.jp/something/id/Something-1.2.3.dmg"