admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

formula_desc_cop: empty string is not a valid desc

Browse Source 
Just a slightly tweaked version of https://github.com/Homebrew/brew/issues/3286#issuecomment-334983011
This commit is contained in:
Dominyk Tiller 2017-10-09 17:01:35 +01:00
parent e1808bf0e3
commit 075f818118
No known key found for this signature in database
GPG Key ID: FE19AEFCF658C6F6
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Library/Homebrew/rubocops/formula_desc_cop.rb
View File

@ -18,8 +18,14 @@ module RuboCop
return return
end end
# Check if a formula's desc is too long # Check the formula's desc length. Should be >0 and <80 characters.
desc = parameters(desc_call).first desc = parameters(desc_call).first
pure_desc_length = string_content(desc).length
if pure_desc_length.zero?
problem "The desc (description) should not be an empty string."
return
end
desc_length = "#{@formula_name}: #{string_content(desc)}".length desc_length = "#{@formula_name}: #{string_content(desc)}".length
max_desc_length = 80 max_desc_length = 80
return if desc_length <= max_desc_length return if desc_length <= max_desc_length