admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Use the correct name for the GitHub username envvar: HOMEBREW_GITHUB_USER

Browse Source
This commit is contained in:
Issy Long 2019-09-15 12:38:58 +01:00
parent cae41ef006
commit 06d86d041f
No known key found for this signature in database
GPG Key ID: 8247C390DADC67D4
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
docs/Homebrew-linuxbrew-core-Maintainer-Guide.md
View File

@ -39,14 +39,14 @@ merge and make sure that there are 3 remotes:
Remote names `origin` and `homebrew` are hard-coded in Remote names `origin` and `homebrew` are hard-coded in
`merge-homebrew`, while the remote pointing to your fork must be the `merge-homebrew`, while the remote pointing to your fork must be the
same as your GitHub username, as it will be used to submit a pull same as your GitHub username, as it will be used to submit a pull
request for the merge. Set the name to the `$GITHUB_USER` environment request for the merge. Set the name to the `$HOMEBREW_GITHUB_USER` environment
variable, or let `hub fork` add a remote for you. variable, or let `hub fork` add a remote for you.
```bash ```bash
brew install hub brew install hub
cd $(brew --repo homebrew/core) cd $(brew --repo homebrew/core)
git remote add homebrew https://github.com/Homebrew/homebrew-core.git git remote add homebrew https://github.com/Homebrew/homebrew-core.git
hub fork --remote-name=$GITHUB_USER hub fork --remote-name=$HOMEBREW_GITHUB_USER
``` ```
Now, let's make sure that our local branch `master` is clean and that Now, let's make sure that our local branch `master` is clean and that
@ -56,7 +56,7 @@ your fork is up-to-date with Homebrew/linuxbrew-core:
git checkout master git checkout master
git fetch origin master git fetch origin master
git reset --hard origin/master git reset --hard origin/master
git push --force $GITHUB_USER master git push --force $HOMEBREW_GITHUB_USER master
``` ```
Strictly speaking, there is no need for `git reset --hard Strictly speaking, there is no need for `git reset --hard
@ -219,7 +219,7 @@ command where the merge commit is `HEAD`:
```sh ```sh
for formula in $(brew find-formulae-to-bottle); do for formula in $(brew find-formulae-to-bottle); do
brew build-bottle-pr --remote=$GITHUB_USER $formula brew build-bottle-pr --remote=$HOMEBREW_GITHUB_USER $formula
done done
``` ```