admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Resolve formula_spec violation

Browse Source
This commit is contained in:
Douglas Eichelberger 2023-01-22 17:07:24 -08:00
parent b2ffa09ee9
commit 06d037eadf
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Library/Homebrew/test/formula_spec.rb
View File

@ -298,17 +298,19 @@ describe Formula do
let(:f) { Testball.new } let(:f) { Testball.new }
it "returns false if the #latest_installed_prefix is not a directory" do it "returns false if the #latest_installed_prefix is not a directory" do
allow(f).to receive(:latest_installed_prefix).and_return(double(directory?: false)) allow(f).to receive(:latest_installed_prefix).and_return(instance_double(Pathname, directory?: false))
expect(f).not_to be_latest_version_installed expect(f).not_to be_latest_version_installed
end end
it "returns false if the #latest_installed_prefix does not have children" do it "returns false if the #latest_installed_prefix does not have children" do
allow(f).to receive(:latest_installed_prefix).and_return(double(directory?: true, children: [])) allow(f).to receive(:latest_installed_prefix)
.and_return(instance_double(Pathname, directory?: true, children: []))
expect(f).not_to be_latest_version_installed expect(f).not_to be_latest_version_installed
end end
it "returns true if the #latest_installed_prefix has children" do it "returns true if the #latest_installed_prefix has children" do
allow(f).to receive(:latest_installed_prefix).and_return(double(directory?: true, children: [double])) allow(f).to receive(:latest_installed_prefix)
.and_return(instance_double(Pathname, directory?: true, children: [double]))
expect(f).to be_latest_version_installed expect(f).to be_latest_version_installed
end end
end end
@ -821,7 +823,7 @@ describe Formula do
keg = Keg.for(formula.latest_installed_prefix) keg = Keg.for(formula.latest_installed_prefix)
keg.link keg.link
linkage_checker = double("linkage checker", undeclared_deps: [dependency.name]) linkage_checker = instance_double(LinkageChecker, "linkage checker", undeclared_deps: [dependency.name])
allow(LinkageChecker).to receive(:new).and_return(linkage_checker) allow(LinkageChecker).to receive(:new).and_return(linkage_checker)
expect(formula.runtime_dependencies.map(&:name)).to eq [dependency.name] expect(formula.runtime_dependencies.map(&:name)).to eq [dependency.name]