Merge pull request #10193 from Homebrew/dependabot/bundler/Library/Homebrew/rubocop-performance-1.9.2

build(deps): bump rubocop-performance from 1.9.1 to 1.9.2 in /Library/Homebrew

Library/Homebrew/Gemfile.lock

@@ -113,7 +113,7 @@ GEM
       unicode-display_width (>= 1.4.0, < 2.0)
     rubocop-ast (1.3.0)
       parser (>= 2.7.1.5)
-    rubocop-performance (1.9.1)
+    rubocop-performance (1.9.2)
       rubocop (>= 0.90.0, < 2.0)
       rubocop-ast (>= 0.4.0)
     rubocop-rails (2.9.1)
@@ -126,7 +126,7 @@ GEM
     rubocop-sorbet (0.5.1)
       rubocop
     ruby-macho (2.5.0)
-    ruby-progressbar (1.10.1)
+    ruby-progressbar (1.11.0)
     simplecov (0.20.0)
       docile (~> 1.1)
       simplecov-html (~> 0.11)

Library/Homebrew/sorbet/rbi/gems/rubocop-performance@1.9.2.rbi

@@ -630,15 +630,13 @@ class RuboCop::Cop::Performance::ReverseEach < ::RuboCop::Cop::Base
 
   private
 
-  def replacement_range(node); end
+  def offense_range(node); end
 end
 
 RuboCop::Cop::Performance::ReverseEach::MSG = T.let(T.unsafe(nil), String)
 
 RuboCop::Cop::Performance::ReverseEach::RESTRICT_ON_SEND = T.let(T.unsafe(nil), Array)
 
-RuboCop::Cop::Performance::ReverseEach::UNDERSCORE = T.let(T.unsafe(nil), String)
-
 class RuboCop::Cop::Performance::ReverseFirst < ::RuboCop::Cop::Base
   include(::RuboCop::Cop::RangeHelp)
   extend(::RuboCop::Cop::AutoCorrector)

Library/Homebrew/sorbet/rbi/gems/ruby-progressbar@1.11.0.rbi

@@ -1,6 +1,6 @@
 # DO NOT EDIT MANUALLY
 # This is an autogenerated file for types exported from the `ruby-progressbar` gem.
-# Please instead update this file by running `tapioca generate --exclude json`.
+# Please instead update this file by running `tapioca sync`.
 
 # typed: true
 
@@ -47,27 +47,27 @@ class ProgressBar::Base
   protected
 
   def autofinish; end
-  def autofinish=(_); end
+  def autofinish=(_arg0); end
   def autostart; end
-  def autostart=(_); end
+  def autostart=(_arg0); end
   def bar; end
-  def bar=(_); end
+  def bar=(_arg0); end
   def finished; end
-  def finished=(_); end
+  def finished=(_arg0); end
   def output; end
-  def output=(_); end
+  def output=(_arg0); end
   def percentage; end
-  def percentage=(_); end
+  def percentage=(_arg0); end
   def progressable; end
-  def progressable=(_); end
+  def progressable=(_arg0); end
   def rate; end
-  def rate=(_); end
+  def rate=(_arg0); end
   def time; end
-  def time=(_); end
+  def time=(_arg0); end
   def timer; end
-  def timer=(_); end
+  def timer=(_arg0); end
   def title_comp; end
-  def title_comp=(_); end
+  def title_comp=(_arg0); end
   def update_progress(*args); end
 end
 
@@ -79,13 +79,13 @@ class ProgressBar::Calculators::Length
 
   def calculate_length; end
   def current_length; end
-  def current_length=(_); end
+  def current_length=(_arg0); end
   def length; end
   def length_changed?; end
   def length_override; end
   def length_override=(other); end
   def output; end
-  def output=(_); end
+  def output=(_arg0); end
   def reset_length; end
 
   private
@@ -113,16 +113,16 @@ class ProgressBar::Components::Bar
   def initialize(options = T.unsafe(nil)); end
 
   def length; end
-  def length=(_); end
+  def length=(_arg0); end
   def progress; end
-  def progress=(_); end
+  def progress=(_arg0); end
   def progress_mark; end
-  def progress_mark=(_); end
+  def progress_mark=(_arg0); end
   def remainder_mark; end
-  def remainder_mark=(_); end
+  def remainder_mark=(_arg0); end
   def to_s(options = T.unsafe(nil)); end
   def upa_steps; end
-  def upa_steps=(_); end
+  def upa_steps=(_arg0); end
 
   private
 
@@ -149,7 +149,7 @@ class ProgressBar::Components::Percentage
   def initialize(options = T.unsafe(nil)); end
 
   def progress; end
-  def progress=(_); end
+  def progress=(_arg0); end
 
   private
 
@@ -163,15 +163,15 @@ class ProgressBar::Components::Rate
   def initialize(options = T.unsafe(nil)); end
 
   def progress; end
-  def progress=(_); end
+  def progress=(_arg0); end
   def rate_scale; end
-  def rate_scale=(_); end
+  def rate_scale=(_arg0); end
   def started_at; end
-  def started_at=(_); end
+  def started_at=(_arg0); end
   def stopped_at; end
-  def stopped_at=(_); end
+  def stopped_at=(_arg0); end
   def timer; end
-  def timer=(_); end
+  def timer=(_arg0); end
 
   private
 
@@ -196,9 +196,9 @@ class ProgressBar::Components::Time
   def out_of_bounds_time_format; end
   def out_of_bounds_time_format=(format); end
   def progress; end
-  def progress=(_); end
+  def progress=(_arg0); end
   def timer; end
-  def timer=(_); end
+  def timer=(_arg0); end
 
   private
 
@@ -206,7 +206,6 @@ class ProgressBar::Components::Time
   def estimated; end
   def estimated_seconds_remaining; end
   def estimated_with_elapsed_fallback; end
-  def out_of_bounds_time; end
 end
 
 ProgressBar::Components::Time::ELAPSED_LABEL = T.let(T.unsafe(nil), String)
@@ -219,6 +218,8 @@ ProgressBar::Components::Time::OOB_FRIENDLY_TIME_TEXT = T.let(T.unsafe(nil), Str
 
 ProgressBar::Components::Time::OOB_LIMIT_IN_HOURS = T.let(T.unsafe(nil), Integer)
 
+ProgressBar::Components::Time::OOB_TEXT_TO_FORMAT = T.let(T.unsafe(nil), Hash)
+
 ProgressBar::Components::Time::OOB_TIME_FORMATS = T.let(T.unsafe(nil), Array)
 
 ProgressBar::Components::Time::OOB_UNKNOWN_TIME_TEXT = T.let(T.unsafe(nil), String)
@@ -229,7 +230,7 @@ class ProgressBar::Components::Title
   def initialize(options = T.unsafe(nil)); end
 
   def title; end
-  def title=(_); end
+  def title=(_arg0); end
 end
 
 ProgressBar::Components::Title::DEFAULT_TITLE = T.let(T.unsafe(nil), String)
@@ -249,10 +250,10 @@ class ProgressBar::Format::Molecule
   def bar_molecule?; end
   def full_key; end
   def key; end
-  def key=(_); end
+  def key=(_arg0); end
   def lookup_value(environment, length = T.unsafe(nil)); end
   def method_name; end
-  def method_name=(_); end
+  def method_name=(_arg0); end
   def non_bar_molecule?; end
 end
 
@@ -283,17 +284,17 @@ class ProgressBar::Output
   def log(string); end
   def refresh(options = T.unsafe(nil)); end
   def stream; end
-  def stream=(_); end
+  def stream=(_arg0); end
   def with_refresh; end
 
   protected
 
   def bar; end
-  def bar=(_); end
+  def bar=(_arg0); end
   def length_calculator; end
-  def length_calculator=(_); end
+  def length_calculator=(_arg0); end
   def throttle; end
-  def throttle=(_); end
+  def throttle=(_arg0); end
 
   private
 
@@ -315,12 +316,12 @@ class ProgressBar::Outputs::NonTty < ::ProgressBar::Output
   def default_format; end
   def eol; end
   def last_update_length; end
-  def refresh_with_format_change(*_); end
+  def refresh_with_format_change(*_arg0); end
-  def resolve_format(*_); end
+  def resolve_format(*_arg0); end
 
   protected
 
-  def last_update_length=(_); end
+  def last_update_length=(_arg0); end
 end
 
 ProgressBar::Outputs::NonTty::DEFAULT_FORMAT_STRING = T.let(T.unsafe(nil), String)
@@ -351,12 +352,12 @@ class ProgressBar::Progress
   def progress=(new_progress); end
   def reset; end
   def running_average; end
-  def running_average=(_); end
+  def running_average=(_arg0); end
   def smoothing; end
-  def smoothing=(_); end
+  def smoothing=(_arg0); end
   def start(options = T.unsafe(nil)); end
   def starting_position; end
-  def starting_position=(_); end
+  def starting_position=(_arg0); end
   def total; end
   def total=(new_total); end
   def total_with_unknown_indicator; end
@@ -380,13 +381,13 @@ class ProgressBar::Throttle
 
   def choke(options = T.unsafe(nil)); end
   def rate; end
-  def rate=(_); end
+  def rate=(_arg0); end
   def started_at; end
-  def started_at=(_); end
+  def started_at=(_arg0); end
   def stopped_at; end
-  def stopped_at=(_); end
+  def stopped_at=(_arg0); end
   def timer; end
-  def timer=(_); end
+  def timer=(_arg0); end
 end
 
 class ProgressBar::Time
@@ -398,7 +399,7 @@ class ProgressBar::Time
   protected
 
   def time; end
-  def time=(_); end
+  def time=(_arg0); end
 end
 
 ProgressBar::Time::TIME_MOCKING_LIBRARY_METHODS = T.let(T.unsafe(nil), Array)
@@ -417,14 +418,14 @@ class ProgressBar::Timer
   def start; end
   def started?; end
   def started_at; end
-  def started_at=(_); end
+  def started_at=(_arg0); end
   def stop; end
   def stopped?; end
   def stopped_at; end
-  def stopped_at=(_); end
+  def stopped_at=(_arg0); end
 
   protected
 
   def time; end
-  def time=(_); end
+  def time=(_arg0); end
 end

Library/Homebrew/vendor/bundle/bundler/setup.rb

@@ -73,10 +73,10 @@ $:.unshift "#{path}/../#{ruby_engine}/#{ruby_version}/gems/sorbet-0.5.6189/lib"
 $:.unshift "#{path}/../#{ruby_engine}/#{ruby_version}/gems/rspec-sorbet-1.8.0/lib"
 $:.unshift "#{path}/../#{ruby_engine}/#{ruby_version}/gems/rspec-wait-0.0.9/lib"
 $:.unshift "#{path}/../#{ruby_engine}/#{ruby_version}/gems/rubocop-ast-1.3.0/lib"
-$:.unshift "#{path}/../#{ruby_engine}/#{ruby_version}/gems/ruby-progressbar-1.10.1/lib"
+$:.unshift "#{path}/../#{ruby_engine}/#{ruby_version}/gems/ruby-progressbar-1.11.0/lib"
 $:.unshift "#{path}/../#{ruby_engine}/#{ruby_version}/gems/unicode-display_width-1.7.0/lib"
 $:.unshift "#{path}/../#{ruby_engine}/#{ruby_version}/gems/rubocop-1.7.0/lib"
-$:.unshift "#{path}/../#{ruby_engine}/#{ruby_version}/gems/rubocop-performance-1.9.1/lib"
+$:.unshift "#{path}/../#{ruby_engine}/#{ruby_version}/gems/rubocop-performance-1.9.2/lib"
 $:.unshift "#{path}/../#{ruby_engine}/#{ruby_version}/gems/rubocop-rails-2.9.1/lib"
 $:.unshift "#{path}/../#{ruby_engine}/#{ruby_version}/gems/rubocop-rspec-2.1.0/lib"
 $:.unshift "#{path}/../#{ruby_engine}/#{ruby_version}/gems/rubocop-sorbet-0.5.1/lib"

Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/rubocop-performance-1.9.2/lib/rubocop/cop/performance/reverse_each.rb

@@ -18,29 +18,25 @@ module RuboCop
 
         MSG = 'Use `reverse_each` instead of `reverse.each`.'
         RESTRICT_ON_SEND = %i[each].freeze
-        UNDERSCORE = '_'
 
         def_node_matcher :reverse_each?, <<~MATCHER
-          (send $(send _ :reverse) :each)
+          (send (send _ :reverse) :each)
         MATCHER
 
         def on_send(node)
-          reverse_each?(node) do |receiver|
+          reverse_each?(node) do
-            location_of_reverse = receiver.loc.selector.begin_pos
+            range = offense_range(node)
-            end_location = node.loc.selector.end_pos
-
-            range = range_between(location_of_reverse, end_location)
 
             add_offense(range) do |corrector|
-              corrector.replace(replacement_range(node), UNDERSCORE)
+              corrector.replace(range, 'reverse_each')
             end
           end
         end
 
         private
 
-        def replacement_range(node)
+        def offense_range(node)
-          range_between(node.loc.dot.begin_pos, node.loc.selector.begin_pos)
+          range_between(node.children.first.loc.selector.begin_pos, node.loc.selector.end_pos)
         end
       end
     end

Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/rubocop-performance-1.9.2/lib/rubocop/performance/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Performance
     # This module holds the RuboCop Performance version information.
     module Version
-      STRING = '1.9.1'
+      STRING = '1.9.2'
 
       def self.document_version
         STRING.match('\d+\.\d+').to_s

Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/ruby-progressbar-1.10.1/lib/ruby-progressbar/version.rb

@@ -1,3 +0,0 @@
-class ProgressBar
-  VERSION = '1.10.1'.freeze
-end

Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/ruby-progressbar-1.11.0/lib/ruby-progressbar/base.rb

@@ -13,7 +13,7 @@ class   Base
                  :progress,
                  :total
 
-  def initialize(options = {})
+  def initialize(options = {}) # rubocop:disable Metrics/AbcSize
     self.autostart    = options.fetch(:autostart,  true)
     self.autofinish   = options.fetch(:autofinish, true)
     self.finished     = false
@@ -123,7 +123,7 @@ class   Base
     Format::Formatter.process(@format, output.length, self)
   end
 
-  # rubocop:disable Metrics/AbcSize, Metrics/LineLength
+  # rubocop:disable Metrics/AbcSize, Layout/LineLength
   def to_h
     {
       'output_stream'                       => output.__send__(:stream),
@@ -145,7 +145,7 @@ class   Base
       'finished?'                           => finished?
     }
   end
-  # rubocop:enable Metrics/AbcSize, Metrics/LineLength
+  # rubocop:enable Metrics/AbcSize, Layout/LineLength
 
   def inspect
     "#<ProgressBar:#{progress}/#{total || 'unknown'}>"

Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/ruby-progressbar-1.11.0/lib/ruby-progressbar/components/time.rb

@@ -12,6 +12,10 @@ class   Time
   NO_TIME_ELAPSED_TEXT   = '--:--:--'.freeze
   ESTIMATED_LABEL        = ' ETA'.freeze
   ELAPSED_LABEL          = 'Time'.freeze
+  OOB_TEXT_TO_FORMAT     = {
+    :unknown  => OOB_UNKNOWN_TIME_TEXT,
+    :friendly => OOB_FRIENDLY_TIME_TEXT
+  }.freeze
 
   def initialize(options = {})
     self.out_of_bounds_time_format = options[:out_of_bounds_time_format]
@@ -53,8 +57,7 @@ class   Time
 
   def out_of_bounds_time_format=(format)
     unless OOB_TIME_FORMATS.include? format
-      fail 'Invalid Out Of Bounds time format.  Valid formats are ' +
+      fail StandardError, "Invalid Out Of Bounds time format.  Valid formats are #{OOB_TIME_FORMATS.inspect}"
-        OOB_TIME_FORMATS.inspect
     end
 
     @out_of_bounds_time_format = format
@@ -70,7 +73,7 @@ class   Time
     hours, minutes, seconds = timer.divide_seconds(memo_estimated_seconds_remaining)
 
     if hours > OOB_LIMIT_IN_HOURS && out_of_bounds_time_format
-      out_of_bounds_time
+      OOB_TEXT_TO_FORMAT[out_of_bounds_time_format]
     else
       TIME_FORMAT % [hours, minutes, seconds]
     end
@@ -89,19 +92,10 @@ class   Time
   end
 
   def estimated_seconds_remaining
-    return if progress.unknown? || progress.none? || timer.stopped?
+    return if progress.unknown? || progress.none? || timer.stopped? || timer.reset?
 
     (timer.elapsed_seconds * (progress.total / progress.running_average - 1)).round
   end
-
-  def out_of_bounds_time
-    case out_of_bounds_time_format
-    when :unknown
-      OOB_UNKNOWN_TIME_TEXT
-    when :friendly
-      OOB_FRIENDLY_TIME_TEXT
-    end
-  end
 end
 end
 end

Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/ruby-progressbar-1.11.0/lib/ruby-progressbar/format/string.rb

@@ -29,7 +29,7 @@ class   String < ::String
                       end
 
                       molecules
-                    end
+                   end
   end
 end
 end

Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/ruby-progressbar-1.11.0/lib/ruby-progressbar/outputs/tty.rb

@@ -17,7 +17,7 @@ class   Tty < Output
   end
 
   def default_format
-    DEFAULT_FORMAT_STRING
+    ENV['RUBY_PROGRESS_BAR_FORMAT'] || DEFAULT_FORMAT_STRING
   end
 
   def resolve_format(other_format)

Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/ruby-progressbar-1.11.0/lib/ruby-progressbar/refinements/enumerator.rb

@@ -13,7 +13,7 @@ refine ::Enumerator do
       end
     end
 
-    return chain unless block_given?
+    return chain unless block
 
     chain.each(&block)
   end

Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/ruby-progressbar-1.11.0/lib/ruby-progressbar/version.rb

@@ -0,0 +1,3 @@
+class ProgressBar
+  VERSION = '1.11.0'.freeze
+end