Produce good error messages for bad tarballs

2012-08-22 09:33:10 -04:00 · 2012-08-22 09:33:10 -04:00 · 05991dd846
commit 05991dd846
parent d423519766
1 changed files with 6 additions and 2 deletions
--- a/Library/Homebrew/extend/pathname.rb
+++ b/Library/Homebrew/extend/pathname.rb
@ -189,8 +189,12 @@ class Pathname
    when /^\xFD7zXZ\x00/ then :xz
    when /^Rar!/         then :rar
    else
-      # Assume it is not an archive
-      nil
+      # This code so that bad-tarballs and zips produce good error messages
+      # when they don't unarchive properly.
+      case extname
+        when ".tar.gz", ".tgz", ".tar.bz2", ".tbz" then :tar
+        when ".zip" then :zip
+      end
    end
  end