Only consider latest rebuild

This commit is contained in:
Chris Wegrzyn 2021-04-30 07:07:55 -04:00
parent 4f4fb49481
commit 056c9bb37f
2 changed files with 12 additions and 12 deletions

View File

@ -334,9 +334,8 @@ module Homebrew
else else
ohai "Determining #{f.full_name} bottle rebuild..." ohai "Determining #{f.full_name} bottle rebuild..."
versions = FormulaVersions.new(f) versions = FormulaVersions.new(f)
rebuilds = versions.bottle_version_map("origin/master")[f.pkg_version] rebuilds = versions.most_recent_rebuild_for_pkg_version("origin/master", f.pkg_version)
rebuilds.pop if rebuilds.last.to_i.positive? rebuilds ? rebuilds.to_i + 1 : 0
rebuilds.empty? ? 0 : rebuilds.max.to_i + 1
end end
filename = Bottle::Filename.create(f, bottle_tag.to_sym, rebuild) filename = Bottle::Filename.create(f, bottle_tag.to_sym, rebuild)

View File

@ -30,7 +30,8 @@ class FormulaVersions
def rev_list(branch) def rev_list(branch)
repository.cd do repository.cd do
Utils.popen_read("git", "rev-list", "--abbrev-commit", "--remove-empty", branch, "--", entry_name) do |io| Utils.popen_read("git", "rev-list", "--abbrev-commit", "--remove-empty", "--first-parent", branch, "--",
entry_name) do |io|
yield io.readline.chomp until io.eof? yield io.readline.chomp until io.eof?
end end
end end
@ -57,21 +58,21 @@ class FormulaVersions
Homebrew.raise_deprecation_exceptions = false Homebrew.raise_deprecation_exceptions = false
end end
def bottle_version_map(branch) def most_recent_rebuild_for_pkg_version(branch, pkg_version)
map = Hash.new { |h, k| h[k] = [] }
versions_seen = 0
rev_list(branch) do |rev| rev_list(branch) do |rev|
formula_at_revision(rev) do |f| formula_at_revision(rev) do |f|
odebug "Considering #{rev}. #{f.pkg_version} (rebuild: #{f.bottle_specification.rebuild}"
bottle = f.bottle_specification bottle = f.bottle_specification
map[f.pkg_version] << bottle.rebuild unless bottle.checksums.empty? # If the version is older than the one we want, we've gone too far
versions_seen = (map.keys + [f.pkg_version]).uniq.length return if f.pkg_version < pkg_version
# If this revision has a rebuild number, we are done!
return bottle.rebuild if f.pkg_version == pkg_version && !bottle.checksums.empty?
end end
return map if versions_seen > MAX_VERSIONS_DEPTH
rescue MacOSVersionError => e rescue MacOSVersionError => e
odebug "#{e} in #{name} at revision #{rev}" odebug "#{e} in #{name} at revision #{rev}"
break break
end end
map nil
end end
end end