admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Add exception for veclibfort linking to Accelerate

Browse Source 
- veclibfort exists soley to wrap Apple's accelerate and provide BLAS/LAPACK
   access to Accelerate
 - Improve the help message for that audit to mention veclibfort
This commit is contained in:
Izaak Beekman 2019-05-14 11:07:32 -04:00
parent b52e23c3ff
commit 056a2d41fd
No known key found for this signature in database
GPG Key ID: A93CE70D8021BD0F
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Library/Homebrew/extend/os/mac/formula_cellar_checks.rb
View File

@ -51,6 +51,7 @@ module FormulaCellarChecks
def check_accelerate_framework_links def check_accelerate_framework_links
return unless @core_tap return unless @core_tap
return unless formula.prefix.directory? return unless formula.prefix.directory?
return if formula.name == "veclibfort" # veclibfort exists to wrap accelerate
keg = Keg.new(formula.prefix) keg = Keg.new(formula.prefix)
system_accelerate = keg.mach_o_files.select do |obj| system_accelerate = keg.mach_o_files.select do |obj|
@ -63,7 +64,8 @@ module FormulaCellarChecks
object files were linked against system Accelerate object files were linked against system Accelerate
These object files were linked against the outdated system Accelerate framework. These object files were linked against the outdated system Accelerate framework.
Core tap formulae should link against OpenBLAS instead. Core tap formulae should link against OpenBLAS instead.
Adding `depends_on "openblas"` to the formula may help. Removing `depends_on "veclibfort" and/or adding `depends_on "openblas"` to the
formula may help.
#{system_accelerate * "\n "} #{system_accelerate * "\n "}
EOS EOS
end end