From 0509eebda4c28557a08984f390dcb84c059e8f28 Mon Sep 17 00:00:00 2001 From: Max Eisner <4730112+max-ae@users.noreply.github.com> Date: Sun, 24 Jul 2022 23:07:49 +0200 Subject: [PATCH] fix: don't write binary param if base_name == binary/base_name --- Library/Homebrew/rubocops/lines.rb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Library/Homebrew/rubocops/lines.rb b/Library/Homebrew/rubocops/lines.rb index 0fe2672a05..4faf9d8092 100644 --- a/Library/Homebrew/rubocops/lines.rb +++ b/Library/Homebrew/rubocops/lines.rb @@ -442,7 +442,9 @@ module RuboCop replacement_args = %w[] replacement_args << "base_name: \"#{base_name}\"" unless base_name == @formula_name replacement_args << "shells: [:#{shell}]" - replacement_args << "binary: #{binary}" unless binary.to_s == "bin/\"#{@formula_name}\"" + if binary.to_s != "bin/\"#{@formula_name}\"" && binary.to_s != "bin/\"#{base_name}\"" + replacement_args << "binary: #{binary}" + end replacement_args << "cmd: \"#{cmd}\"" unless cmd == "completion" replacement_args << "shell_prefix: #{shell_prefix}" unless shell_prefix.nil?