admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Emit warning when no editor is set

Browse Source 
Closes Homebrew/homebrew#34647.
This commit is contained in:
Jack Nagel 2015-01-05 15:23:35 -05:00
parent dc16371e19
commit 04f600bb50
1 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
Library/Homebrew/utils.rb
View File

@ -208,17 +208,24 @@ end
def which_editor def which_editor
editor = ENV.values_at('HOMEBREW_EDITOR', 'VISUAL', 'EDITOR').compact.first editor = ENV.values_at('HOMEBREW_EDITOR', 'VISUAL', 'EDITOR').compact.first
# If an editor wasn't set, try to pick a sane default
return editor unless editor.nil? return editor unless editor.nil?
# Find Textmate # Find Textmate
return 'mate' if which "mate" editor = "mate" if which "mate"
# Find BBEdit / TextWrangler # Find BBEdit / TextWrangler
return 'edit' if which "edit" editor ||= "edit" if which "edit"
# Find vim # Find vim
return 'vim' if which "vim" editor ||= "vim" if which "vim"
# Default to standard vim # Default to standard vim
return '/usr/bin/vim' editor ||= "/usr/bin/vim"
opoo <<-EOS.undent
Using #{editor} because no editor was set in the environment.
This may change in the future, so we recommend setting EDITOR, VISUAL,
or HOMEBREW_EDITOR to your preferred text editor.
EOS
editor
end end
def exec_editor *args def exec_editor *args