admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

download_strategy: Add logging when a cached download is being ignored

Browse Source
This commit is contained in:
Bob Lail 2025-06-25 08:32:02 +01:00 committed by Mike McQuaid
parent 3495ea576c
commit 048f58123f
No known key found for this signature in database
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
Library/Homebrew/download_strategy.rb
View File

@ -482,10 +482,17 @@ class CurlDownloadStrategy < AbstractFileDownloadStrategy
# The cached location is no longer fresh if either: # The cached location is no longer fresh if either:
# - Last-Modified value is newer than the file's timestamp # - Last-Modified value is newer than the file's timestamp
# - Content-Length value is different than the file's size # - Content-Length value is different than the file's size
if cached_location_valid if cached_location_valid && last_modified && last_modified > cached_location.mtime
newer_last_modified = last_modified && last_modified > cached_location.mtime ohai "Ignoring #{cached_location}",
different_file_size = file_size&.nonzero? && file_size != cached_location.size "Cached modified time #{cached_location.mtime.iso8601} is before" \
cached_location_valid = !(newer_last_modified || different_file_size) "Last-Modified header: #{last_modified.iso8601}"
cached_location_valid = false
end
if cached_location_valid && file_size&.nonzero? && file_size != cached_location.size
ohai "Ignoring #{cached_location}",
"Cached size #{cached_location.size} differs from " \
"Content-Length header: #{file_size}"
cached_location_valid = false
end end
if cached_location_valid if cached_location_valid