From 04855ddd484389bc8292a4d82106185466a3eb89 Mon Sep 17 00:00:00 2001 From: Joshua Peek Date: Sat, 27 Mar 2010 15:02:21 -0500 Subject: [PATCH] fix github version parser with multidigit number Signed-off-by: Adam Vandenberg --- Library/Homebrew/extend/pathname.rb | 2 +- Library/Homebrew/test/test_versions.rb | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/Library/Homebrew/extend/pathname.rb b/Library/Homebrew/extend/pathname.rb index e2489a51b3..d4fa6d92ee 100644 --- a/Library/Homebrew/extend/pathname.rb +++ b/Library/Homebrew/extend/pathname.rb @@ -110,7 +110,7 @@ class Pathname # github tarballs are special # we only support numbered tagged downloads - %r[github.com/.*/tarball/v?((\d\.)+\d)$].match to_s + %r[github.com/.*/tarball/v?((\d\.)+\d+)$].match to_s return $1 if $1 # eg. boost_1_39_0 diff --git a/Library/Homebrew/test/test_versions.rb b/Library/Homebrew/test/test_versions.rb index 446b2c8ef8..3e55676f51 100644 --- a/Library/Homebrew/test/test_versions.rb +++ b/Library/Homebrew/test/test_versions.rb @@ -74,6 +74,11 @@ class VersionTests < Test::Unit::TestCase assert_equal '1.0.5', r.version end + def test_version_github_with_high_patch_number + r=MockFormula.new "http://github.com/lloyd/yajl/tarball/v1.2.34" + assert_equal '1.2.34', r.version + end + def test_yet_another_version r=MockFormula.new "http://example.com/mad-0.15.1b.tar.gz" assert_equal '0.15.1b', r.version