admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #8470 from dtrodrigues/sha-tag

Browse Source 
audit: don't allow both sha256 and tag/revision for formula
This commit is contained in:
Dustin Rodrigues 2020-08-26 07:58:49 -04:00 committed by GitHub
commit 04382c8d06
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
Library/Homebrew/rubocops/components_redundancy.rb
View File

@ -19,6 +19,19 @@ module RuboCop
STABLE_MSG = "`stable do` should not be present without a `head` or `devel` spec" STABLE_MSG = "`stable do` should not be present without a `head` or `devel` spec"
def audit_formula(_node, _class_node, _parent_class_node, body_node) def audit_formula(_node, _class_node, _parent_class_node, body_node)
urls = find_method_calls_by_name(body_node, :url)
urls.each do |url|
url.arguments.each do |arg|
next if arg.class != RuboCop::AST::HashNode
url_args = arg.keys.each.map(&:value)
if method_called?(body_node, :sha256) && url_args.include?(:tag) && url_args.include?(:revision)
problem "Do not use both sha256 and tag/revision."
end
end
end
stable_block = find_block(body_node, :stable) stable_block = find_block(body_node, :stable)
if stable_block if stable_block
[:url, :sha256, :mirror].each do |method_name| [:url, :sha256, :mirror].each do |method_name|