Deprecate made-up URL schemes
This deprecates URLs that begin with the following fake URL schemes: bzr:// cvs:// hg:// fossil:// svn+http:// Despite their appearance, they are not actually accepted by the corresponding tools. They exist only as hints to the download strategy detection code, and are stripped from the URL before the URL is handed off to the VCS program. This is not documented, and may lead one to believe it is a valid URL that can be used elsewhere, when it actually only works inside Homebrew. We have a better mechanism for specifying the download strategy that is straightforward and explicit: :using => :hg Recommend that instead. Closes Homebrew/homebrew#35114.
This commit is contained in:
parent
fff4b83a52
commit
0344d243e4
@ -623,6 +623,10 @@ class ResourceAuditor
|
||||
end
|
||||
|
||||
def audit_download_strategy
|
||||
if url =~ %r[^(cvs|bzr|hg|fossil)://] || url =~ %r[^(svn)\+http://]
|
||||
problem "Use of the #{$&} scheme is deprecated, pass `:using => :#{$1}` instead"
|
||||
end
|
||||
|
||||
return unless using
|
||||
|
||||
if using == :ssl3 || using == CurlSSL3DownloadStrategy
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user