admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #9097 from dtrodrigues/revision

Browse Source 
dev-cmd/audit: only go back in git history until revision or version changes
This commit is contained in:
Dustin Rodrigues 2020-11-10 07:24:34 -05:00 committed by GitHub
commit 03199d383c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Library/Homebrew/dev-cmd/audit.rb
View File

@ -928,6 +928,7 @@ module Homebrew
end end
break if previous_version && current_version != previous_version break if previous_version && current_version != previous_version
break if previous_revision && current_revision != previous_revision
end end
if current_version == previous_version && if current_version == previous_version &&

13
Library/Homebrew/test/dev-cmd/audit_spec.rb
View File

@ -746,6 +746,17 @@ module Homebrew
it { is_expected.to be_nil } it { is_expected.to be_nil }
end end
context "should not warn when revision from previous version matches current revision" do
before do
formula_gsub_origin_commit "foo-1.0.tar.gz", "foo-1.1.tar.gz"
formula_gsub_origin_commit "revision 2", "# no revision"
formula_gsub_origin_commit "# no revision", "revision 1"
formula_gsub_origin_commit "revision 1", "revision 2"
end
it { is_expected.to be_nil }
end
context "should only increment by 1 with an uncommitted version" do context "should only increment by 1 with an uncommitted version" do
before do before do
formula_gsub "foo-1.0.tar.gz", "foo-1.1.tar.gz" formula_gsub "foo-1.0.tar.gz", "foo-1.1.tar.gz"
@ -776,8 +787,8 @@ module Homebrew
context "should not decrease with a new version" do context "should not decrease with a new version" do
before do before do
formula_gsub_origin_commit "foo-1.0.tar.gz", "foo-1.1.tar.gz" formula_gsub_origin_commit "foo-1.0.tar.gz", "foo-1.1.tar.gz"
formula_gsub_origin_commit "version_scheme 1", ""
formula_gsub_origin_commit "revision 2", "" formula_gsub_origin_commit "revision 2", ""
formula_gsub_origin_commit "version_scheme 1", ""
end end
it { is_expected.to match("version_scheme should not decrease (from 1 to 0)") } it { is_expected.to match("version_scheme should not decrease (from 1 to 0)") }