add test for build.without --without-foo

This commit is contained in:
Gautham Goli 2017-08-14 02:32:29 +05:30
parent 3efba57cd9
commit 02a1406a2e
2 changed files with 30 additions and 6 deletions

View File

@ -297,12 +297,12 @@ module RuboCop
problem "Don't negate 'build.without?': use 'build.with?'" problem "Don't negate 'build.without?': use 'build.with?'"
end end
# find_instance_method_call(body_node, :build, :without?) do |m| find_instance_method_call(body_node, :build, :without?) do |m|
# arg = parameters(m).first arg = parameters(m).first
# next unless match = regex_match_group(arg, %r{-?-?without-(.*)}) next unless match = regex_match_group(arg, %r{-?-?without-(.*)})
# problem "Don't duplicate 'without': Use `build.without? \"#{match[1]}\"` to check for \"--without-#{match[1]}\"" problem "Don't duplicate 'without': Use `build.without? \"#{match[1]}\"` to check for \"--without-#{match[1]}\""
# end end
#
# find_instance_method_call(body_node, :build, :with?) do |m| # find_instance_method_call(body_node, :build, :with?) do |m|
# arg = parameters(m).first # arg = parameters(m).first
# next unless match = regex_match_group(arg, %r{-?-?with-(.*)}) # next unless match = regex_match_group(arg, %r{-?-?with-(.*)})

View File

@ -715,6 +715,30 @@ describe RuboCop::Cop::FormulaAudit::Miscellaneous do
expect_offense(expected, actual) expect_offense(expected, actual)
end end
end end
it "with negated build.with?" do
source = <<-EOS.undent
class Foo < Formula
desc "foo"
url 'http://example.com/foo-1.0.tgz'
def post_install
return if build.without? "--without-bar"
end
end
EOS
expected_offenses = [{ message: "Don't duplicate 'without': Use `build.without? \"bar\"` to check for \"--without-bar\"",
severity: :convention,
line: 5,
column: 30,
source: source }]
inspect_source(cop, source)
expected_offenses.zip(cop.offenses).each do |expected, actual|
expect_offense(expected, actual)
end
end
end end
def expect_offense(expected, actual) def expect_offense(expected, actual)
expect(actual.message).to eq(expected[:message]) expect(actual.message).to eq(expected[:message])