add test for build.without --without-foo
This commit is contained in:
parent
3efba57cd9
commit
02a1406a2e
@ -297,12 +297,12 @@ module RuboCop
|
||||
problem "Don't negate 'build.without?': use 'build.with?'"
|
||||
end
|
||||
|
||||
# find_instance_method_call(body_node, :build, :without?) do |m|
|
||||
# arg = parameters(m).first
|
||||
# next unless match = regex_match_group(arg, %r{-?-?without-(.*)})
|
||||
# problem "Don't duplicate 'without': Use `build.without? \"#{match[1]}\"` to check for \"--without-#{match[1]}\""
|
||||
# end
|
||||
#
|
||||
find_instance_method_call(body_node, :build, :without?) do |m|
|
||||
arg = parameters(m).first
|
||||
next unless match = regex_match_group(arg, %r{-?-?without-(.*)})
|
||||
problem "Don't duplicate 'without': Use `build.without? \"#{match[1]}\"` to check for \"--without-#{match[1]}\""
|
||||
end
|
||||
|
||||
# find_instance_method_call(body_node, :build, :with?) do |m|
|
||||
# arg = parameters(m).first
|
||||
# next unless match = regex_match_group(arg, %r{-?-?with-(.*)})
|
||||
|
||||
@ -715,6 +715,30 @@ describe RuboCop::Cop::FormulaAudit::Miscellaneous do
|
||||
expect_offense(expected, actual)
|
||||
end
|
||||
end
|
||||
|
||||
it "with negated build.with?" do
|
||||
source = <<-EOS.undent
|
||||
class Foo < Formula
|
||||
desc "foo"
|
||||
url 'http://example.com/foo-1.0.tgz'
|
||||
def post_install
|
||||
return if build.without? "--without-bar"
|
||||
end
|
||||
end
|
||||
EOS
|
||||
|
||||
expected_offenses = [{ message: "Don't duplicate 'without': Use `build.without? \"bar\"` to check for \"--without-bar\"",
|
||||
severity: :convention,
|
||||
line: 5,
|
||||
column: 30,
|
||||
source: source }]
|
||||
|
||||
inspect_source(cop, source)
|
||||
|
||||
expected_offenses.zip(cop.offenses).each do |expected, actual|
|
||||
expect_offense(expected, actual)
|
||||
end
|
||||
end
|
||||
end
|
||||
def expect_offense(expected, actual)
|
||||
expect(actual.message).to eq(expected[:message])
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user