From 02849cf3e7ecab5d09195cb598da3e7753e7bd1d Mon Sep 17 00:00:00 2001 From: Markus Reiter Date: Mon, 14 Dec 2020 10:34:14 +0100 Subject: [PATCH] Don't pass `nice_version` to block. --- Library/Homebrew/livecheck/strategy/sparkle.rb | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/Library/Homebrew/livecheck/strategy/sparkle.rb b/Library/Homebrew/livecheck/strategy/sparkle.rb index 48f52d1dab..dc17081e38 100644 --- a/Library/Homebrew/livecheck/strategy/sparkle.rb +++ b/Library/Homebrew/livecheck/strategy/sparkle.rb @@ -69,20 +69,21 @@ module Homebrew data = { title: (item > "title").first&.text, url: enclosure["url"], - version: short_version || version ? BundleVersion.new(short_version, version) : nil, + bundle_version: short_version || version ? BundleVersion.new(short_version, version) : nil, }.compact data unless data.empty? end.compact - item = items.max_by { |e| e[:version] } + item = items.max_by { |e| e[:bundle_version] } if item match = if block - item[:version] = item[:version]&.nice_version + item[:short_version] = item[:bundle_version]&.short_version + item[:version] = item[:bundle_version]&.version block.call(item).to_s else - item[:version]&.nice_version + item[:bundle_version]&.nice_version end match_data[:matches][match] = Version.new(match) if match