admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

diagnostic: fix autoconf check

Browse Source 
Xcode can only provide autotools if it is installed, thus check that
first. Skipping this check will try to compare a `nil` Xcode version to
4.3, the first version of Xcode to not provide autotools.

Fixes Homebrew/homebrew#48208.

Closes Homebrew/homebrew#48278.

Signed-off-by: Martin Afanasjew <martin@afanasjew.de>
This commit is contained in:
Martin Afanasjew 2016-01-20 05:46:23 +01:00
parent 4ffe25adc8
commit 026363e1ed
2 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Library/Homebrew/diagnostic.rb
View File

@ -1044,6 +1044,7 @@ module Homebrew
end end
def check_for_autoconf def check_for_autoconf
return unless MacOS::Xcode.installed?
return unless MacOS::Xcode.provides_autotools? return unless MacOS::Xcode.provides_autotools?
autoconf = which("autoconf") autoconf = which("autoconf")

1
Library/Homebrew/test/test_diagnostic.rb
View File

@ -205,6 +205,7 @@ class DiagnosticChecksTest < Homebrew::TestCase
end end
def test_check_for_autoconf def test_check_for_autoconf
MacOS::Xcode.stubs(:installed?).returns true
MacOS::Xcode.stubs(:provides_autotools?).returns true MacOS::Xcode.stubs(:provides_autotools?).returns true
mktmpdir do |path| mktmpdir do |path|
file = "#{path}/autoconf" file = "#{path}/autoconf"