admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #18737 from Homebrew/prefer-newest-xcode

Browse Source 
os/mac: prefer newest Xcode when searching using `mdfind`
This commit is contained in:
Carlo Cabrera 2024-11-08 23:13:29 +08:00 committed by GitHub
commit 025d1c7b3f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
Library/Homebrew/os/mac.rb
View File

@ -195,10 +195,15 @@ module OS
sig { params(ids: String).returns(T.nilable(Pathname)) }
def self.app_with_bundle_id(*ids)
path = mdfind(*ids)
.reject { |p| p.include?("/Backups.backupdb/") }
.first
Pathname.new(path) if path.present?
require "bundle_version"
paths = mdfind(*ids).filter_map do |bundle_path|
Pathname.new(bundle_path) if bundle_path.exclude?("/Backups.backupdb/")
end
return paths.first unless paths.all? { |bp| (bp/"Contents/Info.plist").exist? }
# Prefer newest one, if we can find it.
paths.max_by { |bundle_path| Homebrew::BundleVersion.from_info_plist(bundle_path/"Contents/Info.plist") }
end
sig { params(ids: String).returns(T::Array[String]) }