From 020d6e28438109849511d00dfb20383c1a8f5619 Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Wed, 11 Mar 2020 17:06:42 +0000 Subject: [PATCH] upgrade: suggest full_name when appropriate. Otherwise `brew install foo/bar/baz` when an older version of `baz` is installed will tell you to run `brew upgrade baz` which won't work. --- Library/Homebrew/cmd/install.rb | 2 +- Library/Homebrew/formula_installer.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Library/Homebrew/cmd/install.rb b/Library/Homebrew/cmd/install.rb index d964ca2741..7245c5690f 100644 --- a/Library/Homebrew/cmd/install.rb +++ b/Library/Homebrew/cmd/install.rb @@ -173,7 +173,7 @@ module Homebrew optlinked_version = Keg.for(f.opt_prefix).version onoe <<~EOS #{f.full_name} #{optlinked_version} is already installed - To upgrade to #{f.version}, run `brew upgrade #{f.name}` + To upgrade to #{f.version}, run `brew upgrade #{f.full_name}` EOS elsif args.only_dependencies? formulae << f diff --git a/Library/Homebrew/formula_installer.rb b/Library/Homebrew/formula_installer.rb index 509a0d82f4..d7fba9fd98 100644 --- a/Library/Homebrew/formula_installer.rb +++ b/Library/Homebrew/formula_installer.rb @@ -228,7 +228,7 @@ class FormulaInstaller EOS if formula.outdated? && !formula.head? message += <<~EOS - To upgrade to #{formula.pkg_version}, run `brew upgrade #{formula.name}`. + To upgrade to #{formula.pkg_version}, run `brew upgrade #{formula.full_name}`. EOS elsif only_deps? message = nil