Merge branch 'speed-up-cask-full-names' into add-casks-to-install-search

This commit is contained in:
apainintheneck 2022-12-14 00:01:57 -08:00
commit 0193caac2e
188 changed files with 1110 additions and 330 deletions

View File

@ -1,10 +1,15 @@
ARG version=22.04
# version is passed through by Docker.
# shellcheck disable=SC2154
FROM ubuntu:"${version}"
ARG DEBIAN_FRONTEND=noninteractive
# We don't want to manually pin versions, happy to use whatever
# Ubuntu thinks is best.
# hadolint ignore=DL3008
# shellcheck disable=SC2292
# /etc/lsb-release is checked inside the container and sets DISTRIB_RELEASE.
# shellcheck disable=SC1091,SC2154
RUN apt-get update \
&& apt-get install -y --no-install-recommends software-properties-common gnupg-agent \
&& add-apt-repository -y ppa:git-core/ppa \
@ -30,7 +35,7 @@ RUN apt-get update \
uuid-runtime \
tzdata \
jq \
&& if [ "$(. /etc/lsb-release; echo "${DISTRIB_RELEASE}" | cut -d. -f1)" -ge 18 ]; then apt-get install gpg; fi \
&& if [[ "$(. /etc/lsb-release; echo "${DISTRIB_RELEASE}" | cut -d. -f1)" -ge 18 ]]; then apt-get install gpg; fi \
&& apt-get remove --purge -y software-properties-common \
&& apt-get autoremove --purge -y \
&& rm -rf /var/lib/apt/lists/* \

View File

@ -55,16 +55,14 @@ FormulaAudit:
FormulaAuditStrict:
Enabled: true
Homebrew/MoveToExtendOS:
Exclude:
- "Homebrew/{extend,test,requirements}/**/*"
- "Taps/**/*"
- "Homebrew/os.rb"
# enable all Homebrew custom cops
Homebrew:
Enabled: true
# only used internally
Homebrew/MoveToExtendOS:
Enabled: false
# makes DSL usage ugly.
Layout/SpaceBeforeBrackets:
Exclude:

View File

@ -37,3 +37,10 @@ RSpec/MultipleMemoizedHelpers:
# Annoying to have these autoremoved.
RSpec/Focus:
AutoCorrect: false
# Gets confused on these tests for a `skip` DSL
RSpec/PendingWithoutReason:
Exclude:
- "**/dependency_expansion_spec.rb"
- "**/livecheck/skip_conditions_spec.rb"
- "**/livecheck_spec.rb"

View File

@ -2,6 +2,12 @@ inherit_from:
- ../.rubocop_rspec.yml
- .rubocop_todo.yml
Homebrew/MoveToExtendOS:
Enabled: true
Exclude:
- "{extend,test,requirements}/**/*"
- "os.rb"
# make rspec formatting more flexible
Layout/MultilineMethodCallIndentation:
Exclude:

View File

@ -120,7 +120,7 @@ GEM
rspec-its (1.3.0)
rspec-core (>= 3.0.0)
rspec-expectations (>= 3.0.0)
rspec-mocks (3.12.0)
rspec-mocks (3.12.1)
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.12.0)
rspec-retry (0.6.2)
@ -132,14 +132,14 @@ GEM
rspec (>= 3, < 4)
rspec_junit_formatter (0.6.0)
rspec-core (>= 2, < 4, != 2.12.0)
rubocop (1.35.1)
rubocop (1.40.0)
json (~> 2.3)
parallel (~> 1.10)
parser (>= 3.1.2.1)
rainbow (>= 2.2.2, < 4.0)
regexp_parser (>= 1.8, < 3.0)
rexml (>= 3.2.5, < 4.0)
rubocop-ast (>= 1.20.1, < 2.0)
rubocop-ast (>= 1.23.0, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 1.4.0, < 3.0)
rubocop-ast (1.24.0)
@ -151,7 +151,7 @@ GEM
activesupport (>= 4.2.0)
rack (>= 1.1)
rubocop (>= 1.33.0, < 2.0)
rubocop-rspec (2.15.0)
rubocop-rspec (2.16.0)
rubocop (~> 1.33)
rubocop-sorbet (0.6.11)
rubocop (>= 0.90.0)

View File

@ -508,7 +508,7 @@ else
message="Please update your system curl or set HOMEBREW_CURL_PATH to a newer version.
Minimum required version: ${HOMEBREW_MINIMUM_CURL_VERSION}
Your curl version: ${curl_name_and_version##* }
Your curl executable: $(type -p ${HOMEBREW_CURL})"
Your curl executable: $(type -p "${HOMEBREW_CURL}")"
if [[ -z ${HOMEBREW_CURL_PATH} ]]
then
@ -537,7 +537,7 @@ Your curl executable: $(type -p ${HOMEBREW_CURL})"
message="Please update your system Git or set HOMEBREW_GIT_PATH to a newer version.
Minimum required version: ${HOMEBREW_MINIMUM_GIT_VERSION}
Your Git version: ${major}.${minor}.${micro}.${build}
Your Git executable: $(unset git && type -p ${HOMEBREW_GIT})"
Your Git executable: $(unset git && type -p "${HOMEBREW_GIT}")"
if [[ -z ${HOMEBREW_GIT_PATH} ]]
then
HOMEBREW_FORCE_BREWED_GIT="1"

View File

@ -416,7 +416,7 @@ module Cask
add_error "cask token underscores should be replaced by hyphens" if cask.token.include? "_"
add_error "cask token should not contain double hyphens" if cask.token.include? "--"
if cask.token.match?(/[^a-z0-9\-]/)
if cask.token.match?(/[^a-z0-9-]/)
add_error "cask token should only contain lowercase alphanumeric characters and hyphens"
end

View File

@ -38,6 +38,16 @@ module Cask
end.compact
end
def self.full_names
Tap.flat_map do |tap|
next tap.cask_tokens.blank?
next tap.cask_tokens if tap.user == "Homebrew"
name = tap.name
tap.cask_tokens.map { |tok| "#{name}/#{tok}" }
end.flatten
end
def tap
return super if block_given? # Object#tap

View File

@ -200,7 +200,7 @@ module Homebrew
except: args.except,
spdx_license_data: spdx_license_data,
spdx_exception_data: spdx_exception_data,
style_offenses: style_offenses ? style_offenses.for_path(f.path) : nil,
style_offenses: style_offenses&.for_path(f.path),
display_cop_names: args.display_cop_names?,
}.compact

View File

@ -234,7 +234,7 @@ module Homebrew
system "/usr/bin/sudo", "--non-interactive", "/usr/sbin/purge"
end
def setup_tar_and_args!(args)
def setup_tar_and_args!(args, mtime)
# Without --only-json-tab bottles are never reproducible
default_tar_args = ["tar", [].freeze].freeze
return default_tar_args unless args.only_json_tab?
@ -242,7 +242,7 @@ module Homebrew
# Ensure tar is set up for reproducibility.
# https://reproducible-builds.org/docs/archives/
gnutar_args = [
"--format", "pax", "--owner", "0", "--group", "0", "--sort", "name",
"--format", "pax", "--owner", "0", "--group", "0", "--sort", "name", "--mtime=#{mtime}",
# Set exthdr names to exclude PID (for GNU tar <1.33). Also don't store atime and ctime.
"--pax-option", "globexthdr.name=/GlobalHead.%n,exthdr.name=%d/PaxHeaders/%f,delete=atime,delete=ctime"
].freeze
@ -409,28 +409,18 @@ module Homebrew
tab.write
end
keg.find do |file|
# Set the times for reproducible bottles.
if file.symlink?
# Need to make symlink permissions consistent on macOS and Linux
# TODO: Refactor and move to extend/os
File.lchmod 0777, file if OS.mac? # rubocop:disable Homebrew/MoveToExtendOS
File.lutime(tab.source_modified_time, tab.source_modified_time, file)
else
file.utime(tab.source_modified_time, tab.source_modified_time)
end
end
keg.consistent_reproducible_symlink_permissions!
cd cellar do
sudo_purge
# Tar then gzip for reproducible bottles.
tar, tar_args = setup_tar_and_args!(args)
tar_mtime = tab.source_modified_time.strftime("%Y-%m-%d %H:%M:%S")
tar, tar_args = setup_tar_and_args!(args, tar_mtime)
safe_system tar, "--create", "--numeric-owner",
*tar_args,
"--file", tar_path, "#{f.name}/#{f.pkg_version}"
sudo_purge
# Set more times for reproducible bottles.
tar_path.utime(tab.source_modified_time, tab.source_modified_time)
# Set filename as it affects the tarball checksum.
relocatable_tar_path = "#{f}-bottle.tar"
mv tar_path, relocatable_tar_path
# Use gzip, faster to compress than bzip2, faster to uncompress than bzip2

View File

@ -852,7 +852,7 @@ module Homebrew
.gsub("This is an unsupported configuration, likely to break in " \
"the future and leave your machine in an unknown state.", "")
.gsub("System Integrity Protection status: ", "")
.delete("\t\.")
.delete("\t.")
.capitalize
.strip
else

View File

@ -1,4 +1,4 @@
# typed: true
# typed: false
# frozen_string_literal: true
class Keg
@ -86,6 +86,8 @@ class Keg
end
end
undef prepare_debug_symbols
def prepare_debug_symbols
binary_executable_or_library_files.each do |file|
odebug "Extracting symbols #{file}"
@ -100,4 +102,14 @@ class Keg
EOS
end
end
undef consistent_reproducible_symlink_permissions!
# Needed to make symlink permissions consistent on macOS and Linux for
# reproducible bottles.
def consistent_reproducible_symlink_permissions!
find do |file|
File.lchmod 0777, file if file.symlink?
end
end
end

View File

@ -37,7 +37,7 @@ module Homebrew
results = cask_tokens.extend(Searchable)
.search(string_or_regex)
cask_names = Cask::Cask.all.map(&:full_name)
cask_names = Cask::Cask.full_names
results += DidYouMean::SpellChecker.new(dictionary: cask_names)
.correct(string_or_regex)

View File

@ -493,7 +493,7 @@ class FormulaInstaller
# stop installation from continuing.
opoo <<~EOS
#{formula}: #{e.message}
'conflicts_with \"#{c.name}\"' should be removed from #{formula.path.basename}.
'conflicts_with "#{c.name}"' should be removed from #{formula.path.basename}.
EOS
raise if Homebrew::EnvConfig.developer?

View File

@ -8,7 +8,6 @@ require "fileutils"
require "json"
require "json/add/exception"
require "ostruct"
require "pp"
require "forwardable"
# Only require "core_ext" here to ensure we're only requiring the minimum of

View File

@ -485,6 +485,8 @@ class Keg
def prepare_debug_symbols; end
def consistent_reproducible_symlink_permissions!; end
def remove_oldname_opt_record
return unless oldname_opt_record
return if oldname_opt_record.resolved_path != path

View File

@ -70,7 +70,7 @@ module Homebrew
regex_prefix = Regexp.escape(match[:prefix] || "").gsub("\\-", "-")
# Use `\.t` instead of specific tarball extensions (e.g. .tar.gz)
suffix = match[:suffix]&.sub(Strategy::TARBALL_EXTENSION_REGEX, "\.t")
suffix = match[:suffix]&.sub(Strategy::TARBALL_EXTENSION_REGEX, ".t")
regex_suffix = Regexp.escape(suffix || "").gsub("\\-", "-")
# Example directory regex: `%r{href=["']?v?(\d+(?:\.\d+)+)/}i`

View File

@ -74,7 +74,7 @@ module Homebrew
regex_prefix = Regexp.escape(T.must(match[:prefix])).gsub("\\-", "-")
# Use `\.t` instead of specific tarball extensions (e.g. .tar.gz)
suffix = T.must(match[:suffix]).sub(Strategy::TARBALL_EXTENSION_REGEX, "\.t")
suffix = T.must(match[:suffix]).sub(Strategy::TARBALL_EXTENSION_REGEX, ".t")
regex_suffix = Regexp.escape(suffix).gsub("\\-", "-")
# Example regexes:

View File

@ -60,7 +60,7 @@ module Homebrew
regex_prefix = Regexp.escape(T.must(match[:prefix])).gsub("\\-", "-")
# Use `\.t` instead of specific tarball extensions (e.g. .tar.gz)
suffix = T.must(match[:suffix]).sub(Strategy::TARBALL_EXTENSION_REGEX, "\.t")
suffix = T.must(match[:suffix]).sub(Strategy::TARBALL_EXTENSION_REGEX, ".t")
regex_suffix = Regexp.escape(suffix).gsub("\\-", "-")
# Example regex: `/href=.*?Brew[._-]v?(\d+(?:\.\d+)*)\.t/i`

View File

@ -65,7 +65,7 @@ module Homebrew
values[:url] = "https://pypi.org/project/#{T.must(match[:package_name]).gsub(/%20|_/, "-")}/#files"
# Use `\.t` instead of specific tarball extensions (e.g. .tar.gz)
suffix = T.must(match[:suffix]).sub(Strategy::TARBALL_EXTENSION_REGEX, "\.t")
suffix = T.must(match[:suffix]).sub(Strategy::TARBALL_EXTENSION_REGEX, ".t")
regex_suffix = Regexp.escape(suffix).gsub("\\-", "-")
# Example regex: `%r{href=.*?/packages.*?/example[._-]v?(\d+(?:\.\d+)*(?:[._-]post\d+)?)\.t}i`

View File

@ -643,13 +643,13 @@ module RuboCop
formula_path_strings(body_node, :prefix) do |p|
if (match = regex_match_group(p, %r{^(/share/(info|man))$}))
problem "\"\#\{prefix}#{match[1]}\" should be \"\#{#{match[2]}}\""
problem ['"#', "{prefix}", match[1], '" should be "#{', match[2], '}"'].join
end
if (match = regex_match_group(p, %r{^((/share/man/)(man[1-8]))}))
problem "\"\#\{prefix}#{match[1]}\" should be \"\#{#{match[3]}}\""
problem ['"#', "{prefix}", match[1], '" should be "#{', match[3], '}"'].join
end
if (match = regex_match_group(p, %r{^(/(bin|include|libexec|lib|sbin|share|Frameworks))}i))
problem "\"\#\{prefix}#{match[1]}\" should be \"\#{#{match[2].downcase}}\""
problem ['"#', "{prefix}", match[1], '" should be "#{', match[2].downcase, '}"'].join
end
end

View File

@ -3,6 +3,7 @@
require "active_support/core_ext/array/access"
require "rubocops/shared/helper_functions"
require "shellwords"
module RuboCop
module Cop

View File

@ -202,7 +202,7 @@ class Sandbox
def path_filter(path, type)
case type
when :regex then "regex \#\"#{path}\""
when :regex then "regex #\"#{path}\""
when :subpath then "subpath \"#{expand_realpath(Pathname.new(path))}\""
when :literal, nil then "literal \"#{expand_realpath(Pathname.new(path))}\""
end

View File

@ -752,8 +752,8 @@ class RSpec::Mocks::Matchers::HaveReceived
def exactly(*args); end
def failure_message; end
def failure_message_when_negated; end
def matcher_name; end
def matches?(subject, &block); end
def name; end
def once(*args); end
def ordered(*args); end
def setup_allowance(_subject, &_block); end
@ -803,8 +803,8 @@ class RSpec::Mocks::Matchers::Receive
def description; end
def does_not_match?(subject, &block); end
def exactly(*args, &block); end
def matcher_name; end
def matches?(subject, &block); end
def name; end
def never(*args, &block); end
def once(*args, &block); end
def ordered(*args, &block); end
@ -849,8 +849,8 @@ class RSpec::Mocks::Matchers::ReceiveMessageChain
def and_yield(*args, &block); end
def description; end
def does_not_match?(*_args); end
def matcher_name; end
def matches?(subject, &block); end
def name; end
def setup_allowance(subject, &block); end
def setup_any_instance_allowance(subject, &block); end
def setup_any_instance_expectation(subject, &block); end
@ -871,8 +871,8 @@ class RSpec::Mocks::Matchers::ReceiveMessages
def description; end
def does_not_match?(_subject); end
def matcher_name; end
def matches?(subject); end
def name; end
def setup_allowance(subject); end
def setup_any_instance_allowance(subject); end
def setup_any_instance_expectation(subject); end
@ -1031,6 +1031,7 @@ class RSpec::Mocks::MethodDouble
def usable_rspec_prepended_module; end
end
RSpec::Mocks::MethodDouble::FROZEN_ERROR_MSG = T.let(T.unsafe(nil), Regexp)
class RSpec::Mocks::MethodDouble::RSpecPrependedModule < ::Module; end
class RSpec::Mocks::MethodReference

View File

@ -83,6 +83,7 @@ class RuboCop::Cop::RSpec::Be < ::RuboCop::Cop::RSpec::Base
end
RuboCop::Cop::RSpec::Be::MSG = T.let(T.unsafe(nil), String)
RuboCop::Cop::RSpec::Be::RESTRICT_ON_SEND = T.let(T.unsafe(nil), Array)
class RuboCop::Cop::RSpec::BeEq < ::RuboCop::Cop::RSpec::Base
extend ::RuboCop::Cop::AutoCorrector
@ -131,7 +132,7 @@ RuboCop::Cop::RSpec::BeforeAfterAll::MSG = T.let(T.unsafe(nil), String)
RuboCop::Cop::RSpec::BeforeAfterAll::RESTRICT_ON_SEND = T.let(T.unsafe(nil), Array)
module RuboCop::Cop::RSpec::Capybara; end
class RuboCop::Cop::RSpec::Capybara::CurrentPathExpectation < ::RuboCop::Cop::RSpec::Base
class RuboCop::Cop::RSpec::Capybara::CurrentPathExpectation < ::RuboCop::Cop::Base
extend ::RuboCop::Cop::AutoCorrector
def as_is_matcher(param0 = T.unsafe(nil)); end
@ -172,7 +173,7 @@ end
RuboCop::Cop::RSpec::Capybara::FeatureMethods::MAP = T.let(T.unsafe(nil), Hash)
RuboCop::Cop::RSpec::Capybara::FeatureMethods::MSG = T.let(T.unsafe(nil), String)
class RuboCop::Cop::RSpec::Capybara::NegationMatcher < ::RuboCop::Cop::RSpec::Base
class RuboCop::Cop::RSpec::Capybara::NegationMatcher < ::RuboCop::Cop::Base
include ::RuboCop::Cop::ConfigurableEnforcedStyle
extend ::RuboCop::Cop::AutoCorrector
@ -195,7 +196,7 @@ RuboCop::Cop::RSpec::Capybara::NegationMatcher::NEGATIVE_MATCHERS = T.let(T.unsa
RuboCop::Cop::RSpec::Capybara::NegationMatcher::POSITIVE_MATCHERS = T.let(T.unsafe(nil), Set)
RuboCop::Cop::RSpec::Capybara::NegationMatcher::RESTRICT_ON_SEND = T.let(T.unsafe(nil), Set)
class RuboCop::Cop::RSpec::Capybara::SpecificActions < ::RuboCop::Cop::RSpec::Base
class RuboCop::Cop::RSpec::Capybara::SpecificActions < ::RuboCop::Cop::Base
def click_on_selector(param0 = T.unsafe(nil)); end
def on_send(node); end
@ -213,7 +214,7 @@ RuboCop::Cop::RSpec::Capybara::SpecificActions::MSG = T.let(T.unsafe(nil), Strin
RuboCop::Cop::RSpec::Capybara::SpecificActions::RESTRICT_ON_SEND = T.let(T.unsafe(nil), Array)
RuboCop::Cop::RSpec::Capybara::SpecificActions::SPECIFIC_ACTION = T.let(T.unsafe(nil), Hash)
class RuboCop::Cop::RSpec::Capybara::SpecificFinders < ::RuboCop::Cop::RSpec::Base
class RuboCop::Cop::RSpec::Capybara::SpecificFinders < ::RuboCop::Cop::Base
include ::RuboCop::Cop::RangeHelp
extend ::RuboCop::Cop::AutoCorrector
@ -235,9 +236,7 @@ end
RuboCop::Cop::RSpec::Capybara::SpecificFinders::MSG = T.let(T.unsafe(nil), String)
RuboCop::Cop::RSpec::Capybara::SpecificFinders::RESTRICT_ON_SEND = T.let(T.unsafe(nil), Array)
class RuboCop::Cop::RSpec::Capybara::SpecificMatcher < ::RuboCop::Cop::RSpec::Base
include ::RuboCop::Cop::RSpec::CapybaraHelp
class RuboCop::Cop::RSpec::Capybara::SpecificMatcher < ::RuboCop::Cop::Base
def first_argument(param0 = T.unsafe(nil)); end
def on_send(node); end
@ -252,7 +251,7 @@ RuboCop::Cop::RSpec::Capybara::SpecificMatcher::MSG = T.let(T.unsafe(nil), Strin
RuboCop::Cop::RSpec::Capybara::SpecificMatcher::RESTRICT_ON_SEND = T.let(T.unsafe(nil), Array)
RuboCop::Cop::RSpec::Capybara::SpecificMatcher::SPECIFIC_MATCHER = T.let(T.unsafe(nil), Hash)
class RuboCop::Cop::RSpec::Capybara::VisibilityMatcher < ::RuboCop::Cop::RSpec::Base
class RuboCop::Cop::RSpec::Capybara::VisibilityMatcher < ::RuboCop::Cop::Base
def on_send(node); end
def visible_false?(param0 = T.unsafe(nil)); end
def visible_true?(param0 = T.unsafe(nil)); end
@ -484,6 +483,22 @@ end
RuboCop::Cop::RSpec::Dialect::MSG = T.let(T.unsafe(nil), String)
class RuboCop::Cop::RSpec::DuplicatedMetadata < ::RuboCop::Cop::RSpec::Base
include ::RuboCop::Cop::RSpec::Metadata
include ::RuboCop::Cop::RangeHelp
extend ::RuboCop::Cop::AutoCorrector
def on_metadata(symbols, _pairs); end
private
def autocorrect(corrector, node); end
def duplicated?(node); end
def on_metadata_symbol(node); end
end
RuboCop::Cop::RSpec::DuplicatedMetadata::MSG = T.let(T.unsafe(nil), String)
class RuboCop::Cop::RSpec::EmptyExampleGroup < ::RuboCop::Cop::RSpec::Base
include ::RuboCop::Cop::RangeHelp
extend ::RuboCop::Cop::AutoCorrector
@ -521,11 +536,14 @@ class RuboCop::Cop::RSpec::EmptyLineAfterExample < ::RuboCop::Cop::RSpec::Base
include ::RuboCop::Cop::RSpec::EmptyLineSeparation
extend ::RuboCop::Cop::AutoCorrector
def on_block(node); end
private
def allow_consecutive_one_liners?; end
def allowed_one_liner?(node); end
def consecutive_one_liner?(node); end
def next_one_line_example?(node); end
def on_block(node); end
end
RuboCop::Cop::RSpec::EmptyLineAfterExample::MSG = T.let(T.unsafe(nil), String)
@ -676,6 +694,7 @@ end
RuboCop::Cop::RSpec::ExpectActual::COMPLEX_LITERALS = T.let(T.unsafe(nil), Array)
RuboCop::Cop::RSpec::ExpectActual::MSG = T.let(T.unsafe(nil), String)
RuboCop::Cop::RSpec::ExpectActual::RESTRICT_ON_SEND = T.let(T.unsafe(nil), Array)
RuboCop::Cop::RSpec::ExpectActual::SIMPLE_LITERALS = T.let(T.unsafe(nil), Array)
RuboCop::Cop::RSpec::ExpectActual::SUPPORTED_MATCHERS = T.let(T.unsafe(nil), Array)
@ -738,7 +757,7 @@ RuboCop::Cop::RSpec::ExplicitHelper::BUILT_IN_MATCHERS = T.let(T.unsafe(nil), Ar
RuboCop::Cop::RSpec::ExplicitHelper::MSG_EXPLICIT = T.let(T.unsafe(nil), String)
module RuboCop::Cop::RSpec::FactoryBot; end
class RuboCop::Cop::RSpec::FactoryBot::AttributeDefinedStatically < ::RuboCop::Cop::RSpec::Base
class RuboCop::Cop::RSpec::FactoryBot::AttributeDefinedStatically < ::RuboCop::Cop::Base
extend ::RuboCop::Cop::AutoCorrector
def association?(param0 = T.unsafe(nil)); end
@ -762,19 +781,19 @@ end
RuboCop::Cop::RSpec::FactoryBot::AttributeDefinedStatically::MSG = T.let(T.unsafe(nil), String)
class RuboCop::Cop::RSpec::FactoryBot::ConsistentParenthesesStyle < ::RuboCop::Cop::RSpec::Base
class RuboCop::Cop::RSpec::FactoryBot::ConsistentParenthesesStyle < ::RuboCop::Cop::Base
include ::RuboCop::Cop::ConfigurableEnforcedStyle
include ::RuboCop::RSpec::FactoryBot::Language
extend ::RuboCop::Cop::AutoCorrector
def ambiguous_without_parentheses?(node); end
def factory_call(param0 = T.unsafe(nil)); end
def on_send(node); end
def process_with_parentheses(node); end
def process_without_parentheses(node); end
private
def ambiguous_without_parentheses?(node); end
def process_with_parentheses(node); end
def process_without_parentheses(node); end
def remove_parentheses(corrector, node); end
class << self
@ -787,7 +806,7 @@ RuboCop::Cop::RSpec::FactoryBot::ConsistentParenthesesStyle::MSG_OMIT_PARENS = T
RuboCop::Cop::RSpec::FactoryBot::ConsistentParenthesesStyle::MSG_REQUIRE_PARENS = T.let(T.unsafe(nil), String)
RuboCop::Cop::RSpec::FactoryBot::ConsistentParenthesesStyle::RESTRICT_ON_SEND = T.let(T.unsafe(nil), Set)
class RuboCop::Cop::RSpec::FactoryBot::CreateList < ::RuboCop::Cop::RSpec::Base
class RuboCop::Cop::RSpec::FactoryBot::CreateList < ::RuboCop::Cop::Base
include ::RuboCop::Cop::ConfigurableEnforcedStyle
include ::RuboCop::RSpec::FactoryBot::Language
extend ::RuboCop::Cop::AutoCorrector
@ -845,11 +864,12 @@ class RuboCop::Cop::RSpec::FactoryBot::CreateList::TimesCorrector
private
def factory_call_block_source; end
def generate_n_times_block(node); end
def node; end
end
class RuboCop::Cop::RSpec::FactoryBot::FactoryClassName < ::RuboCop::Cop::RSpec::Base
class RuboCop::Cop::RSpec::FactoryBot::FactoryClassName < ::RuboCop::Cop::Base
extend ::RuboCop::Cop::AutoCorrector
def class_name(param0 = T.unsafe(nil)); end
@ -864,6 +884,25 @@ RuboCop::Cop::RSpec::FactoryBot::FactoryClassName::ALLOWED_CONSTANTS = T.let(T.u
RuboCop::Cop::RSpec::FactoryBot::FactoryClassName::MSG = T.let(T.unsafe(nil), String)
RuboCop::Cop::RSpec::FactoryBot::FactoryClassName::RESTRICT_ON_SEND = T.let(T.unsafe(nil), Array)
class RuboCop::Cop::RSpec::FactoryBot::FactoryNameStyle < ::RuboCop::Cop::Base
include ::RuboCop::Cop::ConfigurableEnforcedStyle
include ::RuboCop::RSpec::FactoryBot::Language
extend ::RuboCop::Cop::AutoCorrector
def factory_call(param0 = T.unsafe(nil)); end
def on_send(node); end
private
def offense_for_string_style?(name); end
def offense_for_symbol_style?(name); end
def register_offense(name, prefer); end
end
RuboCop::Cop::RSpec::FactoryBot::FactoryNameStyle::FACTORY_CALLS = T.let(T.unsafe(nil), Set)
RuboCop::Cop::RSpec::FactoryBot::FactoryNameStyle::MSG = T.let(T.unsafe(nil), String)
RuboCop::Cop::RSpec::FactoryBot::FactoryNameStyle::RESTRICT_ON_SEND = T.let(T.unsafe(nil), Set)
class RuboCop::Cop::RSpec::FactoryBot::SyntaxMethods < ::RuboCop::Cop::RSpec::Base
include ::RuboCop::Cop::RSpec::InsideExampleGroup
include ::RuboCop::Cop::RangeHelp
@ -1010,6 +1049,7 @@ end
RuboCop::Cop::RSpec::ImplicitExpect::ENFORCED_REPLACEMENTS = T.let(T.unsafe(nil), Hash)
RuboCop::Cop::RSpec::ImplicitExpect::MSG = T.let(T.unsafe(nil), String)
RuboCop::Cop::RSpec::ImplicitExpect::RESTRICT_ON_SEND = T.let(T.unsafe(nil), Array)
class RuboCop::Cop::RSpec::ImplicitSubject < ::RuboCop::Cop::RSpec::Base
include ::RuboCop::Cop::ConfigurableEnforcedStyle
@ -1132,12 +1172,12 @@ class RuboCop::Cop::RSpec::LeadingSubject < ::RuboCop::Cop::RSpec::Base
include ::RuboCop::Cop::RSpec::InsideExampleGroup
extend ::RuboCop::Cop::AutoCorrector
def check_previous_nodes(node); end
def on_block(node); end
private
def autocorrect(corrector, node, sibling); end
def check_previous_nodes(node); end
def offending?(node); end
def offending_node(node); end
def parent(node); end
@ -1230,8 +1270,21 @@ end
RuboCop::Cop::RSpec::MessageSpies::MSG_HAVE_RECEIVED = T.let(T.unsafe(nil), String)
RuboCop::Cop::RSpec::MessageSpies::MSG_RECEIVE = T.let(T.unsafe(nil), String)
RuboCop::Cop::RSpec::MessageSpies::RESTRICT_ON_SEND = T.let(T.unsafe(nil), Array)
RuboCop::Cop::RSpec::MessageSpies::SUPPORTED_STYLES = T.let(T.unsafe(nil), Array)
module RuboCop::Cop::RSpec::Metadata
include ::RuboCop::RSpec::Language
extend ::RuboCop::AST::NodePattern::Macros
def metadata_in_block(param0, param1); end
def on_block(node); end
def on_metadata(_symbols, _pairs); end
def on_numblock(node); end
def rspec_configure(param0 = T.unsafe(nil)); end
def rspec_metadata(param0 = T.unsafe(nil)); end
end
class RuboCop::Cop::RSpec::MissingExampleGroupArgument < ::RuboCop::Cop::RSpec::Base
def on_block(node); end
end
@ -1405,6 +1458,24 @@ end
RuboCop::Cop::RSpec::Pending::MSG = T.let(T.unsafe(nil), String)
class RuboCop::Cop::RSpec::PendingWithoutReason < ::RuboCop::Cop::RSpec::Base
def on_send(node); end
def pending_by_example_method?(param0 = T.unsafe(nil)); end
def pending_by_metadata_without_reason?(param0 = T.unsafe(nil)); end
def skipped_by_example_group_method?(param0 = T.unsafe(nil)); end
def skipped_by_example_method?(param0 = T.unsafe(nil)); end
def skipped_by_metadata_without_reason?(param0 = T.unsafe(nil)); end
private
def pending_by_pending_step_without_reason?(node); end
def pending_without_reason?(node); end
def skipped_by_skip_step_without_reason?(node); end
def skipped_without_reason?(node); end
end
RuboCop::Cop::RSpec::PendingWithoutReason::MSG = T.let(T.unsafe(nil), String)
class RuboCop::Cop::RSpec::PredicateMatcher < ::RuboCop::Cop::RSpec::Base
include ::RuboCop::Cop::ConfigurableEnforcedStyle
include ::RuboCop::Cop::RSpec::InflectedHelper
@ -1420,6 +1491,7 @@ class RuboCop::Cop::RSpec::PredicateMatcher < ::RuboCop::Cop::RSpec::Base
def block_loc(send_node); end
end
RuboCop::Cop::RSpec::PredicateMatcher::RESTRICT_ON_SEND = T.let(T.unsafe(nil), Array)
module RuboCop::Cop::RSpec::Rails; end
class RuboCop::Cop::RSpec::Rails::AvoidSetupHook < ::RuboCop::Cop::RSpec::Base
@ -1431,7 +1503,7 @@ end
RuboCop::Cop::RSpec::Rails::AvoidSetupHook::MSG = T.let(T.unsafe(nil), String)
class RuboCop::Cop::RSpec::Rails::HaveHttpStatus < ::RuboCop::Cop::RSpec::Base
class RuboCop::Cop::RSpec::Rails::HaveHttpStatus < ::RuboCop::Cop::Base
extend ::RuboCop::Cop::AutoCorrector
def match_status(param0 = T.unsafe(nil)); end
@ -1439,6 +1511,8 @@ class RuboCop::Cop::RSpec::Rails::HaveHttpStatus < ::RuboCop::Cop::RSpec::Base
end
RuboCop::Cop::RSpec::Rails::HaveHttpStatus::MSG = T.let(T.unsafe(nil), String)
RuboCop::Cop::RSpec::Rails::HaveHttpStatus::RESTRICT_ON_SEND = T.let(T.unsafe(nil), Set)
RuboCop::Cop::RSpec::Rails::HaveHttpStatus::RUNNERS = T.let(T.unsafe(nil), Set)
class RuboCop::Cop::RSpec::Rails::HttpStatus < ::RuboCop::Cop::RSpec::Base
include ::RuboCop::Cop::ConfigurableEnforcedStyle
@ -1679,8 +1753,11 @@ end
RuboCop::Cop::RSpec::ScatteredLet::MSG = T.let(T.unsafe(nil), String)
class RuboCop::Cop::RSpec::ScatteredSetup < ::RuboCop::Cop::RSpec::Base
def lines_msg(numbers); end
def on_block(node); end
private
def lines_msg(numbers); end
def repeated_hooks(node); end
end
@ -1755,19 +1832,15 @@ module RuboCop::Cop::RSpec::SkipOrPending
end
class RuboCop::Cop::RSpec::SortMetadata < ::RuboCop::Cop::RSpec::Base
include ::RuboCop::Cop::RSpec::Metadata
include ::RuboCop::Cop::RangeHelp
extend ::RuboCop::Cop::AutoCorrector
def metadata_in_block(param0, param1); end
def on_block(node); end
def on_numblock(node); end
def rspec_configure(param0 = T.unsafe(nil)); end
def rspec_metadata(param0 = T.unsafe(nil)); end
def on_metadata(symbols, pairs); end
private
def crime_scene(symbols, pairs); end
def investigate(symbols, pairs); end
def replacement(symbols, pairs); end
def sort_pairs(pairs); end
def sort_symbols(symbols); end
@ -1794,6 +1867,7 @@ class RuboCop::Cop::RSpec::StubbedMock < ::RuboCop::Cop::RSpec::Base
end
RuboCop::Cop::RSpec::StubbedMock::MSG = T.let(T.unsafe(nil), String)
RuboCop::Cop::RSpec::StubbedMock::RESTRICT_ON_SEND = T.let(T.unsafe(nil), Array)
class RuboCop::Cop::RSpec::SubjectDeclaration < ::RuboCop::Cop::RSpec::Base
def offensive_subject_declaration?(param0 = T.unsafe(nil)); end
@ -1840,10 +1914,13 @@ module RuboCop::Cop::RSpec::TopLevelGroup
end
class RuboCop::Cop::RSpec::UnspecifiedException < ::RuboCop::Cop::RSpec::Base
def block_with_args?(node); end
def empty_exception_matcher?(node); end
def empty_raise_error_or_exception(param0 = T.unsafe(nil)); end
def on_send(node); end
private
def block_with_args?(node); end
def empty_exception_matcher?(node); end
end
RuboCop::Cop::RSpec::UnspecifiedException::MSG = T.let(T.unsafe(nil), String)
@ -2174,7 +2251,7 @@ end
module RuboCop::RSpec::Language::Runners
class << self
def all(element); end
def all(element = T.unsafe(nil)); end
end
end

View File

@ -3287,9 +3287,13 @@ module CopHelper
def autocorrect_source_file(source); end
def configuration(); end
def inspect_source(source, file=T.unsafe(nil)); end
def parse_source(source, file=T.unsafe(nil)); end
def registry(); end
end
module CopHelper
@ -6776,6 +6780,7 @@ class RuboCop::AST::NodePattern::Parser
end
module RuboCop::AST::NodePattern::Sets
SET_ANY_EMPTY = ::T.let(nil, ::T.untyped)
SET_ARM_INTEL = ::T.let(nil, ::T.untyped)
SET_BASH_COMPLETION_ZSH_COMPLETION_FISH_COMPLETION = ::T.let(nil, ::T.untyped)
SET_BUILD_RECOMMENDED_TEST_OPTIONAL = ::T.let(nil, ::T.untyped)
@ -6784,7 +6789,9 @@ module RuboCop::AST::NodePattern::Sets
SET_MAC_LINUX = ::T.let(nil, ::T.untyped)
SET_ON_INTEL_ON_ARM = ::T.let(nil, ::T.untyped)
SET_OR_NEWER_OR_OLDER = ::T.let(nil, ::T.untyped)
SET_PRESENT_ANY_BLANK_EMPTY = ::T.let(nil, ::T.untyped)
SET_SYSTEM_SHELL_OUTPUT_PIPE_OUTPUT = ::T.let(nil, ::T.untyped)
SET_TO_TO_NOT_NOT_TO = ::T.let(nil, ::T.untyped)
SET_WITH_WITHOUT = ::T.let(nil, ::T.untyped)
SET____ETC_4 = ::T.let(nil, ::T.untyped)
end

View File

@ -37,7 +37,7 @@ describe Cask::Cmd::Reinstall, :cask do
==> Removing App '.*Caffeine.app'
==> Dispatching zap stanza
==> Trashing files:
.*org\.example\.caffeine\.plist
.*org.example.caffeine.plist
==> Removing all staged versions of Cask 'local-caffeine'
==> Installing Cask local-caffeine
==> Moving App 'Caffeine.app' to '.*Caffeine.app'

View File

@ -51,7 +51,7 @@ describe Homebrew::Livecheck do
livecheck do
url "https://formulae.brew.sh/api/formula/ruby.json"
regex(/"stable":"(\d+(?:\.\d+)+)"/i)
regex(/"stable":"(\d+(?:.\d+)+)"/i)
end
end
RUBY
@ -227,7 +227,7 @@ describe Homebrew::Livecheck do
livecheck do
url "https://formulae.brew.sh/api/formula/ruby.json"
regex(/"stable":"(\d+(?:\.\d+)+)"/i)
regex(/"stable":"(\d+(?:.\d+)+)"/i)
end
end
RUBY

View File

@ -17,14 +17,14 @@ describe RuboCop::Cop::Cask::Desc do
expect_offense <<~RUBY, "/homebrew-cask/Casks/foo.rb"
cask 'foo' do
desc 'A bar program'
^ Description shouldn\'t start with an article.
^ Description shouldn't start with an article.
end
RUBY
expect_offense <<~RUBY, "/homebrew-cask/Casks/foo.rb"
cask 'foo' do
desc 'The bar program'
^^^ Description shouldn\'t start with an article.
^^^ Description shouldn't start with an article.
end
RUBY
@ -46,28 +46,28 @@ describe RuboCop::Cop::Cask::Desc do
expect_offense <<~RUBY, "/homebrew-cask/Casks/foo.rb"
cask 'foobar' do
desc 'Foo-Bar program'
^^^^^^^ Description shouldn\'t start with the cask name.
^^^^^^^ Description shouldn't start with the cask name.
end
RUBY
expect_offense <<~RUBY, "/homebrew-cask/Casks/foo.rb"
cask 'foo-bar' do
desc 'Foo bar program'
^^^^^^^ Description shouldn\'t start with the cask name.
^^^^^^^ Description shouldn't start with the cask name.
end
RUBY
expect_offense <<~RUBY, "/homebrew-cask/Casks/foo.rb"
cask 'foo-bar' do
desc 'Foo-Bar program'
^^^^^^^ Description shouldn\'t start with the cask name.
^^^^^^^ Description shouldn't start with the cask name.
end
RUBY
expect_offense <<~RUBY, "/homebrew-cask/Casks/foo.rb"
cask 'foo-bar' do
desc 'Foo Bar'
^^^^^^^ Description shouldn\'t start with the cask name.
^^^^^^^ Description shouldn't start with the cask name.
end
RUBY
end
@ -76,28 +76,28 @@ describe RuboCop::Cop::Cask::Desc do
expect_offense <<~RUBY, "/homebrew-cask/Casks/foo.rb"
cask 'foo-bar' do
desc 'macOS status bar monitor'
^^^^^ Description shouldn\'t contain the platform.
^^^^^ Description shouldn't contain the platform.
end
RUBY
expect_offense <<~RUBY, "/homebrew-cask/Casks/foo.rb"
cask 'foo-bar' do
desc 'Toggles dark mode on Mac OS Mojave'
^^^^^^ Description shouldn\'t contain the platform.
^^^^^^ Description shouldn't contain the platform.
end
RUBY
expect_offense <<~RUBY, "/homebrew-cask/Casks/foo.rb"
cask 'foo-bar' do
desc 'Better input source switcher for OS X'
^^^^ Description shouldn\'t contain the platform.
^^^^ Description shouldn't contain the platform.
end
RUBY
expect_offense <<~RUBY, "/homebrew-cask/Casks/foo.rb"
cask 'foo-bar' do
desc 'Media Manager for Mac OS X'
^^^^^^^^ Description shouldn\'t contain the platform.
^^^^^^^^ Description shouldn't contain the platform.
end
RUBY
@ -110,7 +110,7 @@ describe RuboCop::Cop::Cask::Desc do
expect_offense <<~RUBY
cask 'foo' do
desc 'Application for managing macOS virtual machines on macOS'
^^^^^ Description shouldn\'t contain the platform.
^^^^^ Description shouldn't contain the platform.
end
RUBY

View File

@ -14,7 +14,7 @@ describe RuboCop::Cop::FormulaAudit::Caveats do
url "https://brew.sh/foo-1.0.tgz"
def caveats
"setuid"
^^^^^^^^ Don\'t recommend setuid in the caveats, suggest sudo instead.
^^^^^^^^ Don't recommend setuid in the caveats, suggest sudo instead.
end
end
RUBY

View File

@ -63,7 +63,7 @@ describe RuboCop::Cop::FormulaAudit::ComponentsOrder do
livecheck do
^^^^^^^^^^^^ `livecheck` (line 7) should be put before `bottle` (line 5)
url "https://brew.sh/foo/versions/"
regex(/href=.+?foo-(\d+(?:\.\d+)+)\.t/)
regex(/href=.+?foo-(\d+(?:.\d+)+).t/)
end
end
RUBY
@ -75,7 +75,7 @@ describe RuboCop::Cop::FormulaAudit::ComponentsOrder do
livecheck do
url "https://brew.sh/foo/versions/"
regex(/href=.+?foo-(\d+(?:\.\d+)+)\.t/)
regex(/href=.+?foo-(\d+(?:.\d+)+).t/)
end
bottle :unneeded

View File

@ -85,7 +85,7 @@ describe RuboCop::Cop::FormulaAudit::Desc do
class Foo < Formula
url 'https://brew.sh/foo-1.0.tgz'
desc 'An aardvark'
^^ Description shouldn\'t start with an article.
^^ Description shouldn't start with an article.
end
RUBY
@ -93,7 +93,7 @@ describe RuboCop::Cop::FormulaAudit::Desc do
class Foo < Formula
url 'https://brew.sh/foo-1.0.tgz'
desc 'The aardvark'
^^^ Description shouldn\'t start with an article.
^^^ Description shouldn't start with an article.
end
RUBY
end
@ -113,7 +113,7 @@ describe RuboCop::Cop::FormulaAudit::Desc do
class Foo < Formula
url 'https://brew.sh/foo-1.0.tgz'
desc 'Foo is a foobar'
^^^ Description shouldn\'t start with the formula name.
^^^ Description shouldn't start with the formula name.
end
RUBY
end

View File

@ -12,7 +12,7 @@ describe RuboCop::Cop::FormulaAudit::Lines do
class Foo < Formula
url 'https://brew.sh/foo-1.0.tgz'
depends_on :automake
^^^^^^^^^^^^^^^^^^^^ :automake is deprecated. Usage should be \"automake\".
^^^^^^^^^^^^^^^^^^^^ :automake is deprecated. Usage should be "automake".
end
RUBY
end
@ -22,7 +22,7 @@ describe RuboCop::Cop::FormulaAudit::Lines do
class Foo < Formula
url 'https://brew.sh/foo-1.0.tgz'
depends_on :autoconf
^^^^^^^^^^^^^^^^^^^^ :autoconf is deprecated. Usage should be \"autoconf\".
^^^^^^^^^^^^^^^^^^^^ :autoconf is deprecated. Usage should be "autoconf".
end
RUBY
end
@ -32,7 +32,7 @@ describe RuboCop::Cop::FormulaAudit::Lines do
class Foo < Formula
url 'https://brew.sh/foo-1.0.tgz'
depends_on :libtool
^^^^^^^^^^^^^^^^^^^ :libtool is deprecated. Usage should be \"libtool\".
^^^^^^^^^^^^^^^^^^^ :libtool is deprecated. Usage should be "libtool".
end
RUBY
end
@ -42,7 +42,7 @@ describe RuboCop::Cop::FormulaAudit::Lines do
class Foo < Formula
url 'https://brew.sh/foo-1.0.tgz'
depends_on :apr
^^^^^^^^^^^^^^^ :apr is deprecated. Usage should be \"apr-util\".
^^^^^^^^^^^^^^^ :apr is deprecated. Usage should be "apr-util".
end
RUBY
end

View File

@ -15,7 +15,7 @@ module RuboCop
class Foo < Formula
def install
system "foo bar"
^^^^^^^^^ Separate `system` commands into `\"foo\", \"bar\"`
^^^^^^^^^ Separate `system` commands into `"foo", "bar"`
end
end
RUBY
@ -34,7 +34,7 @@ module RuboCop
class Foo < Formula
def install
system "\#{bin}/foo bar"
^^^^^^^^^^^^^^^^ Separate `system` commands into `\"\#{bin}/foo\", \"bar\"`
^^^^^^^^^^^^^^^^ Separate `system` commands into `"\#{bin}/foo", "bar"`
end
end
RUBY
@ -83,7 +83,7 @@ module RuboCop
class Foo < Formula
def install
Utils.popen_read("foo bar")
^^^^^^^^^ Separate `Utils.popen_read` commands into `\"foo\", \"bar\"`
^^^^^^^^^ Separate `Utils.popen_read` commands into `"foo", "bar"`
end
end
RUBY
@ -102,7 +102,7 @@ module RuboCop
class Foo < Formula
def install
Utils.safe_popen_read("foo bar")
^^^^^^^^^ Separate `Utils.safe_popen_read` commands into `\"foo\", \"bar\"`
^^^^^^^^^ Separate `Utils.safe_popen_read` commands into `"foo", "bar"`
end
end
RUBY
@ -121,7 +121,7 @@ module RuboCop
class Foo < Formula
def install
Utils.popen_write("foo bar")
^^^^^^^^^ Separate `Utils.popen_write` commands into `\"foo\", \"bar\"`
^^^^^^^^^ Separate `Utils.popen_write` commands into `"foo", "bar"`
end
end
RUBY
@ -140,7 +140,7 @@ module RuboCop
class Foo < Formula
def install
Utils.safe_popen_write("foo bar")
^^^^^^^^^ Separate `Utils.safe_popen_write` commands into `\"foo\", \"bar\"`
^^^^^^^^^ Separate `Utils.safe_popen_write` commands into `"foo", "bar"`
end
end
RUBY
@ -159,7 +159,7 @@ module RuboCop
class Foo < Formula
def install
Utils.popen_read("\#{bin}/foo bar")
^^^^^^^^^^^^^^^^ Separate `Utils.popen_read` commands into `\"\#{bin}/foo\", \"bar\"`
^^^^^^^^^^^^^^^^ Separate `Utils.popen_read` commands into `"\#{bin}/foo", "bar"`
end
end
RUBY
@ -198,7 +198,7 @@ module RuboCop
class Foo < Formula
def install
Utils.popen_read({ "SHELL" => "bash"}, "foo bar")
^^^^^^^^^ Separate `Utils.popen_read` commands into `\"foo\", \"bar\"`
^^^^^^^^^ Separate `Utils.popen_read` commands into `"foo", "bar"`
end
end
RUBY
@ -222,7 +222,7 @@ module RuboCop
expect_offense(<<~RUBY)
fork do
exec "foo bar > output"
^^^^^^^^^^^^^^^^^^ Don\'t use shell metacharacters in `exec`. Implement the logic in Ruby instead, using methods like `$stdout.reopen`.
^^^^^^^^^^^^^^^^^^ Don't use shell metacharacters in `exec`. Implement the logic in Ruby instead, using methods like `$stdout.reopen`.
end
RUBY
end

View File

@ -13,7 +13,7 @@ describe RuboCop::Cop::FormulaAudit::Miscellaneous do
desc "foo"
url 'https://brew.sh/foo-1.0.tgz'
FileUtils.mv "hello"
^^^^^^^^^^^^^^^^^^^^ Don\'t need \'FileUtils.\' before mv
^^^^^^^^^^^^^^^^^^^^ Don't need 'FileUtils.' before mv
end
RUBY
end
@ -24,7 +24,7 @@ describe RuboCop::Cop::FormulaAudit::Miscellaneous do
desc "foo"
url 'https://brew.sh/foo-1.0.tgz'
inreplace "foo" do |longvar|
^^^^^^^^^^^^^^^^^^^^^^^^^^^^ \"inreplace <filenames> do |s|\" is preferred over \"|longvar|\".
^^^^^^^^^^^^^^^^^^^^^^^^^^^^ "inreplace <filenames> do |s|" is preferred over "|longvar|".
somerandomCall(longvar)
end
end
@ -275,7 +275,7 @@ describe RuboCop::Cop::FormulaAudit::Miscellaneous do
url 'https://brew.sh/foo-1.0.tgz'
def install
ENV["COMPILER_PATH"] = "/usr/bin/gcc"
^^^^^^^^^^^^^^ Use \"\#{ENV.cc}\" instead of hard-coding \"gcc\"
^^^^^^^^^^^^^^ Use "\#{ENV.cc}" instead of hard-coding "gcc"
end
end
RUBY
@ -339,7 +339,7 @@ describe RuboCop::Cop::FormulaAudit::Miscellaneous do
desc "foo"
url 'https://brew.sh/foo-1.0.tgz'
depends_on "lpeg" => :lua51
^^^^^^ lua modules should be vendored rather than use deprecated `depends_on \"lpeg\" => :lua51`
^^^^^^ lua modules should be vendored rather than use deprecated `depends_on "lpeg" => :lua51`
end
RUBY
end
@ -413,7 +413,7 @@ describe RuboCop::Cop::FormulaAudit::Miscellaneous do
desc "foo"
url 'https://brew.sh/foo-1.0.tgz'
needs :openmp
^^^^^^^^^^^^^ 'needs :openmp' should be replaced with 'depends_on \"gcc\"'
^^^^^^^^^^^^^ 'needs :openmp' should be replaced with 'depends_on "gcc"'
end
RUBY
end

View File

@ -110,7 +110,7 @@ describe RuboCop::Cop::FormulaAudit::OptionDeclarations do
url 'https://brew.sh/foo-1.0.tgz'
def post_install
return if build.without? "--without-bar"
^^^^^^^^^^^^^^^ Don't duplicate 'without': Use `build.without? \"bar\"` to check for \"--without-bar\"
^^^^^^^^^^^^^^^ Don't duplicate 'without': Use `build.without? "bar"` to check for "--without-bar"
end
end
RUBY
@ -123,7 +123,7 @@ describe RuboCop::Cop::FormulaAudit::OptionDeclarations do
url 'https://brew.sh/foo-1.0.tgz'
def post_install
return if build.with? "--with-bar"
^^^^^^^^^^^^ Don't duplicate 'with': Use `build.with? \"bar\"` to check for \"--with-bar\"
^^^^^^^^^^^^ Don't duplicate 'with': Use `build.with? "bar"` to check for "--with-bar"
end
end
RUBY

View File

@ -93,7 +93,7 @@ describe RuboCop::Cop::FormulaAudit::Text do
def install
system "xcodebuild", "foo", "bar"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ use \"xcodebuild *args\" instead of \"system 'xcodebuild', *args\"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ use "xcodebuild *args" instead of "system 'xcodebuild', *args"
end
end
RUBY
@ -107,7 +107,7 @@ describe RuboCop::Cop::FormulaAudit::Text do
def install
system "xcodebuild", "foo", "bar"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ use \"xcodebuild *args\" instead of \"system 'xcodebuild', *args\"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ use "xcodebuild *args" instead of "system 'xcodebuild', *args"
end
def plist
@ -152,7 +152,7 @@ describe RuboCop::Cop::FormulaAudit::Text do
def install
Formula.factory(name)
^^^^^^^^^^^^^^^^^^^^^ \"Formula.factory(name)\" is deprecated in favor of \"Formula[name]\"
^^^^^^^^^^^^^^^^^^^^^ "Formula.factory(name)" is deprecated in favor of "Formula[name]"
end
end
RUBY
@ -166,7 +166,7 @@ describe RuboCop::Cop::FormulaAudit::Text do
def install
system "dep", "ensure"
^^^^^^^^^^^^^^^^^^^^^^ use \"dep\", \"ensure\", \"-vendor-only\"
^^^^^^^^^^^^^^^^^^^^^^ use "dep", "ensure", "-vendor-only"
end
end
RUBY
@ -180,7 +180,7 @@ describe RuboCop::Cop::FormulaAudit::Text do
def install
system "cargo", "build"
^^^^^^^^^^^^^^^^^^^^^^^ use \"cargo\", \"install\", *std_cargo_args
^^^^^^^^^^^^^^^^^^^^^^^ use "cargo", "install", *std_cargo_args
end
end
RUBY

View File

@ -592,8 +592,8 @@ describe Homebrew::Service do
StandardInput=file:#{HOMEBREW_PREFIX}/var/in/beanstalkd
StandardOutput=append:#{HOMEBREW_PREFIX}/var/log/beanstalkd.log
StandardError=append:#{HOMEBREW_PREFIX}/var/log/beanstalkd.error.log
Environment=\"PATH=#{std_path}\"
Environment=\"FOO=BAR\"
Environment="PATH=#{std_path}"
Environment="FOO=BAR"
EOS
expect(unit).to eq(unit_expect.strip)
end

View File

@ -36,7 +36,7 @@ RSpec.shared_context "Homebrew Cask", :needs_macos do # rubocop:disable RSpec/Co
third_party_tap = Tap.fetch("third-party", "tap")
begin
Cask::Config::DEFAULT_DIRS_PATHNAMES.values.each(&:mkpath)
Cask::Config::DEFAULT_DIRS_PATHNAMES.each_value(&:mkpath)
Tap.default_cask_tap.tap do |tap|
FileUtils.mkdir_p tap.path.dirname

View File

@ -4,7 +4,7 @@
describe Tty do
describe "::strip_ansi" do
it "removes ANSI escape codes from a string" do
expect(described_class.strip_ansi("\033\[36;7mhello\033\[0m")).to eq("hello")
expect(described_class.strip_ansi("\033[36;7mhello\033[0m")).to eq("hello")
end
end

View File

@ -535,7 +535,7 @@ module GitHub
response = create_fork(tap_remote_repo, org: org)
# GitHub API responds immediately but fork takes a few seconds to be ready.
sleep 1 until check_fork_exists(tap_remote_repo, org: org)
remote_url = if system("git", "config", "--local", "--get-regexp", "remote\..*\.url", "git@github.com:.*")
remote_url = if system("git", "config", "--local", "--get-regexp", "remote..*.url", "git@github.com:.*")
response.fetch("ssh_url")
else
url = response.fetch("clone_url")

View File

@ -185,7 +185,10 @@ module GitHub
# This is a no-op if the user is opting out of using the GitHub API.
return block_given? ? yield({}) : {} if Homebrew::EnvConfig.no_github_api?
args = ["--header", "Accept: application/vnd.github+json", "--write-out", "\n%\{http_code}"]
# This is a Curl format token, not a Ruby one.
# rubocop:disable Style/FormatStringToken
args = ["--header", "Accept: application/vnd.github+json", "--write-out", "\n%{http_code}"]
# rubocop:enable Style/FormatStringToken
token = credentials
args += ["--header", "Authorization: token #{token}"] unless credentials_type == :none

View File

@ -220,9 +220,9 @@ module PyPI
pipgrip_output = Utils.popen_read(*command)
unless $CHILD_STATUS.success?
odie <<~EOS
Unable to determine dependencies for \"#{input_packages.join(" ")}\" because of a failure when running
Unable to determine dependencies for "#{input_packages.join(" ")}" because of a failure when running
`#{command.join(" ")}`.
Please update the resources for \"#{formula.name}\" manually.
Please update the resources for "#{formula.name}" manually.
EOS
end
@ -242,8 +242,8 @@ module PyPI
odie "Unable to resolve some dependencies. Please update the resources for \"#{formula.name}\" manually."
elsif url.blank? || checksum.blank?
odie <<~EOS
Unable to find the URL and/or sha256 for the \"#{name}\" resource.
Please update the resources for \"#{formula.name}\" manually.
Unable to find the URL and/or sha256 for the "#{name}" resource.
Please update the resources for "#{formula.name}" manually.
EOS
end

View File

@ -93,7 +93,7 @@ $:.unshift File.expand_path("#{__dir__}/../#{RUBY_ENGINE}/#{Gem.ruby_api_version
$:.unshift File.expand_path("#{__dir__}/../#{RUBY_ENGINE}/#{Gem.ruby_api_version}/gems/rspec-support-3.12.0/lib")
$:.unshift File.expand_path("#{__dir__}/../#{RUBY_ENGINE}/#{Gem.ruby_api_version}/gems/rspec-core-3.12.0/lib")
$:.unshift File.expand_path("#{__dir__}/../#{RUBY_ENGINE}/#{Gem.ruby_api_version}/gems/rspec-expectations-3.12.0/lib")
$:.unshift File.expand_path("#{__dir__}/../#{RUBY_ENGINE}/#{Gem.ruby_api_version}/gems/rspec-mocks-3.12.0/lib")
$:.unshift File.expand_path("#{__dir__}/../#{RUBY_ENGINE}/#{Gem.ruby_api_version}/gems/rspec-mocks-3.12.1/lib")
$:.unshift File.expand_path("#{__dir__}/../#{RUBY_ENGINE}/#{Gem.ruby_api_version}/gems/rspec-3.12.0/lib")
$:.unshift File.expand_path("#{__dir__}/../#{RUBY_ENGINE}/#{Gem.ruby_api_version}/gems/rspec-github-2.4.0/lib")
$:.unshift File.expand_path("#{__dir__}/../#{RUBY_ENGINE}/#{Gem.ruby_api_version}/gems/rspec-its-1.3.0/lib")
@ -104,10 +104,10 @@ $:.unshift File.expand_path("#{__dir__}/../#{RUBY_ENGINE}/#{Gem.ruby_api_version
$:.unshift File.expand_path("#{__dir__}/../#{RUBY_ENGINE}/#{Gem.ruby_api_version}/gems/rubocop-ast-1.24.0/lib")
$:.unshift File.expand_path("#{__dir__}/../#{RUBY_ENGINE}/#{Gem.ruby_api_version}/gems/ruby-progressbar-1.11.0/lib")
$:.unshift File.expand_path("#{__dir__}/../#{RUBY_ENGINE}/#{Gem.ruby_api_version}/gems/unicode-display_width-2.3.0/lib")
$:.unshift File.expand_path("#{__dir__}/../#{RUBY_ENGINE}/#{Gem.ruby_api_version}/gems/rubocop-1.35.1/lib")
$:.unshift File.expand_path("#{__dir__}/../#{RUBY_ENGINE}/#{Gem.ruby_api_version}/gems/rubocop-1.40.0/lib")
$:.unshift File.expand_path("#{__dir__}/../#{RUBY_ENGINE}/#{Gem.ruby_api_version}/gems/rubocop-performance-1.15.1/lib")
$:.unshift File.expand_path("#{__dir__}/../#{RUBY_ENGINE}/#{Gem.ruby_api_version}/gems/rubocop-rails-2.17.3/lib")
$:.unshift File.expand_path("#{__dir__}/../#{RUBY_ENGINE}/#{Gem.ruby_api_version}/gems/rubocop-rspec-2.15.0/lib")
$:.unshift File.expand_path("#{__dir__}/../#{RUBY_ENGINE}/#{Gem.ruby_api_version}/gems/rubocop-rspec-2.16.0/lib")
$:.unshift File.expand_path("#{__dir__}/../#{RUBY_ENGINE}/#{Gem.ruby_api_version}/gems/rubocop-sorbet-0.6.11/lib")
$:.unshift File.expand_path("#{__dir__}/../#{RUBY_ENGINE}/#{Gem.ruby_api_version}/gems/ruby-macho-3.0.0/lib")
$:.unshift File.expand_path("#{__dir__}/../#{RUBY_ENGINE}/#{Gem.ruby_api_version}/gems/simplecov-html-0.12.3/lib")

View File

@ -147,13 +147,17 @@ RSpec/Be:
RSpec/BeEq:
Description: Check for expectations where `be(...)` can replace `eq(...)`.
Enabled: pending
Safe: false
VersionAdded: 2.9.0
VersionChanged: '2.16'
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/BeEq
RSpec/BeEql:
Description: Check for expectations where `be(...)` can replace `eql(...)`.
Enabled: true
Safe: false
VersionAdded: '1.7'
VersionChanged: '2.16'
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/BeEql
RSpec/BeNil:
@ -284,6 +288,12 @@ RSpec/Dialect:
VersionAdded: '1.33'
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Dialect
RSpec/DuplicatedMetadata:
Description: Avoid duplicated metadata.
Enabled: pending
VersionAdded: '2.16'
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/DuplicatedMetadata
RSpec/EmptyExampleGroup:
Description: Checks if an example group does not include any tests.
Enabled: true
@ -356,12 +366,6 @@ RSpec/ExampleWithoutDescription:
VersionAdded: '1.22'
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExampleWithoutDescription
RSpec/ExcessiveDocstringSpacing:
Description: Checks for excessive whitespace in example descriptions.
Enabled: pending
VersionAdded: '2.5'
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExcessiveDocstringSpacing
RSpec/ExampleWording:
Description: Checks for common mistakes in example descriptions.
Enabled: true
@ -378,6 +382,12 @@ RSpec/ExampleWording:
StyleGuide: https://rspec.rubystyle.guide/#should-in-example-docstrings
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExampleWording
RSpec/ExcessiveDocstringSpacing:
Description: Checks for excessive whitespace in example descriptions.
Enabled: pending
VersionAdded: '2.5'
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExcessiveDocstringSpacing
RSpec/ExpectActual:
Description: Checks for `expect(...)` calls containing literal values.
Enabled: true
@ -664,6 +674,12 @@ RSpec/Pending:
VersionAdded: '1.25'
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Pending
RSpec/PendingWithoutReason:
Description: Checks for pending or skipped examples without reason.
Enabled: pending
VersionAdded: '2.16'
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/PendingWithoutReason
RSpec/PredicateMatcher:
Description: Prefer using predicate matcher over using predicate method directly.
Enabled: true
@ -960,6 +976,16 @@ RSpec/FactoryBot/FactoryClassName:
VersionChanged: '2.0'
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/FactoryBot/FactoryClassName
RSpec/FactoryBot/FactoryNameStyle:
Description: Checks for name style for argument of FactoryBot::Syntax::Methods.
Enabled: pending
VersionAdded: '2.16'
EnforcedStyle: symbol
SupportedStyles:
- symbol
- string
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/FactoryBot/FactoryNameStyle
RSpec/FactoryBot/SyntaxMethods:
Description: Use shorthands from `FactoryBot::Syntax::Methods` in your specs.
Enabled: pending
@ -985,6 +1011,17 @@ RSpec/Rails/HaveHttpStatus:
VersionAdded: '2.12'
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Rails/HaveHttpStatus
RSpec/Rails/HttpStatus:
Description: Enforces use of symbolic or numeric value to describe HTTP status.
Enabled: true
EnforcedStyle: symbolic
SupportedStyles:
- numeric
- symbolic
VersionAdded: '1.23'
VersionChanged: '2.0'
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Rails/HttpStatus
RSpec/Rails/InferredSpecType:
Description: Identifies redundant spec type.
Enabled: pending
@ -1007,14 +1044,3 @@ RSpec/Rails/InferredSpecType:
routing: routing
system: system
views: view
RSpec/Rails/HttpStatus:
Description: Enforces use of symbolic or numeric value to describe HTTP status.
Enabled: true
EnforcedStyle: symbolic
SupportedStyles:
- numeric
- symbolic
VersionAdded: '1.23'
VersionChanged: '2.0'
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Rails/HttpStatus

View File

@ -6,34 +6,39 @@ require 'yaml'
require 'rubocop'
require_relative 'rubocop/rspec'
require_relative 'rubocop/rspec/version'
require_relative 'rubocop/rspec/inject'
require_relative 'rubocop/rspec/node'
require_relative 'rubocop/rspec/wording'
require_relative 'rubocop/rspec/language/node_pattern'
require_relative 'rubocop/rspec/node'
require_relative 'rubocop/rspec/version'
require_relative 'rubocop/rspec/wording'
# Dependent on `RuboCop::RSpec::Language::NodePattern`.
require_relative 'rubocop/rspec/language'
require_relative 'rubocop/rspec/factory_bot/language'
require_relative 'rubocop/cop/rspec/mixin/capybara_help'
require_relative 'rubocop/cop/rspec/mixin/css_selector'
require_relative 'rubocop/cop/rspec/mixin/final_end_location'
require_relative 'rubocop/cop/rspec/mixin/inside_example_group'
require_relative 'rubocop/cop/rspec/mixin/metadata'
require_relative 'rubocop/cop/rspec/mixin/namespace'
require_relative 'rubocop/cop/rspec/mixin/skip_or_pending'
require_relative 'rubocop/cop/rspec/mixin/top_level_group'
require_relative 'rubocop/cop/rspec/mixin/variable'
require_relative 'rubocop/cop/rspec/mixin/final_end_location'
# Dependent on `RuboCop::Cop::RSpec::FinalEndLocation`.
require_relative 'rubocop/cop/rspec/mixin/comments_help'
require_relative 'rubocop/cop/rspec/mixin/empty_line_separation'
require_relative 'rubocop/cop/rspec/mixin/inside_example_group'
require_relative 'rubocop/cop/rspec/mixin/namespace'
require_relative 'rubocop/cop/rspec/mixin/css_selector'
require_relative 'rubocop/cop/rspec/mixin/skip_or_pending'
require_relative 'rubocop/cop/rspec/mixin/capybara_help'
require_relative 'rubocop/rspec/concept'
require_relative 'rubocop/rspec/example_group'
require_relative 'rubocop/rspec/example'
require_relative 'rubocop/rspec/hook'
require_relative 'rubocop/cop/rspec/base'
require_relative 'rubocop/rspec/align_let_brace'
require_relative 'rubocop/rspec/factory_bot'
require_relative 'rubocop/rspec/concept'
require_relative 'rubocop/rspec/corrector/move_node'
require_relative 'rubocop/rspec/example'
require_relative 'rubocop/rspec/example_group'
require_relative 'rubocop/rspec/factory_bot'
require_relative 'rubocop/rspec/hook'
RuboCop::RSpec::Inject.defaults!

View File

@ -21,6 +21,8 @@ module RuboCop
class Be < Base
MSG = "Don't use `be` without an argument."
RESTRICT_ON_SEND = Runners.all
# @!method be_without_args(node)
def_node_matcher :be_without_args, <<-PATTERN
(send _ #Runners.all $(send nil? :be))

View File

@ -9,6 +9,9 @@ module RuboCop
# using `==`. Booleans and nil can be compared by identity and therefore
# the `be` matcher is preferable as it is a more strict test.
#
# @safety
# This cop is unsafe because it changes how values are compared.
#
# @example
# # bad
# expect(foo).to eq(true)

View File

@ -10,6 +10,9 @@ module RuboCop
# can be compared by identity and therefore the `be` matcher is
# preferable as it is a more strict test.
#
# @safety
# This cop is unsafe because it changes how values are compared.
#
# @example
# # bad
# expect(foo).to eql(1)

View File

@ -29,7 +29,7 @@ module RuboCop
# # good
# expect(page).to have_current_path('/callback')
#
class CurrentPathExpectation < Base
class CurrentPathExpectation < ::RuboCop::Cop::Base
extend AutoCorrector
MSG = 'Do not set an RSpec expectation on `current_path` in ' \
@ -47,14 +47,14 @@ module RuboCop
# @!method as_is_matcher(node)
def_node_matcher :as_is_matcher, <<-PATTERN
(send
#expectation_set_on_current_path $#Runners.all
#expectation_set_on_current_path ${:to :to_not :not_to}
${(send nil? :eq ...) (send nil? :match (regexp ...))})
PATTERN
# @!method regexp_str_matcher(node)
def_node_matcher :regexp_str_matcher, <<-PATTERN
(send
#expectation_set_on_current_path $#Runners.all
#expectation_set_on_current_path ${:to :to_not :not_to}
$(send nil? :match (str $_)))
PATTERN

View File

@ -24,7 +24,7 @@ module RuboCop
# expect(page).to have_no_selector
# expect(page).to have_no_css('a')
#
class NegationMatcher < Base
class NegationMatcher < ::RuboCop::Cop::Base
extend AutoCorrector
include ConfigurableEnforcedStyle

View File

@ -20,7 +20,7 @@ module RuboCop
# click_link(exact_text: 'foo')
# find('div').click_button
#
class SpecificActions < Base
class SpecificActions < ::RuboCop::Cop::Base
MSG = "Prefer `%<good_action>s` over `find('%<selector>s').click`."
RESTRICT_ON_SEND = %i[click].freeze
SPECIFIC_ACTION = {

View File

@ -15,7 +15,7 @@ module RuboCop
# find_by_id('some-id')
# find_by_id('some-id', visible: true)
#
class SpecificFinders < Base
class SpecificFinders < ::RuboCop::Cop::Base
extend AutoCorrector
include RangeHelp

View File

@ -26,9 +26,7 @@ module RuboCop
# expect(page).to have_select
# expect(page).to have_field('foo')
#
class SpecificMatcher < Base
include CapybaraHelp
class SpecificMatcher < ::RuboCop::Cop::Base
MSG = 'Prefer `%<good_matcher>s` over `%<bad_matcher>s`.'
RESTRICT_ON_SEND = %i[have_selector have_no_selector have_css
have_no_css].freeze
@ -49,8 +47,8 @@ module RuboCop
first_argument(node) do |arg|
next unless (matcher = specific_matcher(arg))
next if CssSelector.multiple_selectors?(arg)
next unless specific_option?(node, arg, matcher)
next unless specific_pseudo_classes?(arg)
next unless CapybaraHelp.specific_option?(node, arg, matcher)
next unless CapybaraHelp.specific_pseudo_classes?(arg)
add_offense(node, message: message(node, matcher))
end

View File

@ -26,7 +26,7 @@ module RuboCop
# expect(page).to have_css('.foo', visible: :all)
# expect(page).to have_link('my link', visible: :hidden)
#
class VisibilityMatcher < Base
class VisibilityMatcher < ::RuboCop::Cop::Base
MSG_FALSE = 'Use `:all` or `:hidden` instead of `false`.'
MSG_TRUE = 'Use `:visible` instead of `true`.'
CAPYBARA_MATCHER_METHODS = %w[

View File

@ -0,0 +1,58 @@
# frozen_string_literal: true
module RuboCop
module Cop
module RSpec
# Avoid duplicated metadata.
#
# @example
# # bad
# describe 'Something', :a, :a
#
# # good
# describe 'Something', :a
class DuplicatedMetadata < Base
extend AutoCorrector
include Metadata
include RangeHelp
MSG = 'Avoid duplicated metadata.'
def on_metadata(symbols, _pairs)
symbols.each do |symbol|
on_metadata_symbol(symbol)
end
end
private
def on_metadata_symbol(node)
return unless duplicated?(node)
add_offense(node) do |corrector|
autocorrect(corrector, node)
end
end
def autocorrect(corrector, node)
corrector.remove(
range_with_surrounding_comma(
range_with_surrounding_space(
node.location.expression,
side: :left
),
:left
)
)
end
def duplicated?(node)
node.left_siblings.any? do |sibling|
sibling.eql?(node)
end
end
end
end
end
end

View File

@ -55,6 +55,8 @@ module RuboCop
end
end
private
def allowed_one_liner?(node)
consecutive_one_liner?(node) && allow_consecutive_one_liners?
end

View File

@ -26,6 +26,8 @@ module RuboCop
MSG = 'Provide the actual you are testing to `expect(...)`.'
RESTRICT_ON_SEND = Runners.all
SIMPLE_LITERALS = %i[
true
false

View File

@ -25,7 +25,7 @@ module RuboCop
# # good
# count { 1 }
#
class AttributeDefinedStatically < Base
class AttributeDefinedStatically < ::RuboCop::Cop::Base
extend AutoCorrector
MSG = 'Use a block to declare attribute values.'

View File

@ -40,7 +40,7 @@ module RuboCop
# name: 'foo'
# )
#
class ConsistentParenthesesStyle < Base
class ConsistentParenthesesStyle < ::RuboCop::Cop::Base
extend AutoCorrector
include ConfigurableEnforcedStyle
include RuboCop::RSpec::FactoryBot::Language
@ -69,6 +69,8 @@ module RuboCop
return if ambiguous_without_parentheses?(node)
factory_call(node) do
return if node.method?(:generate) && node.arguments.count > 1
if node.parenthesized?
process_with_parentheses(node)
else
@ -77,6 +79,8 @@ module RuboCop
end
end
private
def process_with_parentheses(node)
return unless style == :omit_parentheses
return unless same_line?(node, node.first_argument)
@ -102,8 +106,6 @@ module RuboCop
node.parent&.array_type?
end
private
def remove_parentheses(corrector, node)
corrector.replace(node.location.begin, ' ')
corrector.remove(node.location.end)

View File

@ -31,7 +31,7 @@ module RuboCop
# # good
# 3.times { create :user }
#
class CreateList < Base
class CreateList < ::RuboCop::Cop::Base
extend AutoCorrector
include ConfigurableEnforcedStyle
include RuboCop::RSpec::FactoryBot::Language
@ -143,7 +143,7 @@ module RuboCop
def call(corrector)
replacement = generate_n_times_block(node)
corrector.replace(node, replacement)
corrector.replace(node.block_node || node, replacement)
end
private
@ -159,8 +159,15 @@ module RuboCop
replacement = format_receiver(node.receiver)
replacement += format_method_call(node, 'create', arguments)
replacement += " #{factory_call_block_source}" if node.block_node
"#{count.source}.times { #{replacement} }"
end
def factory_call_block_source
node.block_node.location.begin.with(
end_pos: node.block_node.location.end.end_pos
).source
end
end
# :nodoc:

View File

@ -20,7 +20,7 @@ module RuboCop
# factory :foo, class: 'Foo' do
# end
#
class FactoryClassName < Base
class FactoryClassName < ::RuboCop::Cop::Base
extend AutoCorrector
MSG = "Pass '%<class_name>s' string instead of `%<class_name>s` " \

View File

@ -0,0 +1,74 @@
# frozen_string_literal: true
module RuboCop
module Cop
module RSpec
module FactoryBot
# Checks for name style for argument of FactoryBot::Syntax::Methods.
#
# @example EnforcedStyle: symbol (default)
# # bad
# create('user')
# build "user", username: "NAME"
#
# # good
# create(:user)
# build :user, username: "NAME"
#
# @example EnforcedStyle: string
# # bad
# create(:user)
# build :user, username: "NAME"
#
# # good
# create('user')
# build "user", username: "NAME"
#
class FactoryNameStyle < ::RuboCop::Cop::Base
extend AutoCorrector
include ConfigurableEnforcedStyle
include RuboCop::RSpec::FactoryBot::Language
MSG = 'Use %<prefer>s to refer to a factory.'
FACTORY_CALLS = RuboCop::RSpec::FactoryBot::Language::METHODS
RESTRICT_ON_SEND = FACTORY_CALLS
# @!method factory_call(node)
def_node_matcher :factory_call, <<-PATTERN
(send
{#factory_bot? nil?} %FACTORY_CALLS
${str sym} ...
)
PATTERN
def on_send(node)
factory_call(node) do |name|
if offense_for_symbol_style?(name)
register_offense(name, name.value.to_sym.inspect)
elsif offense_for_string_style?(name)
register_offense(name, name.value.to_s.inspect)
end
end
end
private
def offense_for_symbol_style?(name)
name.str_type? && style == :symbol
end
def offense_for_string_style?(name)
name.sym_type? && style == :string
end
def register_offense(name, prefer)
add_offense(name,
message: format(MSG, prefer: style.to_s)) do |corrector|
corrector.replace(name, prefer)
end
end
end
end
end
end
end

Some files were not shown because too many files have changed in this diff Show More