Merge pull request #4311 from commitay/cargo-install

text_cop: require cargo to use `install` instead of `build`

Library/Homebrew/rubocops/text_cop.rb

@@ -53,6 +53,10 @@ module RuboCop
             next if parameters_passed?(d, /vendor-only/)
             problem "use \"dep\", \"ensure\", \"-vendor-only\""
           end
+
+          find_method_with_args(body_node, :system, "cargo", "build") do
+            problem "use \"cargo\", \"install\", \"--root\", prefix"
+          end
         end
       end
     end

Library/Homebrew/test/rubocops/text_cop_spec.rb

@@ -191,5 +191,19 @@ describe RuboCop::Cop::FormulaAudit::Text do
         end
       RUBY
     end
+
+    it "When cargo build is executed" do
+      expect_offense(<<~RUBY)
+        class Foo < Formula
+          url "http://example.com/foo-1.0.tgz"
+          homepage "http://example.com"
+
+          def install
+            system "cargo", "build"
+            ^^^^^^^^^^^^^^^^^^^^^^^ use \"cargo\", \"install\", \"--root\", prefix
+          end
+        end
+      RUBY
+    end
   end
 end