Merge pull request #1433 from bfontaine/audit-escape

audit: Escape interpolated string in regexp
2016-11-03 17:35:12 -04:00 · 2016-11-03 17:35:12 -04:00 · 0028cf9fb8
commit 0028cf9fb8
parent 09f438aecc bfa19b3385
1 changed files with 1 additions and 1 deletions
--- a/Library/Homebrew/dev-cmd/audit.rb
+++ b/Library/Homebrew/dev-cmd/audit.rb
@ -741,7 +741,7 @@ class FormulaAuditor
    end
    bin_names.each do |name|
      ["system", "shell_output", "pipe_output"].each do |cmd|
-        if text =~ /(def test|test do).*#{cmd}[\(\s]+['"]#{name}[\s'"]/m
+        if text =~ /(def test|test do).*#{cmd}[\(\s]+['"]#{Regexp.escape name}[\s'"]/m
          problem %(fully scope test #{cmd} calls e.g. #{cmd} "\#{bin}/#{name}")
        end
      end