From 001c9baa7f2434430bdc9fea8557c599336a5ad7 Mon Sep 17 00:00:00 2001 From: Jack Nagel Date: Mon, 10 Nov 2014 19:25:05 -0600 Subject: [PATCH] Don't record the test if initialization fails When Test.new raises an ArgumentError, nil will be pushed onto the tests array, and then methods will be called on nil when we iterate over the tests while building the XML output. --- Library/Homebrew/cmd/test-bot.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Library/Homebrew/cmd/test-bot.rb b/Library/Homebrew/cmd/test-bot.rb index 7bc3da1217..4c10c1e26f 100644 --- a/Library/Homebrew/cmd/test-bot.rb +++ b/Library/Homebrew/cmd/test-bot.rb @@ -609,9 +609,9 @@ module Homebrew ofail e.message else test_error = !test.run + tests << test end any_errors ||= test_error - tests << test end end